lang, engine: Remove unneeded error wrapping

These situations basically never fail, and if they do, we certainly don't need more context. This simplifies things a bit.
pgraph: Add LookupEdge function
2023-04-20 18:02:40 -04:00 · 2023-04-20 15:45:46 -04:00 · 2023-04-07 11:51:43 -04:00 · 2023-03-31 19:29:52 -04:00 · 2023-03-31 19:29:52 -04:00 · 2023-03-24 16:53:42 -04:00
424 changed files with 7053 additions and 2258 deletions
--- a/.ackrc
+++ b/.ackrc
@@ -1,3 +1,5 @@
 --ignore-dir=old/
 --ignore-dir=tmp/
 --ignore-dir=vendor/
+--ignore-dir=releases/
+--ignore-dir=rpmbuild/
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -27,10 +27,9 @@ jobs:
          # macos tests are currently failing in CI
          #- macos-latest
        golang_version:
-          # TODO: add 1.15.x and tip
+          # TODO: add 1.19.x and tip
          # minimum required and latest published go_version
-          #- 1.13
-          - 1.15
+          - 1.18
        test_block:
          - basic
          - shell
@@ -38,9 +37,8 @@ jobs:
      #fail-fast: false

    steps:
-      # Do not shallow fetch, will fail when building bindata/
-      # The path can't be absolute, so we need to move it to the
-      # expected location later.
+      # Do not shallow fetch. The path can't be absolute, so we need to move it
+      # to the expected location later.
      - name: Clone mgmt
        uses: actions/checkout@v2
        with:
--- a/.gitignore
+++ b/.gitignore
@@ -7,7 +7,6 @@ old/
 tmp/
 *WIP
 *_stringer.go
-bindata/*.go
 mgmt
 mgmt.static
 # crossbuild artifacts
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,39 +0,0 @@
-[submodule "vendor/github.com/coreos/etcd"]
-	path = vendor/go.etcd.io/etcd
-	url = https://github.com/coreos/etcd/
-[submodule "vendor/google.golang.org/grpc"]
-	path = vendor/google.golang.org/grpc
-	url = https://github.com/grpc/grpc-go
-[submodule "vendor/github.com/grpc-ecosystem/grpc-gateway"]
-	path = vendor/github.com/grpc-ecosystem/grpc-gateway
-	url = https://github.com/grpc-ecosystem/grpc-gateway
-[submodule "vendor/gopkg.in/fsnotify.v1"]
-	path = vendor/gopkg.in/fsnotify.v1
-	url = https://gopkg.in/fsnotify.v1
-[submodule "vendor/github.com/purpleidea/go-systemd"]
-	path = vendor/github.com/purpleidea/go-systemd
-	url = https://github.com/purpleidea/go-systemd
-[submodule "vendor/honnef.co/go/augeas"]
-	path = vendor/honnef.co/go/augeas
-	url = https://github.com/dominikh/go-augeas/
-[submodule "vendor/github.com/grpc-ecosystem/go-grpc-prometheus"]
-	path = vendor/github.com/grpc-ecosystem/go-grpc-prometheus
-	url = https://github.com/grpc-ecosystem/go-grpc-prometheus
-[submodule "vendor/github.com/ugorji/go"]
-	path = vendor/github.com/ugorji/go
-	url = https://github.com/ugorji/go
-[submodule "vendor/github.com/purpleidea/docker"]
-	path = vendor/github.com/docker/docker
-	url = https://github.com/purpleidea/docker
-[submodule "vendor/github.com/purpleidea/distribution"]
-	path = vendor/github.com/docker/distribution
-	url = https://github.com/purpleidea/distribution
-[submodule "vendor/github.com/hashicorp/go-multierror"]
-	path = vendor/github.com/hashicorp/go-multierror
-	url = https://github.com/hashicorp/go-multierror
-[submodule "vendor/github.com/containerd/containerd"]
-	path = vendor/github.com/containerd/containerd
-	url = https://github.com/purpleidea/containerd
-[submodule "vendor/github.com/hashicorp/consul"]
-	path = vendor/github.com/hashicorp/consul
-	url = https://github.com/hashicorp/consul/
--- a/.travis.yml
+++ b/.travis.yml
@@ -24,21 +24,21 @@ install: 'make deps'
 matrix:
  fast_finish: false
  allow_failures:
-  - go: 1.14.x
+  - go: 1.19.x
  - go: tip
  - os: osx
  # include only one build for osx for a quicker build as the nr. of these runners are sparse
  include:
  - name: "basic tests"
-    go: 1.13.x
+    go: 1.18.x
    env: TEST_BLOCK=basic
  - name: "shell tests"
-    go: 1.13.x
+    go: 1.18.x
    env: TEST_BLOCK=shell
  - name: "race tests"
-    go: 1.13.x
+    go: 1.18.x
    env: TEST_BLOCK=race
-  - go: 1.14.x
+  - go: 1.19.x
  - go: tip
  - os: osx
 script: 'TEST_BLOCK="$TEST_BLOCK" make test'
--- a/2
+++ b/2
@@ -1,5 +1,5 @@
 Mgmt
-Copyright (C) 2013-2021+ James Shubin and the project contributors
+Copyright (C) 2013-2023+ James Shubin and the project contributors
 Written by James Shubin <james@shubin.ca> and the project contributors

 This program is free software: you can redistribute it and/or modify
--- a/22
+++ b/22
@@ -1,5 +1,5 @@
 # Mgmt
-# Copyright (C) 2013-2021+ James Shubin and the project contributors
+# Copyright (C) 2013-2023+ James Shubin and the project contributors
 # Written by James Shubin <james@shubin.ca> and the project contributors
 #
 # This program is free software: you can redistribute it and/or modify
@@ -16,12 +16,12 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.

 SHELL = /usr/bin/env bash
-.PHONY: all art cleanart version program lang path deps run race bindata generate build build-debug crossbuild clean test gofmt yamlfmt format docs
+.PHONY: all art cleanart version program lang path deps run race generate build build-debug crossbuild clean test gofmt yamlfmt format docs
 .PHONY: rpmbuild mkdirs rpm srpm spec tar upload upload-sources upload-srpms upload-rpms upload-releases copr tag
 .PHONY: mkosi mkosi_fedora-30 mkosi_fedora-29 mkosi_centos-7 mkosi_debian-10 mkosi_ubuntu-bionic mkosi_archlinux
 .PHONY: release releases_path release_fedora-30 release_fedora-29 release_centos-7 release_debian-10 release_ubuntu-bionic release_archlinux
 .PHONY: funcgen
-.SILENT: clean bindata
+.SILENT: clean

 # a large amount of output from this `find`, can cause `make` to be much slower!
 GO_FILES := $(shell find * -name '*.go' -not -path 'old/*' -not -path 'tmp/*')
@@ -137,11 +137,6 @@ run: ## run mgmt
 race:
 	find . -maxdepth 1 -type f -name '*.go' -not -name '*_test.go' | xargs go run -race -ldflags "-X main.program=$(PROGRAM) -X main.version=$(SVERSION)"

-# generate go files from non-go source
-bindata: ## generate go files from non-go sources
-	$(MAKE) --quiet -C bindata
-	$(MAKE) --quiet -C lang/funcs
-
 generate:
 	go generate

@@ -153,7 +148,7 @@ lang: ## generates the lexer/parser for the language frontend
 $(PROGRAM): build/mgmt-${GOHOSTOS}-${GOHOSTARCH} ## build an mgmt binary for current host os/arch
 	cp -a $< $@

-$(PROGRAM).static: $(GO_FILES) $(MCL_FILES)
+$(PROGRAM).static: $(GO_FILES) $(MCL_FILES) go.mod go.sum
 	@echo "Building: $(PROGRAM).static, version: $(SVERSION)..."
 	go generate
 	go build -a -installsuffix cgo -tags netgo -ldflags '-extldflags "-static" -X main.program=$(PROGRAM) -X main.version=$(SVERSION) -s -w' -o $(PROGRAM).static $(BUILD_FLAGS);
@@ -168,18 +163,19 @@ build-debug: $(PROGRAM)
 # extract os and arch from target pattern
 GOOS=$(firstword $(subst -, ,$*))
 GOARCH=$(lastword $(subst -, ,$*))
-build/mgmt-%: $(GO_FILES) $(MCL_FILES) | bindata lang funcgen
+build/mgmt-%: $(GO_FILES) $(MCL_FILES) go.mod go.sum | lang funcgen
 	@echo "Building: $(PROGRAM), os/arch: $*, version: $(SVERSION)..."
-	@time env GOOS=${GOOS} GOARCH=${GOARCH} go build -i -ldflags=$(PKGNAME)="-X main.program=$(PROGRAM) -X main.version=$(SVERSION) ${LDFLAGS}" -o $@ $(BUILD_FLAGS)
+	@time env GOOS=${GOOS} GOARCH=${GOARCH} go build -ldflags=$(PKGNAME)="-X main.program=$(PROGRAM) -X main.version=$(SVERSION) ${LDFLAGS}" -o $@ $(BUILD_FLAGS)

 # create a list of binary file names to use as make targets
+# to use this you might want to run something like:
+# GOOSARCHES='linux/arm64' GOTAGS='noaugeas novirt' make crossbuild
+# and the output will end up in build/
 crossbuild_targets = $(addprefix build/mgmt-,$(subst /,-,${GOOSARCHES}))
 crossbuild: ${crossbuild_targets}

 clean: ## clean things up
 	$(MAKE) --quiet -C test clean
-	$(MAKE) --quiet -C bindata clean
-	$(MAKE) --quiet -C lang/funcs clean
 	$(MAKE) --quiet -C lang clean
 	$(MAKE) --quiet -C misc/mkosi clean
 	rm -f lang/funcs/core/generated_funcs.go || true
--- a/README.md
+++ b/README.md
@@ -5,7 +5,7 @@
 [![Go Report Card](https://goreportcard.com/badge/github.com/purpleidea/mgmt?style=flat-square)](https://goreportcard.com/report/github.com/purpleidea/mgmt)
 [![Build Status](https://img.shields.io/travis/purpleidea/mgmt/master.svg?style=flat-square)](http://travis-ci.org/purpleidea/mgmt)
 [![Build Status](https://github.com/purpleidea/mgmt/workflows/.github/workflows/test.yaml/badge.svg)](https://github.com/purpleidea/mgmt/actions/)
-[![GoDoc](https://img.shields.io/badge/godoc-reference-5272B4.svg?style=flat-square)](https://godoc.org/github.com/purpleidea/mgmt)
+[![GoDoc](https://img.shields.io/badge/godoc-reference-5272B4.svg?style=flat-square)](https://godocs.io/github.com/purpleidea/mgmt)
 [![IRC](https://img.shields.io/badge/irc-%23mgmtconfig-orange.svg?style=flat-square)](https://web.libera.chat/?channels=#mgmtconfig)
 [![Patreon](https://img.shields.io/badge/patreon-donate-yellow.svg?style=flat-square)](https://www.patreon.com/purpleidea)
 [![Liberapay](https://img.shields.io/badge/liberapay-donate-yellow.svg?style=flat-square)](https://liberapay.com/purpleidea/donate)
@@ -100,6 +100,8 @@ Please read, enjoy and help improve our documentation!
 | [prometheus guide](docs/prometheus.md) | for everyone |
 | [puppet guide](docs/puppet-guide.md) | for puppet sysadmins |
 | [development](docs/development.md) | for mgmt developers |
+| [videos](docs/on-the-web.md) | for everyone |
+| [blogs](docs/on-the-web.md) | for everyone |

 ## Questions:

@@ -128,6 +130,6 @@ We'd love to have your patches! Please send them by email, or as a pull request.

 ## On the web:

-[Read what people are saying and publishing about mgmt!](docs/on-the-web.md)
+[Blog posts and recorded talks about mgmt are listed here!](docs/on-the-web.md)

 Happy hacking!
--- a/bindata/Makefile
+++ b/bindata/Makefile
@@ -1,42 +0,0 @@
-# Mgmt
-# Copyright (C) 2013-2021+ James Shubin and the project contributors
-# Written by James Shubin <james@shubin.ca> and the project contributors
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-# The bindata target generates go files from any source defined below. To use
-# the files, import the generated "bindata" package and use:
-# `bytes, err := bindata.Asset("FILEPATH")`
-# where FILEPATH is the path of the original input file relative to `bindata/`.
-# To get a list of files stored in this "bindata" package, you can use:
-# `paths := bindata.AssetNames()` and `paths, err := bindata.AssetDir(name)`
-# to get a list of files with a directory prefix.
-
-.PHONY: build clean
-default: build
-
-build: bindata.go
-
-# add more input files as dependencies at the end here...
-bindata.go: ../COPYING
-	@echo "Generating: bindata..."
-	# go-bindata --pkg bindata -o <OUTPUT> <INPUT>
-	go-bindata --pkg bindata -o ./$@ $^
-	# gofmt the output file
-	gofmt -s -w $@
-	@ROOT=$$(dirname "$${BASH_SOURCE}")/.. && $$ROOT/misc/header.sh '$@'
-
-clean:
-	# remove generated bindata.go
-	@ROOT=$$(dirname "$${BASH_SOURCE}")/.. && rm -f bindata.go
--- a/converger/converger.go
+++ b/converger/converger.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/converger/converger_test.go
+++ b/converger/converger_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package converger

--- a/debian/copyright
+++ b/debian/copyright
@@ -3,7 +3,7 @@ Upstream-Name: mgmt
 Source: <https://github.com/purpleidea/mgmt>

 Files: *
-Copyright: Copyright (C) 2013-2021+ James Shubin and the project contributors
+Copyright: Copyright (C) 2013-2023+ James Shubin and the project contributors
 License: GPL-3.0

 License: GPL-3.0
--- a/doc.go
+++ b/doc.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/docker/Dockerfile
+++ b/docker/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.13
+FROM golang:1.18

 MAINTAINER Michał Czeraszkiewicz <contact@czerasz.com>

--- a/docker/Dockerfile.build
+++ b/docker/Dockerfile.build
@@ -6,7 +6,7 @@ ENV PATH=/opt/rh/rh-ruby22/root/usr/bin:/root/gopath/bin:/usr/local/sbin:/sbin:/
 ENV LD_LIBRARY_PATH=/opt/rh/rh-ruby22/root/usr/lib64${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}
 ENV PKG_CONFIG_PATH=/opt/rh/rh-ruby22/root/usr/lib64/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}

-RUN yum -y install epel-release wget unzip git make which centos-release-scl gcc && sed -i "s/enabled=0/enabled=1/" /etc/yum.repos.d/epel-testing.repo && yum -y install rh-ruby22 && wget -O /opt/go1.9.1.linux-amd64.tar.gz https://storage.googleapis.com/golang/go1.9.1.linux-amd64.tar.gz && tar -C /usr/local -xzf /opt/go1.9.1.linux-amd64.tar.gz
+RUN yum -y install epel-release wget unzip git make which centos-release-scl gcc && sed -i "s/enabled=0/enabled=1/" /etc/yum.repos.d/epel-testing.repo && yum -y install rh-ruby22 && wget -O /opt/go1.18.5.linux-amd64.tar.gz https://storage.googleapis.com/golang/go1.18.5.linux-amd64.tar.gz && tar -C /usr/local -xzf /opt/go1.18.5.linux-amd64.tar.gz
 RUN mkdir -p $GOPATH/src/github.com/purpleidea && cd $GOPATH/src/github.com/purpleidea && git clone --recursive https://github.com/purpleidea/mgmt
 RUN go get -u gopkg.in/alecthomas/gometalinter.v1 && cd $GOPATH/src/github.com/purpleidea/mgmt && make deps && make build
 CMD ["/bin/bash"]
--- a/docker/Dockerfile.development
+++ b/docker/Dockerfile.development
@@ -1,4 +1,4 @@
-FROM golang:1.13
+FROM golang:1.18

 MAINTAINER Michał Czeraszkiewicz <contact@czerasz.com>

@@ -27,8 +27,5 @@ WORKDIR /home/$USER_NAME/mgmt
 # Install dependencies
 RUN make deps

-# Chown $GOPATH
-RUN chown -R ${USER_ID}:${GROUP_ID} /go
-
 # Change user
 USER ${USER_NAME}
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -51,7 +51,7 @@ master_doc = 'index'

 # General information about the project.
 project = u'mgmt'
-copyright = u'2013-2021+ James Shubin and the project contributors'
+copyright = u'2013-2023+ James Shubin and the project contributors'
 author = u'James Shubin'

 # The version info for the project you're documenting, acts as replacement for
--- a/docs/development.md
+++ b/docs/development.md
@@ -28,7 +28,7 @@ required for running the _test_ suite.

 ### Build

-* `golang` 1.13 or higher (required, available in some distros and distributed
+* `golang` 1.18 or higher (required, available in some distros and distributed
 as a binary officially by [golang.org](https://golang.org/dl/))

 ### Runtime
--- a/docs/documentation.md
+++ b/docs/documentation.md
@@ -486,7 +486,7 @@ To report any bugs, please file a ticket at: [https://github.com/purpleidea/mgmt

 ## Authors

-Copyright (C) 2013-2021+ James Shubin and the project contributors
+Copyright (C) 2013-2023+ James Shubin and the project contributors

 Please see the
 [AUTHORS](https://github.com/purpleidea/mgmt/tree/master/AUTHORS) file
--- a/docs/faq.md
+++ b/docs/faq.md
@@ -216,17 +216,6 @@ requires a number of seconds as an argument.
 ./mgmt run lang examples/lang/hello0.mcl --converged-timeout=5
 ```

-### When I try to build `mgmt` I see: `no Go files in $GOPATH/src/github.com/purpleidea/mgmt/bindata`.
-
-Due to the arcane way that `golang` designed its `$GOPATH`, the main project
-directory must be inside your `$GOPATH`, and at the appropriate FQDN. This is:
-`$GOPATH/src/github.com/purpleidea/mgmt/`. If you have your project root outside
-of that directory, then you may get this error when you try to build it. In this
-case there is likely a `go get` version of the project at this location. Remove
-it and replace it with your git cloned directory. In my case, I like to work on
-things in `~/code/mgmt/`, so that path is a symlink that points to the long
-project directory.
-
 ### Why does my file resource error with `no such file or directory`?

 If you create a file resource and only specify the content like this:
@@ -364,6 +353,14 @@ Don't blindly use the tools that others tell you to. Learn what they do, think
 for yourself, and become a power user today! That process led us to using
 `git submodules`. Hopefully you'll come to the same conclusions that we did.

+**UPDATE:**
+
+After golang made it virtually impossible to build without `go.mod` stuff, we've
+switched to it since golang 1.16. I still think the above approach was better,
+and that the `go mod` tooling should have been a layer on top of git submodules
+so that we don't grow yet another lock file format, and existing folks who are
+comfortable with `git` can use those tools directly.
+
 ### Did you know that there is a band named `MGMT`?

 I didn't realize this when naming the project, and it is accidental. After much
--- a/docs/on-the-web.md
+++ b/docs/on-the-web.md
@@ -56,3 +56,4 @@ if we missed something that you think is relevant!
 | James Shubin | video | [Recording from FOSDEM 2020, Infra Management Devroom](https://video.fosdem.org/2020/UA2.120/mgmt.webm) |
 | James Shubin | video | [Recording from FOSDEM 2020, Minimalistic Languages Devroom](https://video.fosdem.org/2020/AW1.125/mgmtconfigmore.webm) |
 | James Shubin | video | [Recording from CfgMgmtCamp.eu 2020](https://www.youtube.com/watch?v=Kd7FAORFtsc) |
+| James Shubin | video | [Recording from CfgMgmtCamp.eu 2023](https://www.youtube.com/watch?v=FeRGRj8w0BU) |
--- a/docs/quick-start-guide.md
+++ b/docs/quick-start-guide.md
@@ -37,7 +37,7 @@ You'll need some dependencies, including `golang`, and some associated tools.

 #### Installing golang

-* You need golang version 1.13 or greater installed.
+* You need golang version 1.18 or greater installed.
 	* To install on rpm style systems: `sudo dnf install golang`
 	* To install on apt style systems: `sudo apt install golang`
 	* To install on macOS systems install [Homebrew](https://brew.sh)
@@ -63,13 +63,11 @@ export GOPATH=$HOME/gopath

 #### Getting the mgmt code and associated dependencies

-* Download the `mgmt` code into the `GOPATH`, and switch to that directory:
+* Download the `mgmt` code and switch to that directory:

 ```shell
-[ -z "$GOPATH" ] && mkdir ~/go/ || mkdir -p $GOPATH/src/github.com/purpleidea/
-cd $GOPATH/src/github.com/purpleidea/ || cd ~/go/
-git clone --recursive https://github.com/purpleidea/mgmt/
-cd $GOPATH/src/github.com/purpleidea/mgmt/ || cd ~/go/src/github.com/purpleidea/mgmt/
+git clone --recursive https://github.com/purpleidea/mgmt/ ~/mgmt/
+cd ~/mgmt/
 ```

 * Add `$GOPATH/bin` to `$PATH`
--- a/engine/autoedge.go
+++ b/engine/autoedge.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/autoedge_test.go
+++ b/engine/autoedge_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package engine

--- a/engine/autogroup.go
+++ b/engine/autogroup.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/cmp.go
+++ b/engine/cmp.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/copy.go
+++ b/engine/copy.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/doc.go
+++ b/engine/doc.go
@@ -0,0 +1,21 @@
+// Mgmt
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
+// Written by James Shubin <james@shubin.ca> and the project contributors
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+// Package engine represents the implementation of the resource engine that runs
+// the graph of resources in real-time. This package has the common imports that
+// most consumers use directly.
+package engine
--- a/engine/edge.go
+++ b/engine/edge.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/error.go
+++ b/engine/error.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/fs.go
+++ b/engine/fs.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/actions.go
+++ b/engine/graph/actions.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/autoedge.go
+++ b/engine/graph/autoedge.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/autoedge/autoedge.go
+++ b/engine/graph/autoedge/autoedge.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/autogroup.go
+++ b/engine/graph/autogroup.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/autogroup/autogroup.go
+++ b/engine/graph/autogroup/autogroup.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/autogroup/autogroup_test.go
+++ b/engine/graph/autogroup/autogroup_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package autogroup

@@ -595,7 +595,8 @@ func TestPgraphGrouping11(t *testing.T) {
 	runGraphCmp(t, g1, g2)
 }

-/* simple merge 1
+/*
+// simple merge 1
 // a1   a2         a1,a2
 //   \ /     >>>     |     (arrows point downwards)
 //    b              b
@@ -621,7 +622,8 @@ func TestPgraphGrouping12(t *testing.T) {
 	runGraphCmp(t, g1, g2)
 }

-/* simple merge 2
+/*
+// simple merge 2
 //    b              b
 //   / \     >>>     |     (arrows point downwards)
 // a1   a2         a1,a2
@@ -647,7 +649,8 @@ func TestPgraphGrouping13(t *testing.T) {
 	runGraphCmp(t, g1, g2)
 }

-/* triple merge
+/*
+// triple merge
 // a1 a2  a3         a1,a2,a3
 //   \ | /     >>>       |      (arrows point downwards)
 //     b                 b
@@ -676,7 +679,8 @@ func TestPgraphGrouping14(t *testing.T) {
 	runGraphCmp(t, g1, g2)
 }

-/* chain merge
+/*
+// chain merge
 //    a1             a1
 //   /  \             |
 // b1    b2   >>>   b1,b2   (arrows point downwards)
@@ -712,7 +716,8 @@ func TestPgraphGrouping15(t *testing.T) {
 	runGraphCmp(t, g1, g2)
 }

-/* re-attach 1 (outer)
+/*
+// re-attach 1 (outer)
 // technically the second possibility is valid too, depending on which order we
 // merge edges in, and if we don't filter out any unnecessary edges afterwards!
 // a1    a2         a1,a2        a1,a2
@@ -748,7 +753,8 @@ func TestPgraphGrouping16(t *testing.T) {
 	runGraphCmp(t, g1, g2)
 }

-/* re-attach 2 (inner)
+/*
+// re-attach 2 (inner)
 // a1    b2          a1
 //  |   /             |
 // b1  /      >>>   b1,b2   (arrows point downwards)
@@ -782,7 +788,8 @@ func TestPgraphGrouping17(t *testing.T) {
 	runGraphCmp(t, g1, g2)
 }

-/* re-attach 3 (double)
+/*
+// re-attach 3 (double)
 // similar to "re-attach 1", technically there is a second possibility for this
 // a2   a1    b2         a1,a2
 //   \   |   /             |
@@ -820,7 +827,8 @@ func TestPgraphGrouping18(t *testing.T) {
 	runGraphCmp(t, g1, g2)
 }

-/* connected merge 0, (no change!)
+/*
+// connected merge 0, (no change!)
 // a1            a1
 //   \     >>>     \     (arrows point downwards)
 //    a2            a2
@@ -843,7 +851,8 @@ func TestPgraphGroupingConnected0(t *testing.T) {
 	runGraphCmp(t, g1, g2)
 }

-/* connected merge 1, (no change!)
+/*
+// connected merge 1, (no change!)
 // a1              a1
 //   \               \
 //    b      >>>      b      (arrows point downwards)
--- a/engine/graph/autogroup/base.go
+++ b/engine/graph/autogroup/base.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/autogroup/nonreachability.go
+++ b/engine/graph/autogroup/nonreachability.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/autogroup/util.go
+++ b/engine/graph/autogroup/util.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/engine.go
+++ b/engine/graph/engine.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,6 +15,9 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

+// Package graph contains the actual implementation of the resource graph engine
+// that runs the graph of resources in real-time. This package has the algorithm
+// that runs all the graph transitions.
 package graph

 import (
@@ -40,6 +43,7 @@ const (
 // Engine encapsulates a generic graph and manages its operations.
 type Engine struct {
 	Program  string
+	Version  string
 	Hostname string
 	World    engine.World

@@ -195,6 +199,7 @@ func (obj *Engine) Commit() error {
 			Vertex: vertex,

 			Program:  obj.Program,
+			Version:  obj.Version,
 			Hostname: obj.Hostname,

 			World:  obj.World,
--- a/engine/graph/graph_test.go
+++ b/engine/graph/graph_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package graph

--- a/engine/graph/refresh.go
+++ b/engine/graph/refresh.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/reverse.go
+++ b/engine/graph/reverse.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/semaphore.go
+++ b/engine/graph/semaphore.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/semaphore_test.go
+++ b/engine/graph/semaphore_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package graph

--- a/engine/graph/sendrecv.go
+++ b/engine/graph/sendrecv.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graph/state.go
+++ b/engine/graph/state.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -40,6 +40,7 @@ type State struct {
 	Vertex pgraph.Vertex

 	Program  string
+	Version  string
 	Hostname string
 	World    engine.World

@@ -154,6 +155,7 @@ func (obj *State) Init() error {

 	obj.init = &engine.Init{
 		Program:  obj.Program,
+		Version:  obj.Version,
 		Hostname: obj.Hostname,

 		// Watch:
@@ -186,7 +188,7 @@ func (obj *State) Init() error {
 		FilteredGraph: func() (*pgraph.Graph, error) {
 			graph, err := pgraph.NewGraph("filtered")
 			if err != nil {
-				return nil, errwrap.Wrapf(err, "could not create graph")
+				return nil, err
 			}

 			// filter graph and build a new one...
--- a/engine/graph/vardir.go
+++ b/engine/graph/vardir.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/graphqueryable.go
+++ b/engine/graphqueryable.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/metaparams.go
+++ b/engine/metaparams.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/metaparams_test.go
+++ b/engine/metaparams_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package engine

--- a/engine/refresh.go
+++ b/engine/refresh.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources.go
+++ b/engine/resources.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -87,6 +87,9 @@ type Init struct {
 	// Program is the name of the program.
 	Program string

+	// Version is the version of the program.
+	Version string
+
 	// Hostname is the uuid for the host.
 	Hostname string

--- a/engine/resources/augeas.go
+++ b/engine/resources/augeas.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !noaugeas
+//go:build !noaugeas

 package resources

@@ -29,8 +29,6 @@ import (
 	"github.com/purpleidea/mgmt/recwatch"
 	"github.com/purpleidea/mgmt/util/errwrap"

-	// FIXME: we vendor go/augeas because master requires augeas 1.6.0
-	// and libaugeas-dev-1.6.0 is not yet available in a PPA.
 	"honnef.co/go/augeas"
 )

--- a/engine/resources/aws_ec2.go
+++ b/engine/resources/aws_ec2.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/config_etcd.go
+++ b/engine/resources/config_etcd.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/consul_kv.go
+++ b/engine/resources/consul_kv.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/consul_kv_test.go
+++ b/engine/resources/consul_kv_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/cron.go
+++ b/engine/resources/cron.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -33,10 +33,10 @@ import (
 	"github.com/purpleidea/mgmt/util"
 	"github.com/purpleidea/mgmt/util/errwrap"

-	sdbus "github.com/coreos/go-systemd/dbus"
-	"github.com/coreos/go-systemd/unit"
-	systemdUtil "github.com/coreos/go-systemd/util"
-	"github.com/godbus/dbus"
+	sdbus "github.com/coreos/go-systemd/v22/dbus"
+	"github.com/coreos/go-systemd/v22/unit"
+	systemdUtil "github.com/coreos/go-systemd/v22/util"
+	"github.com/godbus/dbus/v5"
 )

 const (
--- a/engine/resources/dhcp.go
+++ b/engine/resources/dhcp.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/lang/funcs/bindata/doc.go
+++ b/lang/funcs/bindata/doc.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,5 +15,5 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// Package bindata stores core mcl code that is built-in at compile time.
-package bindata
+// Package resources contains the implementations of all the core resources.
+package resources
--- a/engine/resources/docker_container.go
+++ b/engine/resources/docker_container.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !nodocker
+//go:build !nodocker

 package resources

--- a/engine/resources/docker_container_test.go
+++ b/engine/resources/docker_container_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !nodocker
+//go:build !nodocker

 package resources

--- a/engine/resources/docker_image.go
+++ b/engine/resources/docker_image.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !nodocker
+//go:build !nodocker

 package resources

--- a/engine/resources/exec.go
+++ b/engine/resources/exec.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/exec_test.go
+++ b/engine/resources/exec_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package resources

--- a/engine/resources/file.go
+++ b/engine/resources/file.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/file_test.go
+++ b/engine/resources/file_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package resources

--- a/engine/resources/group.go
+++ b/engine/resources/group.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/hetzner_vm.go
+++ b/engine/resources/hetzner_vm.go
--- a/engine/resources/hostname.go
+++ b/engine/resources/hostname.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -27,7 +27,7 @@ import (
 	"github.com/purpleidea/mgmt/util"
 	"github.com/purpleidea/mgmt/util/errwrap"

-	"github.com/godbus/dbus"
+	"github.com/godbus/dbus/v5"
 )

 func init() {
--- a/engine/resources/http.go
+++ b/engine/resources/http.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/kv.go
+++ b/engine/resources/kv.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/mount.go
+++ b/engine/resources/mount.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -35,11 +35,11 @@ import (
 	"github.com/purpleidea/mgmt/util"
 	"github.com/purpleidea/mgmt/util/errwrap"

-	sdbus "github.com/coreos/go-systemd/dbus"
-	"github.com/coreos/go-systemd/unit"
-	systemdUtil "github.com/coreos/go-systemd/util"
+	sdbus "github.com/coreos/go-systemd/v22/dbus"
+	"github.com/coreos/go-systemd/v22/unit"
+	systemdUtil "github.com/coreos/go-systemd/v22/util"
 	fstab "github.com/deniswernert/go-fstab"
-	"github.com/godbus/dbus"
+	"github.com/godbus/dbus/v5"
 	"golang.org/x/sys/unix"
 )

--- a/engine/resources/mount_linux_test.go
+++ b/engine/resources/mount_linux_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root !darwin
+//go:build !root || !darwin

 package resources

--- a/engine/resources/mount_test.go
+++ b/engine/resources/mount_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package resources

--- a/engine/resources/msg.go
+++ b/engine/resources/msg.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -25,7 +25,7 @@ import (
 	"github.com/purpleidea/mgmt/engine"
 	"github.com/purpleidea/mgmt/engine/traits"

-	"github.com/coreos/go-systemd/journal"
+	"github.com/coreos/go-systemd/v22/journal"
 )

 func init() {
--- a/engine/resources/msg_test.go
+++ b/engine/resources/msg_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package resources

--- a/engine/resources/net.go
+++ b/engine/resources/net.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !darwin
+//go:build !darwin

 package resources

--- a/engine/resources/net_test.go
+++ b/engine/resources/net_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !darwin
+//go:build !darwin

 package resources

--- a/engine/resources/noop.go
+++ b/engine/resources/noop.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/noop_test.go
+++ b/engine/resources/noop_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package resources

--- a/engine/resources/nspawn.go
+++ b/engine/resources/nspawn.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -30,10 +30,10 @@ import (
 	"github.com/purpleidea/mgmt/util"
 	"github.com/purpleidea/mgmt/util/errwrap"

-	systemdDbus "github.com/coreos/go-systemd/dbus"
-	machined "github.com/coreos/go-systemd/machine1"
-	systemdUtil "github.com/coreos/go-systemd/util"
-	"github.com/godbus/dbus"
+	systemdDbus "github.com/coreos/go-systemd/v22/dbus"
+	machined "github.com/coreos/go-systemd/v22/machine1"
+	systemdUtil "github.com/coreos/go-systemd/v22/util"
+	"github.com/godbus/dbus/v5"
 )

 const (
--- a/engine/resources/packagekit/packagekit.go
+++ b/engine/resources/packagekit/packagekit.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -29,7 +29,7 @@ import (
 	"github.com/purpleidea/mgmt/util"
 	"github.com/purpleidea/mgmt/util/errwrap"

-	"github.com/godbus/dbus"
+	"github.com/godbus/dbus/v5"
 )

 // global tweaks of verbosity and code path
--- a/engine/resources/password.go
+++ b/engine/resources/password.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/pippet.go
+++ b/engine/resources/pippet.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/pippet_test.go
+++ b/engine/resources/pippet_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package resources

--- a/engine/resources/pkg.go
+++ b/engine/resources/pkg.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/pkg_test.go
+++ b/engine/resources/pkg_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package resources

--- a/engine/resources/print.go
+++ b/engine/resources/print.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/resources_test.go
+++ b/engine/resources/resources_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package resources

@@ -745,7 +745,7 @@ func TestResources2(t *testing.T) {
 			FilteredGraph: func() (*pgraph.Graph, error) {
 				//graph, err := pgraph.NewGraph("filtered")
 				//if err != nil {
-				//	return nil, errwrap.Wrapf(err, "could not create graph")
+				//	return nil, err
 				//}
 				// Hack: We just add ourself as allowed since
 				// we're just a one-vertex test suite...
--- a/engine/resources/svc.go
+++ b/engine/resources/svc.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -30,9 +30,9 @@ import (
 	"github.com/purpleidea/mgmt/util"
 	"github.com/purpleidea/mgmt/util/errwrap"

-	systemd "github.com/coreos/go-systemd/dbus" // change namespace
-	systemdUtil "github.com/coreos/go-systemd/util"
-	"github.com/godbus/dbus" // namespace collides with systemd wrapper
+	systemd "github.com/coreos/go-systemd/v22/dbus" // change namespace
+	systemdUtil "github.com/coreos/go-systemd/v22/util"
+	"github.com/godbus/dbus/v5" // namespace collides with systemd wrapper
 )

 func init() {
--- a/engine/resources/test.go
+++ b/engine/resources/test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/test_test.go
+++ b/engine/resources/test_test.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !root
+//go:build !root

 package resources

--- a/engine/resources/tftp.go
+++ b/engine/resources/tftp.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/timer.go
+++ b/engine/resources/timer.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/user.go
+++ b/engine/resources/user.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/engine/resources/virt.go
+++ b/engine/resources/virt.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.

-// +build !novirt
+//go:build !novirt

 package resources

--- a/engine/reverse.go
+++ b/engine/reverse.go
@@ -1,5 +1,5 @@
 // Mgmt
-// Copyright (C) 2013-2021+ James Shubin and the project contributors
+// Copyright (C) 2013-2023+ James Shubin and the project contributors
 // Written by James Shubin <james@shubin.ca> and the project contributors
 //
 // This program is free software: you can redistribute it and/or modify
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
James Shubin	c5efe7a17b	lang, engine: Remove unneeded error wrapping These situations basically never fail, and if they do, we certainly don't need more context. This simplifies things a bit.	2023-04-20 18:02:40 -04:00
James Shubin	7075b8b973	pgraph: Add LookupEdge function The new LookupEdge function lets you find which vertices are associated with a particular edge, if any.	2023-04-20 15:45:46 -04:00
James Shubin	3f5957d30e	docs: readme: Add new talk and clarify README This should make it more obvious how to reach this content as it might not have been particularly clear to new users where to find this information.	2023-04-07 11:51:43 -04:00
James Shubin	bc29957d1e	lang: Add a useful debug message to tests When running this test a lot in series, it helps to have more obvious debug output.	2023-03-31 19:29:52 -04:00
James Shubin	289835039a	lang: Remove SetValue from the engine This removes the calling of SetValue from the engine, and instead replaces it with the Table() API. The downside is that this is likely slower, and the current API with locking being exposed publicly is kind of ugly. The upside is that this might make building the new engine easier. Future versions might remove locking from the API if we can avoid making any accesses to expressions. Currently this happens within Logf/SafeLogf which is our main (only?) usage at the moment. Logging could become smarter perhaps. Alternatively, we might pass in a "setter" function that gets called safely from within the engine. This could wrap SetValue and the locking functions wouldn't be part of the public API.	2023-03-31 19:29:52 -04:00
James Shubin	b1e08ef231	util: deadline: Add a simple test for deadline and testing This is a simple test/example placeholder if we want to remember how to run deadlines with contexts for testing.	2023-03-24 16:53:42 -04:00
James Shubin	8a463767bf	lang: funcs: Make printable function names more unique This helps a lot with debugging.	2023-03-24 16:50:01 -04:00
James Shubin	c598e4d289	engine, etcd: Update code for latest gofmt fixes Latest version of golang broken gofmt again...	2023-03-14 16:43:08 -04:00
James Shubin	a7624a2bf9	legal: Happy 2023 everyone... Done with: ack '2022+' -l \| xargs sed -i -e 's/2022+/2023+/g' Checked manually with: git add -p Hello to future James from 2024, and Happy Hacking!	2023-03-05 18:31:52 -05:00
James Shubin	d20fcbd845	lang: Fixup tests that broke I should not have changed the error string when I unified the pgraph library.	2023-03-03 14:47:30 -05:00
James Shubin	5d664855de	lang: interfaces, funcs: Implement fmt.Stringer for functions This adds the requirement that all function implementations provider a String() string method so that these can be used as vertices in the pgraph library. If we eventually move to generics for the pgraph DAG, then this might not matter, but it's not bad that these have names either.	2023-03-03 14:12:09 -05:00
James Shubin	8366cf0873	pgraph: Add a named error for detected cycles This makes it useful to find when a topological sort failed.	2023-02-25 23:20:05 -05:00
James Shubin	a41789a746	examples, lang: funcs: core: example: Update vumeter This patch moves to use the sox package instead of arecord for getting microphone data, and it also validates that both sox and rec and installed. We also add a standalone example.	2023-02-08 12:14:11 -05:00
James Shubin	cde3251dd8	test: shell: Disable flaky network test	2022-11-11 22:42:29 -05:00
James Shubin	7c394bf735	lang: Move the Edge struct into the interfaces package This makes it consumable from more than one package and avoids future cycles.	2022-11-11 20:28:22 -05:00
James Shubin	76e0345609	pgraph: Make some functions variadic for consistency This will make it more useful when consuming these functions in a Txn API which might be more convenient as a big one-liner.	2022-11-11 20:20:14 -05:00
James Shubin	d8820fa185	make: Improve crossbuild docs	2022-10-24 02:38:38 -04:00
James Shubin	b6502693e4	make, golang: Work around new go.mod issues This updates the versions of virtually all our deps. Ever since golang switched to go.mod we were unable to do so due to blockages with the retract mechanism that one dep had used. Here's what seems like a workaround for now. Suggestions from expert welcome.	2022-10-17 19:36:12 -04:00
James Shubin	f7e5402966	make: Remove missing clean target This is no longer present.	2022-09-12 14:27:39 -04:00
James Shubin	1e6a825412	lang: funcs: Add cancel methods in a different way Previously go vet found: "this return statement may be reached without using the cancel var defined on line..."	2022-09-12 14:11:25 -04:00
Samuel Gélineau	c23065aacd	lang: funcs: Add SystemFunc Runs a string as a shell command, then produces each line from stdout.	2022-09-11 21:58:39 -04:00
James Shubin	04f5ba67a2	lang: Small build fixes	2022-09-11 21:43:57 -04:00
James Shubin	b87fa6715b	misc: Exclude more directories from ack matching This is almost always what we want.	2022-09-11 20:55:37 -04:00
James Shubin	f6f3298e03	misc: Use go install instead of go get for build binaries	2022-09-11 20:55:37 -04:00
James Shubin	6bfd781947	lang: Replace the go-bindata usage with embed This doesn't let us have nested mcl at the moment, but we could improve on this with an embed API for each package. For now this makes building the project easier.	2022-09-11 20:55:37 -04:00
James Shubin	aff6331211	misc, docs: Move to golang 1.18 Hopefully this fixes some yucky things.	2022-09-11 20:55:37 -04:00
James Shubin	d547c39a16	misc, docs: Move to golang 1.17 There are a few small source fixes and other tidbits to move past 1.16, but we can do those later.	2022-08-16 19:30:20 -04:00
James Shubin	3cea422365	legal: Happy 2022 everyone... Done with: ack '2021+' -l \| xargs sed -i -e 's/2021+/2022+/g' Checked manually with: git add -p Hello to future James from 2023, and Happy Hacking!	2022-08-05 23:06:27 -04:00
James Shubin	ac39606386	lang: Misc changes from an old feature branch	2022-08-04 14:49:24 -04:00
James Shubin	12ae44d563	lang: funcs: core: fmt: Add important comment to printf	2022-08-04 14:36:56 -04:00
James Shubin	57b37d9005	pgraph: Misc cleanups and additions that I had kicking around These changes had been sitting in a feature branch for a while. Push them up.	2022-08-04 14:36:56 -04:00
James Shubin	9d5cc07567	lang: funcs: core: iter: Add map iterator function part3 This flattens the type unification of the map function so that the solver has more to work with. It's possible that some scenarios might solve faster, or without recursion, after this improvement.	2022-08-04 14:24:38 -04:00
James Shubin	75d4d767c6	lang: funcs: core: iter: Add map iterator function part2 This adds the Unify method to our map function and also switches the arg order because I decided it would look nicer. Completely untested.	2022-08-04 14:24:05 -04:00
James Shubin	0be4b86230	lang: funcs: core: iter: Add map iterator function Sadly this doesn't all work yet, but the tests and xmap function are approximately correct. Eventually we add filter and reduce too!	2022-08-04 14:23:16 -04:00
James Shubin	784d15b012	all: Misc housekeeping for new golang versions	2022-08-04 14:16:33 -04:00
James Shubin	00f6045b12	util: safepath: Add a new Dir method and tests This adds a new helper method. It should be considered for other types as well.	2022-05-10 23:44:48 -04:00
Jef Masereel	b26f842de1	engine: resources: Add hetzner:vm resource Hetzner cloud resource using hcloud-go. Requires polling via Meta:poll param. This first commit provides a stable vm resource with support for the basic functions of creating, deleting and updating a live server instance. SSH key handling does still require some attention to make sure checkapply can detect and update live changes to the specified keylist. A dedicated hetzner:sshkeys resource might be in order to make sure the keyset is handled correctly if there are multiple hetzner:vm resources running under the same Hetzner project. All remarks for future improvements are indicated with a TODO prefix	2022-04-20 14:24:25 -04:00
James Shubin	0ab2406db9	engine: Pass through the program version We forgot this in a few places.	2022-02-17 13:34:26 -05:00
Joe Groocock	bf7e45439b	engine: util: Skip unexported fields in struct field mapping Unexported fields should be ignored when mapping structs from Golang to mcl, as this avoids issues where certain structs cannot be used in mcl representation due to their structure that may be incompatible with conversion. Disallowing private fields allows those to still be included in the struct but ignored when mapping the types, allowing the mcl representation of the type to stil be valid Resolves: https://github.com/purpleidea/mgmt/issues/684 Signed-off-by: Joe Groocock <me@frebib.net>	2021-12-01 22:06:06 +00:00
dantefromhell	0652273fe1	misc: Add systemd service file to release packages According to [1] "/usr/lib/systemd/system/" is where systemd files from installed packages are stored in Arch Linux Big thanks to @jordansissel for the in-depth explanation of this PRs effects: > This PR replaces --prefix with the fpm dir package type's feature "path mapping" which lets you map a local file to a destination file when creating the package using this syntax: localpath=destinationpath [1] https://wiki.archlinux.org/title/Systemd#Writing_unit_files	2021-11-09 21:42:50 +00:00
James Shubin	5927a54208	docs: Improve autogenerate godoc There were a bunch of packages that weren't well documented. With the recent split up of the lang package, I figured it would be more helpful for new contributors who want to learn the structure of the project.	2021-10-26 00:12:18 -04:00
James Shubin	b46db59948	readme: Update to new godoc link Thanks to Drew DeVault for hosting this.	2021-10-22 17:44:08 -04:00
James Shubin	23b5a4729f	lang: Split lang package out into many subpackages This is a giant refactor to split the giant lang package into many subpackages. The most difficult piece was figuring out how to extract the extra ast structs into their own package, because they needed to call two functions which also needed to import the ast. The solution was to separate out those functions into their own packages, and to pass them into the ast at the root when they're needed, and to let the relevant ast portions call a handle. This isn't terribly ugly because we already had a giant data struct woven through the ast. The bad part is rebasing any WIP work on top of this.	2021-10-21 04:13:04 -04:00
James Shubin	8ae47bd490	test: Disable flaky shell tests We need to improve and add these things back eventually, but for now I don't want intermittent failures.	2021-10-21 01:17:52 -04:00
James Shubin	1796d20399	lang: Split the download code out into its own package More cleanups.	2021-10-21 00:05:37 -04:00
James Shubin	5ac2447b85	lang: Split out the GAPI code for the lang frontend This can go in a separate package.	2021-10-21 00:03:07 -04:00
James Shubin	db445c3a8e	lang: Move the inputs logic into a separate package	2021-10-20 18:13:46 -04:00
James Shubin	de2914978d	lang: Move interpret function to a separate package	2021-10-20 17:50:21 -04:00
James Shubin	09812a7bfc	lang: Rename prog struct field to body This is more consistent and avoids the future prog.prog stuttering.	2021-10-20 16:24:14 -04:00
James Shubin	2eb3b541f4	lang: Fix typo	2021-10-20 15:32:43 -04:00
James Shubin	e9791ff92c	lang: funcs: core: fmt: Add variant verb for printf There's no reason we can't support a %v variant verb. Of course it makes type unification more difficult, and certain uses of this will produce unsolvable situations, but it's useful for debugging, and fun to have.	2021-10-11 00:36:29 -04:00
James Shubin	88516546fa	lib: Move to go modules and shed a few tears The old system with vendor/ and git submodules worked great, unfortunately FUD around git submodules seemed to scare people away and golang moved to a go.mod system that adds a new lock file format instead of using the built-in git version. It's now almost impossible to use modern golang without this, so we've switched. So much for the golang compatibility promise-- turns out it doesn't apply to the useful parts that I actually care about like this. Thanks to frebib for his incredibly valuable contributions to this patch. This snide commit message is mine alone. This patch also mixes in some changes due to legacy golang as we've also bumped the minimum version to 1.16 in the docs and tests. Lastly, we had to disable some tests and fix up a few other misc things to get this passing. We've definitely hot bugs in the go.mod system, and our Makefile tries to workaround those.	2021-10-05 08:34:51 -04:00