91a9edb322
If we get an error in the Watch loop, it will send this on awsChan, which will cause Watch to loop. However, in this scenario it will never cause closeChan to close, and we will deadlock because we have a waitGroup in a helper goroutine which is waiting on this channel to close the context. Normally this wouldn't be an issue, but since we have more than one goroutine (with associated waitGroup) it is. It's also good practice to close all the channels to help avoid this kind of bug. This patch also moves the waitGroup Wait into a more logical place for visibility.
mgmt: next generation config management!
Community:
Come join us in the mgmt community!
| Medium | Link |
|---|---|
| IRC | #mgmtconfig on Freenode |
| @mgmtconfig & #mgmtconfig | |
| Mailing list | mgmtconfig-list@redhat.com |
Status:
Mgmt is a fairly new project. We're working towards being minimally useful for production environments. We aren't feature complete for what we'd consider a 1.x release yet. With your help you'll be able to influence our design and get us there sooner!
Documentation:
Please read, enjoy and help improve our documentation!
| Documentation | Additional Notes |
|---|---|
| general documentation | for everyone |
| quick start guide | for mgmt developers |
| resource guide | for mgmt developers |
| godoc API reference | for mgmt developers |
| prometheus guide | for everyone |
| puppet guide | for puppet sysadmins |
Questions:
Please ask in the community! If you have a well phrased question that might benefit others, consider asking it by sending a patch to the documentation FAQ section. I'll merge your question, and a patch with the answer!
Roadmap:
Please see: TODO.md for a list of upcoming work and TODO items. Please get involved by working on one of these items or by suggesting something else! Feel free to grab one of the straightforward #mgmtlove issues if you're a first time contributor to the project or if you're unsure about what to hack on!
Bugs:
Please set the DEBUG constant in main.go to true, and post the logs when you report the issue.
Bonus points if you provide a shell or OMV reproducible test case.
Feel free to read my article on debugging golang programs.
Patches:
We'd love to have your patches! Please send them by email, or as a pull request.
On the web:
Happy hacking!