test: Add a check for too long or badly reflowed docstrings
This ensures that docstring comments are wrapped to 80 chars. ffrank seemed to be making this mistake far too often, and it's a silly thing to look for manually. As it turns out, I've made it too, as have many others. Now we have a test that checks for most cases. There are still a few stray cases that aren't checked automatically, but this can be improved upon if someone is motivated to do so. Before anyone complains about the 80 character limit: this only checks docstring comments, not source code length or inline source code comments. There's no excuse for having docstrings that are badly reflowed or over 80 chars, particularly if you have an automated test.
This commit is contained in:
@@ -67,8 +67,8 @@ func (obj *PrintfFunc) ArgGen(index int) (string, error) {
|
||||
// Polymorphisms returns the possible type signature for this function. In this
|
||||
// case, since the number of arguments can be infinite, it returns the final
|
||||
// precise type if it can be gleamed from the format argument. If it cannot, it
|
||||
// is because either the format argument was not known statically, or because
|
||||
// it had an invalid format string.
|
||||
// is because either the format argument was not known statically, or because it
|
||||
// had an invalid format string.
|
||||
func (obj *PrintfFunc) Polymorphisms(partialType *types.Type, partialValues []types.Value) ([]*types.Type, error) {
|
||||
if partialType == nil || len(partialValues) < 1 {
|
||||
return nil, fmt.Errorf("first argument must be a static format string")
|
||||
|
||||
Reference in New Issue
Block a user