lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: Avoid matching three X's

Browse Source 
This helps my "WIP" detector script avoid false positives. It is a
simple script which helps me find release critical problems.
This commit is contained in:
James Shubin
2017-03-01 22:37:08 -05:00
parent 73ccbb69ea
commit 5f060d60a7
3 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/test-golint.sh
View File

@@ -28,7 +28,7 @@ COUNT=`echo -e "$LINT" | wc -l` # number of golint problems in current branch
[ "$LINT" = "" ] && echo PASS && exit # everything is "perfect" [ "$LINT" = "" ] && echo PASS && exit # everything is "perfect"
echo "$LINT" # display the issues echo "$LINT" # display the issues
T=`mktemp --tmpdir -d tmp.XXX` T=`mktemp --tmpdir -d tmp.X'X'X` # add quotes to avoid matching three X's
[ "$T" = "" ] && fail_test "Could not create tmpdir" [ "$T" = "" ] && fail_test "Could not create tmpdir"
cd $T || fail_test "Could not change into tmpdir $T" cd $T || fail_test "Could not change into tmpdir $T"
git clone --recursive "${ROOT}" 2>/dev/null # make a copy git clone --recursive "${ROOT}" 2>/dev/null # make a copy

3
test/test-govet.sh
View File

@@ -22,7 +22,8 @@ function simplify-gocase() {
} }
function token-coloncheck() { function token-coloncheck() {
if grep -Ei "[\/]+[\/]+[ ]*+(FIXME[^:]|TODO[^:]|XXX[^:])" "$1"; then # add quotes to avoid matching three X's
if grep -Ei "[\/]+[\/]+[ ]*+(FIXME[^:]|TODO[^:]|X"'X'"X[^:])" "$1"; then
return 1 # tokens must end with a colon return 1 # tokens must end with a colon
fi fi
return 0 return 0

2
test/test-reproducible.sh
View File

@@ -7,7 +7,7 @@ set -o pipefail
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && cd .. && pwd )" # dir! DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && cd .. && pwd )" # dir!
cd "$DIR" >/dev/null # work from main mgmt directory cd "$DIR" >/dev/null # work from main mgmt directory
make build make build
T=`mktemp --tmpdir -d tmp.XXX` T=`mktemp --tmpdir -d tmp.X'X'X` # add quotes to avoid matching three X's
cp -a ./mgmt "$T"/mgmt.1 cp -a ./mgmt "$T"/mgmt.1
make clean make clean
make build make build