test: Avoid matching three X's
This helps my "WIP" detector script avoid false positives. It is a simple script which helps me find release critical problems.
This commit is contained in:
@@ -28,7 +28,7 @@ COUNT=`echo -e "$LINT" | wc -l` # number of golint problems in current branch
|
||||
[ "$LINT" = "" ] && echo PASS && exit # everything is "perfect"
|
||||
echo "$LINT" # display the issues
|
||||
|
||||
T=`mktemp --tmpdir -d tmp.XXX`
|
||||
T=`mktemp --tmpdir -d tmp.X'X'X` # add quotes to avoid matching three X's
|
||||
[ "$T" = "" ] && fail_test "Could not create tmpdir"
|
||||
cd $T || fail_test "Could not change into tmpdir $T"
|
||||
git clone --recursive "${ROOT}" 2>/dev/null # make a copy
|
||||
|
||||
@@ -22,7 +22,8 @@ function simplify-gocase() {
|
||||
}
|
||||
|
||||
function token-coloncheck() {
|
||||
if grep -Ei "[\/]+[\/]+[ ]*+(FIXME[^:]|TODO[^:]|XXX[^:])" "$1"; then
|
||||
# add quotes to avoid matching three X's
|
||||
if grep -Ei "[\/]+[\/]+[ ]*+(FIXME[^:]|TODO[^:]|X"'X'"X[^:])" "$1"; then
|
||||
return 1 # tokens must end with a colon
|
||||
fi
|
||||
return 0
|
||||
|
||||
@@ -7,7 +7,7 @@ set -o pipefail
|
||||
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && cd .. && pwd )" # dir!
|
||||
cd "$DIR" >/dev/null # work from main mgmt directory
|
||||
make build
|
||||
T=`mktemp --tmpdir -d tmp.XXX`
|
||||
T=`mktemp --tmpdir -d tmp.X'X'X` # add quotes to avoid matching three X's
|
||||
cp -a ./mgmt "$T"/mgmt.1
|
||||
make clean
|
||||
make build
|
||||
|
||||
Reference in New Issue
Block a user