This ensures that docstring comments are wrapped to 80 chars. ffrank seemed to be making this mistake far too often, and it's a silly thing to look for manually. As it turns out, I've made it too, as have many others. Now we have a test that checks for most cases. There are still a few stray cases that aren't checked automatically, but this can be improved upon if someone is motivated to do so. Before anyone complains about the 80 character limit: this only checks docstring comments, not source code length or inline source code comments. There's no excuse for having docstrings that are badly reflowed or over 80 chars, particularly if you have an automated test.
283 lines
9.0 KiB
Go
283 lines
9.0 KiB
Go
// Mgmt
|
|
// Copyright (C) 2013-2020+ James Shubin and the project contributors
|
|
// Written by James Shubin <james@shubin.ca> and the project contributors
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package resources
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/purpleidea/mgmt/engine"
|
|
"github.com/purpleidea/mgmt/engine/traits"
|
|
engineUtil "github.com/purpleidea/mgmt/engine/util"
|
|
"github.com/purpleidea/mgmt/util"
|
|
"github.com/purpleidea/mgmt/util/errwrap"
|
|
|
|
"github.com/godbus/dbus"
|
|
)
|
|
|
|
func init() {
|
|
engine.RegisterResource("hostname", func() engine.Res { return &HostnameRes{} })
|
|
}
|
|
|
|
const (
|
|
hostname1Path = "/org/freedesktop/hostname1"
|
|
hostname1Iface = "org.freedesktop.hostname1"
|
|
dbusPropertiesIface = "org.freedesktop.DBus.Properties"
|
|
)
|
|
|
|
// ErrResourceInsufficientParameters is returned when the configuration of the
|
|
// resource is insufficient for the resource to do any useful work.
|
|
var ErrResourceInsufficientParameters = errors.New("insufficient parameters for this resource")
|
|
|
|
// HostnameRes is a resource that allows setting and watching the hostname.
|
|
//
|
|
// StaticHostname is the one configured in /etc/hostname or a similar file. It
|
|
// is chosen by the local user. It is not always in sync with the current host
|
|
// name as returned by the gethostname() system call.
|
|
//
|
|
// TransientHostname is the one configured via the kernel's sethostbyname(). It
|
|
// can be different from the static hostname in case DHCP or mDNS have been
|
|
// configured to change the name based on network information.
|
|
//
|
|
// PrettyHostname is a free-form UTF8 host name for presentation to the user.
|
|
//
|
|
// Hostname is the fallback value for all 3 fields above, if only Hostname is
|
|
// specified, it will set all 3 fields to this value.
|
|
type HostnameRes struct {
|
|
traits.Base // add the base methods without re-implementation
|
|
|
|
init *engine.Init
|
|
|
|
Hostname string `yaml:"hostname"`
|
|
PrettyHostname string `yaml:"pretty_hostname"`
|
|
StaticHostname string `yaml:"static_hostname"`
|
|
TransientHostname string `yaml:"transient_hostname"`
|
|
|
|
conn *dbus.Conn
|
|
}
|
|
|
|
// Default returns some sensible defaults for this resource.
|
|
func (obj *HostnameRes) Default() engine.Res {
|
|
return &HostnameRes{}
|
|
}
|
|
|
|
// Validate if the params passed in are valid data.
|
|
func (obj *HostnameRes) Validate() error {
|
|
if obj.PrettyHostname == "" && obj.StaticHostname == "" && obj.TransientHostname == "" {
|
|
return ErrResourceInsufficientParameters
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Init runs some startup code for this resource.
|
|
func (obj *HostnameRes) Init(init *engine.Init) error {
|
|
obj.init = init // save for later
|
|
|
|
if obj.PrettyHostname == "" {
|
|
obj.PrettyHostname = obj.Hostname
|
|
}
|
|
if obj.StaticHostname == "" {
|
|
obj.StaticHostname = obj.Hostname
|
|
}
|
|
if obj.TransientHostname == "" {
|
|
obj.TransientHostname = obj.Hostname
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Close is run by the engine to clean up after the resource is done.
|
|
func (obj *HostnameRes) Close() error {
|
|
return nil
|
|
}
|
|
|
|
// Watch is the primary listener for this resource and it outputs events.
|
|
func (obj *HostnameRes) Watch() error {
|
|
// if we share the bus with others, we will get each others messages!!
|
|
bus, err := util.SystemBusPrivateUsable() // don't share the bus connection!
|
|
if err != nil {
|
|
return errwrap.Wrapf(err, "failed to connect to bus")
|
|
}
|
|
defer bus.Close()
|
|
// watch the PropertiesChanged signal on the hostname1 dbus path
|
|
args := fmt.Sprintf(
|
|
"type='signal', path='%s', interface='%s', member='PropertiesChanged'",
|
|
hostname1Path,
|
|
dbusPropertiesIface,
|
|
)
|
|
if call := bus.BusObject().Call(engineUtil.DBusAddMatch, 0, args); call.Err != nil {
|
|
return errwrap.Wrapf(call.Err, "failed to subscribe to DBus events for hostname1")
|
|
}
|
|
defer bus.BusObject().Call(engineUtil.DBusRemoveMatch, 0, args) // ignore the error
|
|
|
|
signals := make(chan *dbus.Signal, 10) // closed by dbus package
|
|
bus.Signal(signals)
|
|
|
|
obj.init.Running() // when started, notify engine that we're running
|
|
|
|
var send = false // send event?
|
|
for {
|
|
select {
|
|
case <-signals:
|
|
send = true
|
|
|
|
case <-obj.init.Done: // closed by the engine to signal shutdown
|
|
return nil
|
|
}
|
|
|
|
// do all our event sending all together to avoid duplicate msgs
|
|
if send {
|
|
send = false
|
|
obj.init.Event() // notify engine of an event (this can block)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (obj *HostnameRes) updateHostnameProperty(object dbus.BusObject, expectedValue, property, setterName string, apply bool) (bool, error) {
|
|
propertyObject, err := object.GetProperty("org.freedesktop.hostname1." + property)
|
|
if err != nil {
|
|
return false, errwrap.Wrapf(err, "failed to get org.freedesktop.hostname1.%s", property)
|
|
}
|
|
if propertyObject.Value() == nil {
|
|
return false, fmt.Errorf("unexpected nil value received when reading property %s", property)
|
|
}
|
|
|
|
propertyValue, ok := propertyObject.Value().(string)
|
|
if !ok {
|
|
return false, fmt.Errorf("received unexpected type as %s value, expected string got '%T'", property, propertyValue)
|
|
}
|
|
|
|
// expected value and actual value match => checkOk
|
|
if propertyValue == expectedValue {
|
|
return true, nil
|
|
}
|
|
|
|
// nothing to do anymore
|
|
if !apply {
|
|
return false, nil
|
|
}
|
|
|
|
// attempting to apply the changes
|
|
obj.init.Logf("Changing %s: %s => %s", property, propertyValue, expectedValue)
|
|
if err := object.Call("org.freedesktop.hostname1."+setterName, 0, expectedValue, false).Err; err != nil {
|
|
return false, errwrap.Wrapf(err, "failed to call org.freedesktop.hostname1.%s", setterName)
|
|
}
|
|
|
|
// all good changes should now be applied again
|
|
return false, nil
|
|
}
|
|
|
|
// CheckApply method for Hostname resource.
|
|
func (obj *HostnameRes) CheckApply(apply bool) (bool, error) {
|
|
conn, err := util.SystemBusPrivateUsable()
|
|
if err != nil {
|
|
return false, errwrap.Wrapf(err, "failed to connect to the private system bus")
|
|
}
|
|
defer conn.Close()
|
|
|
|
hostnameObject := conn.Object(hostname1Iface, hostname1Path)
|
|
|
|
checkOK := true
|
|
if obj.PrettyHostname != "" {
|
|
propertyCheckOK, err := obj.updateHostnameProperty(hostnameObject, obj.PrettyHostname, "PrettyHostname", "SetPrettyHostname", apply)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
checkOK = checkOK && propertyCheckOK
|
|
}
|
|
if obj.StaticHostname != "" {
|
|
propertyCheckOK, err := obj.updateHostnameProperty(hostnameObject, obj.StaticHostname, "StaticHostname", "SetStaticHostname", apply)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
checkOK = checkOK && propertyCheckOK
|
|
}
|
|
if obj.TransientHostname != "" {
|
|
propertyCheckOK, err := obj.updateHostnameProperty(hostnameObject, obj.TransientHostname, "Hostname", "SetHostname", apply)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
checkOK = checkOK && propertyCheckOK
|
|
}
|
|
|
|
return checkOK, nil
|
|
}
|
|
|
|
// Cmp compares two resources and returns an error if they are not equivalent.
|
|
func (obj *HostnameRes) Cmp(r engine.Res) error {
|
|
// we can only compare HostnameRes to others of the same resource kind
|
|
res, ok := r.(*HostnameRes)
|
|
if !ok {
|
|
return fmt.Errorf("not a %s", obj.Kind())
|
|
}
|
|
|
|
if obj.PrettyHostname != res.PrettyHostname {
|
|
return fmt.Errorf("the PrettyHostname differs")
|
|
}
|
|
if obj.StaticHostname != res.StaticHostname {
|
|
return fmt.Errorf("the StaticHostname differs")
|
|
}
|
|
if obj.TransientHostname != res.TransientHostname {
|
|
return fmt.Errorf("the TransientHostname differs")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// HostnameUID is the UID struct for HostnameRes.
|
|
type HostnameUID struct {
|
|
engine.BaseUID
|
|
|
|
name string
|
|
prettyHostname string
|
|
staticHostname string
|
|
transientHostname string
|
|
}
|
|
|
|
// UIDs includes all params to make a unique identification of this object. Most
|
|
// resources only return one, although some resources can return multiple.
|
|
func (obj *HostnameRes) UIDs() []engine.ResUID {
|
|
x := &HostnameUID{
|
|
BaseUID: engine.BaseUID{Name: obj.Name(), Kind: obj.Kind()},
|
|
name: obj.Name(),
|
|
prettyHostname: obj.PrettyHostname,
|
|
staticHostname: obj.StaticHostname,
|
|
transientHostname: obj.TransientHostname,
|
|
}
|
|
return []engine.ResUID{x}
|
|
}
|
|
|
|
// UnmarshalYAML is the custom unmarshal handler for this struct. It is
|
|
// primarily useful for setting the defaults.
|
|
func (obj *HostnameRes) UnmarshalYAML(unmarshal func(interface{}) error) error {
|
|
type rawRes HostnameRes // indirection to avoid infinite recursion
|
|
|
|
def := obj.Default() // get the default
|
|
res, ok := def.(*HostnameRes) // put in the right format
|
|
if !ok {
|
|
return fmt.Errorf("could not convert to HostnameRes")
|
|
}
|
|
raw := rawRes(*res) // convert; the defaults go here
|
|
|
|
if err := unmarshal(&raw); err != nil {
|
|
return err
|
|
}
|
|
|
|
*obj = HostnameRes(raw) // restore from indirection with type conversion!
|
|
return nil
|
|
}
|