I previously broke the pkg auto edges because the package list wasn't available by the time it was called. This fixes the pkg resource so that it gets the necessary list of packages when needed. Since this means that a possible failure could happen, we also update the AutoEdges API to support errors. Errors can only be generated at AutoEdge struct creation, once the struct has been returned (right before modification of the graph structure) there is no possibility to return any errors. It's important to remember that the AutoEdges stuff gets called because the Init of each resource, so make sure it doesn't depend on anything that happens there or that gets cached as a result of Init. This is all much nicer now and has a test too :)
80 lines
1.9 KiB
Go
80 lines
1.9 KiB
Go
// Mgmt
|
|
// Copyright (C) 2013-2017+ James Shubin and the project contributors
|
|
// Written by James Shubin <james@shubin.ca> and the project contributors
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package resources
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/purpleidea/mgmt/pgraph"
|
|
)
|
|
|
|
func TestFileAutoEdge1(t *testing.T) {
|
|
|
|
g, err := pgraph.NewGraph("TestGraph")
|
|
if err != nil {
|
|
t.Errorf("error creating graph: %v", err)
|
|
return
|
|
}
|
|
|
|
r1 := &FileRes{
|
|
BaseRes: BaseRes{
|
|
Name: "file1",
|
|
Kind: "file",
|
|
MetaParams: MetaParams{
|
|
AutoEdge: true,
|
|
},
|
|
},
|
|
Path: "/tmp/a/b/", // some dir
|
|
}
|
|
r2 := &FileRes{
|
|
BaseRes: BaseRes{
|
|
Name: "file2",
|
|
Kind: "file",
|
|
MetaParams: MetaParams{
|
|
AutoEdge: true,
|
|
},
|
|
},
|
|
Path: "/tmp/a/", // some parent dir
|
|
}
|
|
r3 := &FileRes{
|
|
BaseRes: BaseRes{
|
|
Name: "file3",
|
|
Kind: "file",
|
|
MetaParams: MetaParams{
|
|
AutoEdge: true,
|
|
},
|
|
},
|
|
Path: "/tmp/a/b/c", // some child file
|
|
}
|
|
g.AddVertex(r1, r2, r3)
|
|
|
|
if i := g.NumEdges(); i != 0 {
|
|
t.Errorf("should have 0 edges instead of: %d", i)
|
|
}
|
|
|
|
// run artificially without the entire engine
|
|
if err := AutoEdges(g); err != nil {
|
|
t.Errorf("error running autoedges: %v", err)
|
|
}
|
|
|
|
// two edges should have been added
|
|
if i := g.NumEdges(); i != 2 {
|
|
t.Errorf("should have 2 edges instead of: %d", i)
|
|
}
|
|
}
|