Files
mgmt/lang/funcs/structs/call.go
James Shubin 790b7199ca lang: New function engine
This mega patch primarily introduces a new function engine. The main
reasons for this new engine are:

1) Massively improved performance with lock-contended graphs.

Certain large function graphs could have very high lock-contention which
turned out to be much slower than I would have liked. This new algorithm
happens to be basically lock-free, so that's another helpful
improvement.

2) Glitch-free function graphs.

The function graphs could "glitch" (an FRP term) which could be
undesirable in theory. In practice this was never really an issue, and
I've not explicitly guaranteed that the new graphs are provably
glitch-free, but in practice things are a lot more consistent.

3) Simpler graph shape.

The new graphs don't require the private channels. This makes
understanding the graphs a lot easier.

4) Branched graphs only run half.

Previously we would run two pure side of an if statement, and while this
was mostly meant as an early experiment, it stayed in for far too long
and now was the right time to remove this. This also means our graphs
are much smaller and more efficient too.

Note that this changed the function API slightly. Everything has been
ported. It's possible that we introduce a new API in the future, but it
is unexpected to cause removal of the two current APIs.

In addition, we finally split out the "schedule" aspect from
world.schedule(). The "pick me" aspects now happen in a separate
resource, rather than as a yucky side-effect in the function. This also
lets us more precisely choose when we're scheduled, and we can observe
without being chosen too.

As usual many thanks to Sam for helping through some of the algorithmic
graph shape issues!
2025-09-11 23:19:45 -04:00

212 lines
7.2 KiB
Go

// Mgmt
// Copyright (C) James Shubin and the project contributors
// Written by James Shubin <james@shubin.ca> and the project contributors
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
//
// Additional permission under GNU GPL version 3 section 7
//
// If you modify this program, or any covered work, by linking or combining it
// with embedded mcl code and modules (and that the embedded mcl code and
// modules which link with this program, contain a copy of their source code in
// the authoritative form) containing parts covered by the terms of any other
// license, the licensors of this program grant you additional permission to
// convey the resulting work. Furthermore, the licensors of this program grant
// the original author, James Shubin, additional permission to update this
// additional permission if he deems it necessary to achieve the goals of this
// additional permission.
package structs
import (
"context"
"fmt"
"github.com/purpleidea/mgmt/lang/interfaces"
"github.com/purpleidea/mgmt/lang/types"
"github.com/purpleidea/mgmt/lang/types/full"
"github.com/purpleidea/mgmt/util/errwrap"
)
const (
// CallFuncName is the unique name identifier for this function.
CallFuncName = "call"
// CallFuncArgNameFunction is the name for the edge which connects the
// input function to CallFunc.
CallFuncArgNameFunction = "fn"
)
// CallFunc receives a function from upstream, but not the arguments. Instead,
// the Funcs which emit those arguments must be specified at construction time.
// The arguments are connected to the received FuncValues in such a way that
// CallFunc emits the result of applying the function to the arguments.
type CallFunc struct {
interfaces.Textarea
Type *types.Type // the type of the result of applying the function
FuncType *types.Type // the type of the function
EdgeName string // name of the edge used
// These two fields are identical to what is used by a ShapelyFunc.
// TODO: Consider just using that interface here instead?
ArgVertices []interfaces.Func
OutputVertex interfaces.Func
init *interfaces.Init
lastFuncValue *full.FuncValue // remember the last function value
}
// String returns a simple name for this function. This is needed so this struct
// can satisfy the pgraph.Vertex interface.
func (obj *CallFunc) String() string {
return CallFuncName
}
// Validate makes sure we've built our struct properly.
func (obj *CallFunc) Validate() error {
if obj.Type == nil {
return fmt.Errorf("must specify a type")
}
if obj.FuncType == nil {
return fmt.Errorf("must specify a func type")
}
// TODO: maybe we can remove this if we use this for core functions...
if obj.EdgeName == "" {
return fmt.Errorf("must specify an edge name")
}
typ := obj.FuncType
// we only care about the output type of calling our func
if err := obj.Type.Cmp(typ.Out); err != nil {
return errwrap.Wrapf(err, "call expr type must match func out type")
}
if len(obj.ArgVertices) != len(typ.Ord) {
return fmt.Errorf("number of arg Funcs must match number of func args in the type")
}
if obj.OutputVertex == nil {
return fmt.Errorf("the output vertex is missing")
}
return nil
}
// Info returns some static info about itself.
func (obj *CallFunc) Info() *interfaces.Info {
var typ *types.Type
if obj.Type != nil && obj.FuncType != nil { // don't panic if called speculatively
typ = types.NewType(fmt.Sprintf("func(%s %s) %s", obj.EdgeName, obj.FuncType, obj.Type))
}
return &interfaces.Info{
Pure: false, // TODO: ???
Memo: false,
Fast: false,
Spec: false,
Sig: typ,
Err: obj.Validate(),
}
}
// Init runs some startup code for this composite function.
func (obj *CallFunc) Init(init *interfaces.Init) error {
obj.init = init
obj.lastFuncValue = nil
return nil
}
func (obj *CallFunc) replaceSubGraph(newFuncValue *full.FuncValue) error {
// Create a subgraph which looks as follows.
//
// digraph {
// ArgVertices[0] -> "fn" # spawned
// ArgVertices[1] -> "fn" # spawned
// ArgVertices[2] -> "fn" # spawned
//
// "fn" -> "callSubgraphOutput" # spawned
//
// "FuncValue" -> "CallFunc" # fn
// "CallFunc" -> "callSubgraphOutput" # dummy
// "callSubgraphOutput" -> downstream
// }
// delete the old subgraph
if err := obj.init.Txn.Reverse(); err != nil {
return errwrap.Wrapf(err, "could not Reverse")
}
// This passed in Txn has AddVertex, AddEdge, and possibly AddGraph
// methods called on it. Nothing else. It will _not_ call Commit or
// Reverse. It adds to the graph, and our Commit and Reverse operations
// are the ones that actually make the change.
outputFunc, err := newFuncValue.CallWithFuncs(obj.init.Txn, obj.ArgVertices, obj.OutputVertex)
if err != nil {
return errwrap.Wrapf(err, "could not call newFuncValue.Call()")
}
// create the new subgraph
edge := &interfaces.FuncEdge{Args: []string{OutputFuncArgName}} // "out"
obj.init.Txn.AddVertex(outputFunc)
// XXX: We don't want to do this for ShapelyFunc's. This is a hack b/c I
// wasn't sure how to make this more consistent elsewhere. Look at the
// "hack" edge in iter.map and iter.filter as those need this hack.
// XXX: maybe this interface could return the funcSubgraphOutput node?
if _, ok := outputFunc.(interfaces.ShapelyFunc); !ok {
obj.init.Txn.AddEdge(outputFunc, obj.OutputVertex, edge)
}
return obj.init.Txn.Commit()
}
// Call this function with the input args and return the value if it is possible
// to do so at this time.
func (obj *CallFunc) Call(ctx context.Context, args []types.Value) (types.Value, error) {
if len(args) < 1 {
return nil, fmt.Errorf("not enough args")
}
value := args[0]
newFuncValue, ok := value.(*full.FuncValue)
if !ok {
return nil, fmt.Errorf("programming error, can't convert to *FuncValue")
}
if newFuncValue != obj.lastFuncValue {
// If we have a new function, then we need to replace the
// subgraph with a new one that uses the new function.
obj.lastFuncValue = newFuncValue
// This does *not* deadlock, because running a Txn, can't cause
// a second Txn to run automatically. What can happen following
// this replacement and subsequent Txn execution, is that we'll
// run the interrupt which then lets the new Call functions run
// and they then can call more Txn exections and so on...
if err := obj.replaceSubGraph(newFuncValue); err != nil {
return nil, errwrap.Wrapf(err, "could not replace subgraph")
}
return nil, interfaces.ErrInterrupt
}
// send dummy value to the output
return types.NewNil(), nil // dummy value
}
// Cleanup runs after that function was removed from the graph.
func (obj *CallFunc) Cleanup(ctx context.Context) error {
return obj.init.Txn.Reverse()
}