The old converged detection was hacked in code, instead of something with a nice interface. This cleans it up, splits it into a separate file, and removes a race condition that happened with the old code. We also take the time to get rid of the ugly Set* methods and replace them all with a single AssociateData method. This might be unnecessary if we can pass in the Converger method at Resource construction. Lastly, and most interesting, we suspend the individual timeout callers when they've already converged, thus reducing unnecessary traffic, and avoiding fast (eg: < 5 second) timers triggering more than once if they stay converged! A quick note on theory for any future readers... What happens if we have --converged-timeout=0 ? Well, for this and any other positive value, it's important to realize that deciding if something is converged is actually a race between if the converged timer will fire and if some random new event will get triggered. This is because there is nothing that can actually predict if or when a new event will happen (eg the user modifying a file). As a result, a race is always inherent, and actually not a negative or "incorrect" algorithm. A future improvement could be to add a global lock to each resource, and to lock all resources when computing if we are converged or not. In practice, this hasn't been necessary. The worst case scenario would be (in theory, because this hasn't been tested) if an event happens *during* the converged calculation, and starts running, the exit command then runs, and the event finishes, but it doesn't get a chance to notify some service to restart. A lock could probably fix this theoretical case.
441 lines
12 KiB
Go
441 lines
12 KiB
Go
// Mgmt
|
|
// Copyright (C) 2013-2016+ James Shubin and the project contributors
|
|
// Written by James Shubin <james@shubin.ca> and the project contributors
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
// DOCS: https://godoc.org/github.com/coreos/go-systemd/dbus
|
|
|
|
package main
|
|
|
|
import (
|
|
"encoding/gob"
|
|
"errors"
|
|
"fmt"
|
|
systemd "github.com/coreos/go-systemd/dbus" // change namespace
|
|
systemdUtil "github.com/coreos/go-systemd/util"
|
|
"github.com/godbus/dbus" // namespace collides with systemd wrapper
|
|
"log"
|
|
)
|
|
|
|
func init() {
|
|
gob.Register(&SvcRes{})
|
|
}
|
|
|
|
type SvcRes struct {
|
|
BaseRes `yaml:",inline"`
|
|
State string `yaml:"state"` // state: running, stopped, undefined
|
|
Startup string `yaml:"startup"` // enabled, disabled, undefined
|
|
}
|
|
|
|
func NewSvcRes(name, state, startup string) *SvcRes {
|
|
obj := &SvcRes{
|
|
BaseRes: BaseRes{
|
|
Name: name,
|
|
},
|
|
State: state,
|
|
Startup: startup,
|
|
}
|
|
obj.Init()
|
|
return obj
|
|
}
|
|
|
|
func (obj *SvcRes) Init() {
|
|
obj.BaseRes.kind = "Svc"
|
|
obj.BaseRes.Init() // call base init, b/c we're overriding
|
|
}
|
|
|
|
func (obj *SvcRes) Validate() bool {
|
|
if obj.State != "running" && obj.State != "stopped" && obj.State != "" {
|
|
return false
|
|
}
|
|
if obj.Startup != "enabled" && obj.Startup != "disabled" && obj.Startup != "" {
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
// Service watcher
|
|
func (obj *SvcRes) Watch(processChan chan Event) {
|
|
if obj.IsWatching() {
|
|
return
|
|
}
|
|
obj.SetWatching(true)
|
|
defer obj.SetWatching(false)
|
|
cuuid := obj.converger.Register()
|
|
defer cuuid.Unregister()
|
|
|
|
// obj.Name: svc name
|
|
if !systemdUtil.IsRunningSystemd() {
|
|
log.Fatal("Systemd is not running.")
|
|
}
|
|
|
|
conn, err := systemd.NewSystemdConnection() // needs root access
|
|
if err != nil {
|
|
log.Fatal("Failed to connect to systemd: ", err)
|
|
}
|
|
defer conn.Close()
|
|
|
|
// if we share the bus with others, we will get each others messages!!
|
|
bus, err := SystemBusPrivateUsable() // don't share the bus connection!
|
|
if err != nil {
|
|
log.Fatal("Failed to connect to bus: ", err)
|
|
}
|
|
|
|
// XXX: will this detect new units?
|
|
bus.BusObject().Call("org.freedesktop.DBus.AddMatch", 0,
|
|
"type='signal',interface='org.freedesktop.systemd1.Manager',member='Reloading'")
|
|
buschan := make(chan *dbus.Signal, 10)
|
|
bus.Signal(buschan)
|
|
|
|
var svc = fmt.Sprintf("%v.service", obj.Name) // systemd name
|
|
var send = false // send event?
|
|
var exit = false
|
|
var dirty = false
|
|
var invalid = false // does the svc exist or not?
|
|
var previous bool // previous invalid value
|
|
set := conn.NewSubscriptionSet() // no error should be returned
|
|
subChannel, subErrors := set.Subscribe()
|
|
var activeSet = false
|
|
|
|
for {
|
|
// XXX: watch for an event for new units...
|
|
// XXX: detect if startup enabled/disabled value changes...
|
|
|
|
previous = invalid
|
|
invalid = false
|
|
|
|
// firstly, does svc even exist or not?
|
|
loadstate, err := conn.GetUnitProperty(svc, "LoadState")
|
|
if err != nil {
|
|
log.Printf("Failed to get property: %v", err)
|
|
invalid = true
|
|
}
|
|
|
|
if !invalid {
|
|
var notFound = (loadstate.Value == dbus.MakeVariant("not-found"))
|
|
if notFound { // XXX: in the loop we'll handle changes better...
|
|
log.Printf("Failed to find svc: %v", svc)
|
|
invalid = true // XXX ?
|
|
}
|
|
}
|
|
|
|
if previous != invalid { // if invalid changed, send signal
|
|
send = true
|
|
dirty = true
|
|
}
|
|
|
|
if invalid {
|
|
log.Printf("Waiting for: %v", svc) // waiting for svc to appear...
|
|
if activeSet {
|
|
activeSet = false
|
|
set.Remove(svc) // no return value should ever occur
|
|
}
|
|
|
|
obj.SetState(resStateWatching) // reset
|
|
select {
|
|
case _ = <-buschan: // XXX wait for new units event to unstick
|
|
cuuid.SetConverged(false)
|
|
// loop so that we can see the changed invalid signal
|
|
log.Printf("Svc[%v]->DaemonReload()", svc)
|
|
|
|
case event := <-obj.events:
|
|
cuuid.SetConverged(false)
|
|
if exit, send = obj.ReadEvent(&event); exit {
|
|
return // exit
|
|
}
|
|
if event.GetActivity() {
|
|
dirty = true
|
|
}
|
|
|
|
case _ = <-cuuid.ConvergedTimer():
|
|
cuuid.SetConverged(true) // converged!
|
|
continue
|
|
}
|
|
} else {
|
|
if !activeSet {
|
|
activeSet = true
|
|
set.Add(svc) // no return value should ever occur
|
|
}
|
|
|
|
log.Printf("Watching: %v", svc) // attempting to watch...
|
|
obj.SetState(resStateWatching) // reset
|
|
select {
|
|
case event := <-subChannel:
|
|
|
|
log.Printf("Svc event: %+v", event)
|
|
// NOTE: the value returned is a map for some reason...
|
|
if event[svc] != nil {
|
|
// event[svc].ActiveState is not nil
|
|
if event[svc].ActiveState == "active" {
|
|
log.Printf("Svc[%v]->Started()", svc)
|
|
} else if event[svc].ActiveState == "inactive" {
|
|
log.Printf("Svc[%v]->Stopped!()", svc)
|
|
} else {
|
|
log.Fatal("Unknown svc state: ", event[svc].ActiveState)
|
|
}
|
|
} else {
|
|
// svc stopped (and ActiveState is nil...)
|
|
log.Printf("Svc[%v]->Stopped", svc)
|
|
}
|
|
send = true
|
|
dirty = true
|
|
|
|
case err := <-subErrors:
|
|
cuuid.SetConverged(false) // XXX ?
|
|
log.Printf("error: %v", err)
|
|
log.Fatal(err)
|
|
//vertex.events <- fmt.Sprintf("svc: %v", "error") // XXX: how should we handle errors?
|
|
|
|
case event := <-obj.events:
|
|
cuuid.SetConverged(false)
|
|
if exit, send = obj.ReadEvent(&event); exit {
|
|
return // exit
|
|
}
|
|
if event.GetActivity() {
|
|
dirty = true
|
|
}
|
|
|
|
case _ = <-cuuid.ConvergedTimer():
|
|
cuuid.SetConverged(true) // converged!
|
|
continue
|
|
}
|
|
}
|
|
|
|
if send {
|
|
send = false
|
|
if dirty {
|
|
dirty = false
|
|
obj.isStateOK = false // something made state dirty
|
|
}
|
|
resp := NewResp()
|
|
processChan <- Event{eventNil, resp, "", true} // trigger process
|
|
resp.ACKWait() // wait for the ACK()
|
|
}
|
|
|
|
}
|
|
}
|
|
|
|
func (obj *SvcRes) CheckApply(apply bool) (stateok bool, err error) {
|
|
log.Printf("%v[%v]: CheckApply(%t)", obj.Kind(), obj.GetName(), apply)
|
|
|
|
if obj.isStateOK { // cache the state
|
|
return true, nil
|
|
}
|
|
|
|
if !systemdUtil.IsRunningSystemd() {
|
|
return false, errors.New("Systemd is not running.")
|
|
}
|
|
|
|
conn, err := systemd.NewSystemdConnection() // needs root access
|
|
if err != nil {
|
|
return false, fmt.Errorf("Failed to connect to systemd: %v", err)
|
|
}
|
|
defer conn.Close()
|
|
|
|
var svc = fmt.Sprintf("%v.service", obj.Name) // systemd name
|
|
|
|
loadstate, err := conn.GetUnitProperty(svc, "LoadState")
|
|
if err != nil {
|
|
return false, fmt.Errorf("Failed to get load state: %v", err)
|
|
}
|
|
|
|
// NOTE: we have to compare variants with other variants, they are really strings...
|
|
var notFound = (loadstate.Value == dbus.MakeVariant("not-found"))
|
|
if notFound {
|
|
return false, fmt.Errorf("Failed to find svc: %v", svc)
|
|
}
|
|
|
|
// XXX: check svc "enabled at boot" or not status...
|
|
|
|
//conn.GetUnitProperties(svc)
|
|
activestate, err := conn.GetUnitProperty(svc, "ActiveState")
|
|
if err != nil {
|
|
return false, fmt.Errorf("Failed to get active state: %v", err)
|
|
}
|
|
|
|
var running = (activestate.Value == dbus.MakeVariant("active"))
|
|
var stateOK = ((obj.State == "") || (obj.State == "running" && running) || (obj.State == "stopped" && !running))
|
|
var startupOK = true // XXX DETECT AND SET
|
|
|
|
if stateOK && startupOK {
|
|
return true, nil // we are in the correct state
|
|
}
|
|
|
|
// state is not okay, no work done, exit, but without error
|
|
if !apply {
|
|
return false, nil
|
|
}
|
|
|
|
// apply portion
|
|
log.Printf("%v[%v]: Apply", obj.Kind(), obj.GetName())
|
|
var files = []string{svc} // the svc represented in a list
|
|
if obj.Startup == "enabled" {
|
|
_, _, err = conn.EnableUnitFiles(files, false, true)
|
|
|
|
} else if obj.Startup == "disabled" {
|
|
_, err = conn.DisableUnitFiles(files, false)
|
|
}
|
|
|
|
if err != nil {
|
|
return false, fmt.Errorf("Unable to change startup status: %v", err)
|
|
}
|
|
|
|
// XXX: do we need to use a buffered channel here?
|
|
result := make(chan string, 1) // catch result information
|
|
|
|
if obj.State == "running" {
|
|
_, err = conn.StartUnit(svc, "fail", result)
|
|
if err != nil {
|
|
return false, fmt.Errorf("Failed to start unit: %v", err)
|
|
}
|
|
} else if obj.State == "stopped" {
|
|
_, err = conn.StopUnit(svc, "fail", result)
|
|
if err != nil {
|
|
return false, fmt.Errorf("Failed to stop unit: %v", err)
|
|
}
|
|
}
|
|
|
|
status := <-result
|
|
if &status == nil {
|
|
return false, errors.New("Systemd service action result is nil")
|
|
}
|
|
if status != "done" {
|
|
return false, fmt.Errorf("Unknown systemd return string: %v", status)
|
|
}
|
|
|
|
// XXX: also set enabled on boot
|
|
|
|
return false, nil // success
|
|
}
|
|
|
|
type SvcUUID struct {
|
|
// NOTE: there is also a name variable in the BaseUUID struct, this is
|
|
// information about where this UUID came from, and is unrelated to the
|
|
// information about the resource we're matching. That data which is
|
|
// used in the IFF function, is what you see in the struct fields here.
|
|
BaseUUID
|
|
name string // the svc name
|
|
}
|
|
|
|
// if and only if they are equivalent, return true
|
|
// if they are not equivalent, return false
|
|
func (obj *SvcUUID) IFF(uuid ResUUID) bool {
|
|
res, ok := uuid.(*SvcUUID)
|
|
if !ok {
|
|
return false
|
|
}
|
|
return obj.name == res.name
|
|
}
|
|
|
|
type SvcResAutoEdges struct {
|
|
data []ResUUID
|
|
pointer int
|
|
found bool
|
|
}
|
|
|
|
func (obj *SvcResAutoEdges) Next() []ResUUID {
|
|
if obj.found {
|
|
log.Fatal("Shouldn't be called anymore!")
|
|
}
|
|
if len(obj.data) == 0 { // check length for rare scenarios
|
|
return nil
|
|
}
|
|
value := obj.data[obj.pointer]
|
|
obj.pointer++
|
|
return []ResUUID{value} // we return one, even though api supports N
|
|
}
|
|
|
|
// get results of the earlier Next() call, return if we should continue!
|
|
func (obj *SvcResAutoEdges) Test(input []bool) bool {
|
|
// if there aren't any more remaining
|
|
if len(obj.data) <= obj.pointer {
|
|
return false
|
|
}
|
|
if obj.found { // already found, done!
|
|
return false
|
|
}
|
|
if len(input) != 1 { // in case we get given bad data
|
|
log.Fatal("Expecting a single value!")
|
|
}
|
|
if input[0] { // if a match is found, we're done!
|
|
obj.found = true // no more to find!
|
|
return false
|
|
}
|
|
return true // keep going
|
|
}
|
|
|
|
func (obj *SvcRes) AutoEdges() AutoEdge {
|
|
var data []ResUUID
|
|
svcFiles := []string{
|
|
fmt.Sprintf("/etc/systemd/system/%s.service", obj.Name), // takes precedence
|
|
fmt.Sprintf("/usr/lib/systemd/system/%s.service", obj.Name), // pkg default
|
|
}
|
|
for _, x := range svcFiles {
|
|
var reversed = true
|
|
data = append(data, &FileUUID{
|
|
BaseUUID: BaseUUID{
|
|
name: obj.GetName(),
|
|
kind: obj.Kind(),
|
|
reversed: &reversed,
|
|
},
|
|
path: x, // what matters
|
|
})
|
|
}
|
|
return &FileResAutoEdges{
|
|
data: data,
|
|
pointer: 0,
|
|
found: false,
|
|
}
|
|
}
|
|
|
|
// include all params to make a unique identification of this object
|
|
func (obj *SvcRes) GetUUIDs() []ResUUID {
|
|
x := &SvcUUID{
|
|
BaseUUID: BaseUUID{name: obj.GetName(), kind: obj.Kind()},
|
|
name: obj.Name, // svc name
|
|
}
|
|
return []ResUUID{x}
|
|
}
|
|
|
|
func (obj *SvcRes) GroupCmp(r Res) bool {
|
|
_, ok := r.(*SvcRes)
|
|
if !ok {
|
|
return false
|
|
}
|
|
// TODO: depending on if the systemd service api allows batching, we
|
|
// might be able to build this, although not sure how useful it is...
|
|
// it might just eliminate parallelism be bunching up the graph
|
|
return false // not possible atm
|
|
}
|
|
|
|
func (obj *SvcRes) Compare(res Res) bool {
|
|
switch res.(type) {
|
|
case *SvcRes:
|
|
res := res.(*SvcRes)
|
|
if obj.Name != res.Name {
|
|
return false
|
|
}
|
|
if obj.State != res.State {
|
|
return false
|
|
}
|
|
if obj.Startup != res.Startup {
|
|
return false
|
|
}
|
|
default:
|
|
return false
|
|
}
|
|
return true
|
|
}
|