This cleans up some of the resource events and also reorganizes the struct for simplicity. This should hopefully kill off at least one race which would cause unnecessary blocking! Yes this patch is a bit yucky, but so was the bug I was fighting with!
230 lines
7.7 KiB
Go
230 lines
7.7 KiB
Go
// Mgmt
|
|
// Copyright (C) 2013-2017+ James Shubin and the project contributors
|
|
// Written by James Shubin <james@shubin.ca> and the project contributors
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package resources
|
|
|
|
import (
|
|
"fmt"
|
|
"log"
|
|
"reflect"
|
|
|
|
"github.com/purpleidea/mgmt/event"
|
|
|
|
multierr "github.com/hashicorp/go-multierror"
|
|
errwrap "github.com/pkg/errors"
|
|
)
|
|
|
|
// Event sends off an event, but doesn't block the incoming event queue.
|
|
func (obj *BaseRes) Event() error {
|
|
resp := event.NewResp()
|
|
obj.processLock.Lock()
|
|
if obj.processDone {
|
|
obj.processLock.Unlock()
|
|
return fmt.Errorf("processChan is already closed")
|
|
}
|
|
obj.processChan <- &event.Event{Name: event.EventNil, Resp: resp} // trigger process
|
|
obj.processLock.Unlock()
|
|
return resp.Wait()
|
|
}
|
|
|
|
// SendEvent pushes an event into the message queue for a particular vertex.
|
|
func (obj *BaseRes) SendEvent(ev event.EventName, err error) error {
|
|
if obj.debug {
|
|
if err == nil {
|
|
log.Printf("%s[%s]: SendEvent(%+v)", obj.Kind(), obj.GetName(), ev)
|
|
} else {
|
|
log.Printf("%s[%s]: SendEvent(%+v): %v", obj.Kind(), obj.GetName(), ev, err)
|
|
}
|
|
}
|
|
resp := event.NewResp()
|
|
obj.eventsLock.Lock()
|
|
if obj.eventsDone {
|
|
obj.eventsLock.Unlock()
|
|
return fmt.Errorf("eventsChan is already closed")
|
|
}
|
|
obj.eventsChan <- &event.Event{Name: ev, Resp: resp, Err: err}
|
|
if ev == event.EventExit {
|
|
obj.eventsDone = true
|
|
close(obj.eventsChan) // this is where we properly close this channel!
|
|
}
|
|
obj.eventsLock.Unlock()
|
|
resp.ACKWait() // waits until true (nil) value
|
|
return nil
|
|
}
|
|
|
|
// ReadEvent processes events when a select gets one, and handles the pause
|
|
// code too! The return values specify if we should exit and poke respectively.
|
|
func (obj *BaseRes) ReadEvent(ev *event.Event) (exit *error, send bool) {
|
|
ev.ACK()
|
|
err := ev.Error()
|
|
|
|
switch ev.Name {
|
|
case event.EventStart:
|
|
return nil, true
|
|
|
|
case event.EventPoke:
|
|
return nil, true
|
|
|
|
case event.EventBackPoke:
|
|
return nil, true // forward poking in response to a back poke!
|
|
|
|
case event.EventExit:
|
|
// FIXME: what do we do if we have a pending refresh (poke) and an exit?
|
|
return &err, false
|
|
|
|
case event.EventPause:
|
|
// wait for next event to continue
|
|
select {
|
|
case e, ok := <-obj.Events():
|
|
if !ok { // shutdown
|
|
err := error(nil)
|
|
return &err, false
|
|
}
|
|
e.ACK()
|
|
err := e.Error()
|
|
if e.Name == event.EventExit {
|
|
return &err, false
|
|
} else if e.Name == event.EventStart { // eventContinue
|
|
return nil, false // don't poke on unpause!
|
|
}
|
|
// if we get a poke event here, it's a bug!
|
|
err = fmt.Errorf("%s[%s]: Unknown event: %v, while paused!", obj.Kind(), obj.GetName(), e)
|
|
panic(err) // TODO: return a special sentinel instead?
|
|
//return &err, false
|
|
}
|
|
}
|
|
err = fmt.Errorf("Unknown event: %v", ev)
|
|
panic(err) // TODO: return a special sentinel instead?
|
|
//return &err, false
|
|
}
|
|
|
|
// Running is called by the Watch method of the resource once it has started up.
|
|
// This signals to the engine to kick off the initial CheckApply resource check.
|
|
func (obj *BaseRes) Running() error {
|
|
// TODO: If a non-polling resource wants to use the converger, then it
|
|
// should probably tell Running (via an arg) to not do this. Currently
|
|
// it is a very unlikey race that could cause an early converge if the
|
|
// converge timeout is very short ( ~ 1s) and the Watch method doesn't
|
|
// immediately SetConverged(false) to stop possible early termination.
|
|
if obj.Meta().Poll == 0 { // if not polling, unblock this...
|
|
cuid, _, _ := obj.ConvergerUIDs()
|
|
cuid.SetConverged(true) // a reasonable initial assumption
|
|
}
|
|
|
|
obj.StateOK(false) // assume we're initially dirty
|
|
if !obj.isStarted { // this avoids a double close when/if watch retries
|
|
obj.isStarted = true
|
|
close(obj.started) // send started signal
|
|
}
|
|
|
|
var err error
|
|
if obj.starter { // vertices of indegree == 0 should send initial pokes
|
|
err = obj.Event() // trigger a CheckApply
|
|
}
|
|
return err // bubble up any possible error (or nil)
|
|
}
|
|
|
|
// Send points to a value that a resource will send.
|
|
type Send struct {
|
|
Res Res // a handle to the resource which is sending a value
|
|
Key string // the key in the resource that we're sending
|
|
|
|
Changed bool // set to true if this key was updated, read only!
|
|
}
|
|
|
|
// SendRecv pulls in the sent values into the receive slots. It is called by the
|
|
// receiver and must be given as input the full resource struct to receive on.
|
|
func (obj *BaseRes) SendRecv(res Res) (map[string]bool, error) {
|
|
if obj.debug {
|
|
// NOTE: this could expose private resource data like passwords
|
|
log.Printf("%s[%s]: SendRecv: %+v", obj.Kind(), obj.GetName(), obj.Recv)
|
|
}
|
|
var updated = make(map[string]bool) // list of updated keys
|
|
var err error
|
|
for k, v := range obj.Recv {
|
|
updated[k] = false // default
|
|
v.Changed = false // reset to the default
|
|
// send
|
|
obj1 := reflect.Indirect(reflect.ValueOf(v.Res))
|
|
type1 := obj1.Type()
|
|
value1 := obj1.FieldByName(v.Key)
|
|
kind1 := value1.Kind()
|
|
|
|
// recv
|
|
obj2 := reflect.Indirect(reflect.ValueOf(res)) // pass in full struct
|
|
type2 := obj2.Type()
|
|
value2 := obj2.FieldByName(k)
|
|
kind2 := value2.Kind()
|
|
|
|
if obj.debug {
|
|
log.Printf("Send(%s) has %v: %v", type1, kind1, value1)
|
|
log.Printf("Recv(%s) has %v: %v", type2, kind2, value2)
|
|
}
|
|
|
|
// i think we probably want the same kind, at least for now...
|
|
if kind1 != kind2 {
|
|
e := fmt.Errorf("Kind mismatch between %s[%s]: %s and %s[%s]: %s", v.Res.Kind(), v.Res.GetName(), kind1, obj.Kind(), obj.GetName(), kind2)
|
|
err = multierr.Append(err, e) // list of errors
|
|
continue
|
|
}
|
|
|
|
// if the types don't match, we can't use send->recv
|
|
// TODO: do we want to relax this for string -> *string ?
|
|
if e := TypeCmp(value1, value2); e != nil {
|
|
e := errwrap.Wrapf(e, "Type mismatch between %s[%s] and %s[%s]", v.Res.Kind(), v.Res.GetName(), obj.Kind(), obj.GetName())
|
|
err = multierr.Append(err, e) // list of errors
|
|
continue
|
|
}
|
|
|
|
// if we can't set, then well this is pointless!
|
|
if !value2.CanSet() {
|
|
e := fmt.Errorf("Can't set %s[%s].%s", obj.Kind(), obj.GetName(), k)
|
|
err = multierr.Append(err, e) // list of errors
|
|
continue
|
|
}
|
|
|
|
// if we can't interface, we can't compare...
|
|
if !value1.CanInterface() || !value2.CanInterface() {
|
|
e := fmt.Errorf("Can't interface %s[%s].%s", obj.Kind(), obj.GetName(), k)
|
|
err = multierr.Append(err, e) // list of errors
|
|
continue
|
|
}
|
|
|
|
// if the values aren't equal, we're changing the receiver
|
|
if !reflect.DeepEqual(value1.Interface(), value2.Interface()) {
|
|
// TODO: can we catch the panics here in case they happen?
|
|
value2.Set(value1) // do it for all types that match
|
|
updated[k] = true // we updated this key!
|
|
v.Changed = true // tag this key as updated!
|
|
log.Printf("SendRecv: %s[%s].%s -> %s[%s].%s", v.Res.Kind(), v.Res.GetName(), v.Key, obj.Kind(), obj.GetName(), k)
|
|
}
|
|
}
|
|
return updated, err
|
|
}
|
|
|
|
// TypeCmp compares two reflect values to see if they are the same Kind. It can
|
|
// look into a ptr Kind to see if the underlying pair of ptr's can TypeCmp too!
|
|
func TypeCmp(a, b reflect.Value) error {
|
|
ta, tb := a.Type(), b.Type()
|
|
if ta != tb {
|
|
return fmt.Errorf("Type mismatch: %s != %s", ta, tb)
|
|
}
|
|
// NOTE: it seems we don't need to recurse into pointers to sub check!
|
|
|
|
return nil // identical Type()'s
|
|
}
|