Files
mgmt/lang/interfaces/metadata_test.go
James Shubin 96dccca475 lang: Add module imports and more
This enables imports in mcl code, and is one of last remaining blockers
to using mgmt. Now we can start writing standalone modules, and adding
standard library functions as needed. There's still lots to do, but this
was a big missing piece. It was much harder to get right than I had
expected, but I think it's solid!

This unfortunately large commit is the result of some wild hacking I've
been doing for the past little while. It's the result of a rebase that
broke many "wip" commits that tracked my private progress, into
something that's not gratuitously messy for our git logs. Since this was
a learning and discovery process for me, I've "erased" the confusing git
history that wouldn't have helped. I'm happy to discuss the dead-ends,
and a small portion of that code was even left in for possible future
use.

This patch includes:

* A change to the cli interface:
You now specify the front-end explicitly, instead of leaving it up to
the front-end to decide when to "activate". For example, instead of:

mgmt run --lang code.mcl

we now do:

mgmt run lang --lang code.mcl

We might rename the --lang flag in the future to avoid the awkward word
repetition. Suggestions welcome, but I'm considering "input". One
side-effect of this change, is that flags which are "engine" specific
now must be specified with "run" before the front-end name. Eg:

mgmt run --tmp-prefix lang --lang code.mcl

instead of putting --tmp-prefix at the end. We also changed the GAPI
slightly, but I've patched all code that used it. This also makes things
consistent with the "deploy" command.

* The deploys are more robust and let you deploy after a run
This has been vastly improved and let's mgmt really run as a smart
engine that can handle different workloads. If you don't want to deploy
when you've started with `run` or if one comes in, you can use the
--no-watch-deploy option to block new deploys.

* The import statement exists and works!
We now have a working `import` statement. Read the docs, and try it out.
I think it's quite elegant how it fits in with `SetScope`. Have a look.
As a result, we now have some built-in functions available in modules.
This also adds the metadata.yaml entry-point for all modules. Have a
look at the examples or the tests. The bulk of the patch is to support
this.

* Improved lang input parsing code:
I re-wrote the parsing that determined what ran when we passed different
things to --lang. Deciding between running an mcl file or raw code is
now handled in a more intelligent, and re-usable way. See the inputs.go
file if you want to have a look. One casualty is that you can't stream
code from stdin *directly* to the front-end, it's encapsulated into a
deploy first. You can still use stdin though! I doubt anyone will notice
this change.

* The scope was extended to include functions and classes:
Go forth and import lovely code. All these exist in scopes now, and can
be re-used!

* Function calls actually use the scope now. Glad I got this sorted out.

* There is import cycle detection for modules!
Yes, this is another dag. I think that's #4. I guess they're useful.

* A ton of tests and new test infra was added!
This should make it much easier to add new tests that run mcl code. Have
a look at TestAstFunc1 to see how to add more of these.

As usual, I'll try to keep these commits smaller in the future!
2018-12-21 06:22:12 -05:00

197 lines
4.9 KiB
Go

// Mgmt
// Copyright (C) 2013-2018+ James Shubin and the project contributors
// Written by James Shubin <james@shubin.ca> and the project contributors
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
// +build !root
package interfaces
import (
"fmt"
"reflect"
"strings"
"testing"
"github.com/purpleidea/mgmt/util"
"github.com/davecgh/go-spew/spew"
"github.com/kylelemons/godebug/pretty"
)
func TestMetadataParse0(t *testing.T) {
type test struct { // an individual test
name string
yaml string
fail bool
meta *Metadata
}
testCases := []test{}
//{
// testCases = append(testCases, test{
// "",
// ``,
// false,
// nil,
// })
//}
{
testCases = append(testCases, test{
name: "empty",
yaml: ``,
fail: false,
meta: DefaultMetadata(),
})
}
{
testCases = append(testCases, test{
name: "empty file defaults",
yaml: util.Code(`
# empty file
`),
fail: false,
meta: DefaultMetadata(),
})
}
{
testCases = append(testCases, test{
name: "empty document defaults",
yaml: util.Code(`
--- # new document
`),
fail: false,
meta: DefaultMetadata(),
})
}
{
testCases = append(testCases, test{
name: "set values",
yaml: util.Code(`
main: "hello.mcl"
files: "xfiles/"
path: "vendor/"
`),
fail: false,
meta: &Metadata{
Main: "hello.mcl",
Files: "xfiles/",
Path: "vendor/",
},
})
}
{
meta := DefaultMetadata()
meta.Main = "start.mcl"
testCases = append(testCases, test{
name: "partial document defaults",
yaml: util.Code(`
main: "start.mcl"
`),
fail: false,
meta: meta,
})
}
names := []string{}
for index, tc := range testCases { // run all the tests
if tc.name == "" {
t.Errorf("test #%d: not named", index)
continue
}
if util.StrInList(tc.name, names) {
t.Errorf("test #%d: duplicate sub test name of: %s", index, tc.name)
continue
}
names = append(names, tc.name)
//if index != 3 { // hack to run a subset (useful for debugging)
//if (index != 20 && index != 21) {
//if tc.name != "nil" {
// continue
//}
t.Run(fmt.Sprintf("test #%d (%s)", index, tc.name), func(t *testing.T) {
name, yaml, fail, meta := tc.name, tc.yaml, tc.fail, tc.meta
t.Logf("\n\ntest #%d (%s) ----------------\n\n", index, name)
str := strings.NewReader(yaml)
metadata, err := ParseMetadata(str)
meta.bug395 = true // workaround for https://github.com/go-yaml/yaml/issues/395
if !fail && err != nil {
t.Errorf("test #%d: metadata parse failed with: %+v", index, err)
return
}
if fail && err == nil {
t.Errorf("test #%d: metadata parse passed, expected fail", index)
return
}
if !fail && metadata == nil {
t.Errorf("test #%d: metadata parse output was nil", index)
return
}
if metadata != nil {
if !reflect.DeepEqual(meta, metadata) {
// double check because DeepEqual is different since the func exists
diff := pretty.Compare(meta, metadata)
if diff != "" { // bonus
t.Errorf("test #%d: metadata did not match expected", index)
// TODO: consider making our own recursive print function
t.Logf("test #%d: actual: \n\n%s\n", index, spew.Sdump(meta))
t.Logf("test #%d: expected: \n\n%s", index, spew.Sdump(metadata))
// more details, for tricky cases:
diffable := &pretty.Config{
Diffable: true,
IncludeUnexported: true,
//PrintStringers: false,
//PrintTextMarshalers: false,
//SkipZeroFields: false,
}
t.Logf("test #%d: actual: \n\n%s\n", index, diffable.Sprint(meta))
t.Logf("test #%d: expected: \n\n%s", index, diffable.Sprint(metadata))
t.Logf("test #%d: diff:\n%s", index, diff)
return
}
}
}
})
}
}
func TestMetadataSave0(t *testing.T) {
// Since we put local path information into metadataPath, we'd like to
// test that we don't leak it into our remote filesystem. This isn't a
// major issue, but it's not technically nice to tell anyone about it.
sentinel := "nope!"
md := &Metadata{
Main: "hello.mcl",
metadataPath: sentinel, // this value should not get seen
}
b, err := md.ToBytes()
if err != nil {
t.Errorf("can't print metadata file: %+v", err)
return
}
s := string(b) // convert
if strings.Contains(s, sentinel) { // did we find the sentinel?
t.Errorf("sentinel was found")
}
t.Logf("got:\n%s", s)
}