engine: traits: Allow self-kind with hierarchical grouping
Not sure why I was blocking this previously, perhaps there was no use case, and I was trying to ensure there wasn't accidental, unwanted grouping? Perhaps I wanted to improve performance? In any case, let's turn this off for now, and check for bugs.
This commit is contained in:
@@ -89,7 +89,11 @@ func (obj *Groupable) GroupRes(res engine.GroupableRes) error {
|
||||
ok = false // non-hierarchical grouping, error!
|
||||
}
|
||||
}
|
||||
if !ok {
|
||||
// XXX: Why is it not acceptable to allow hierarchical grouping,
|
||||
// AND self-kind grouping together? For example, group
|
||||
// http:server:flag with another flag, and then group that group
|
||||
// inside http:server!
|
||||
if !ok && false { // XXX: disabled this check for now...
|
||||
return fmt.Errorf("the `%s` resource already contains %d grouped resources", res, l)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user