lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

engine: traits: Allow self-kind with hierarchical grouping

Browse Source 
Not sure why I was blocking this previously, perhaps there was no use
case, and I was trying to ensure there wasn't accidental, unwanted
grouping? Perhaps I wanted to improve performance? In any case, let's
turn this off for now, and check for bugs.
This commit is contained in:
James Shubin
2025-05-25 04:19:38 -04:00
parent be4cb6658e
commit fd5bc63293
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
engine/traits/autogroup.go
View File

@@ -89,7 +89,11 @@ func (obj *Groupable) GroupRes(res engine.GroupableRes) error {
ok = false // non-hierarchical grouping, error! ok = false // non-hierarchical grouping, error!
} }
} }
if !ok { // XXX: Why is it not acceptable to allow hierarchical grouping,
// AND self-kind grouping together? For example, group
// http:server:flag with another flag, and then group that group
// inside http:server!
if !ok && false { // XXX: disabled this check for now...
return fmt.Errorf("the `%s` resource already contains %d grouped resources", res, l) return fmt.Errorf("the `%s` resource already contains %d grouped resources", res, l)
} }
} }