lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lang: ast, interfaces: Improve speculation safety checks

Browse Source 
We want to speculate in more cases, so make sure that speculation is
safe!
This commit is contained in:
James Shubin
2025-03-06 16:53:57 -05:00
parent aea894a706
commit f87c550be1
2 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lang/ast/structs.go
View File

@@ -10484,6 +10484,13 @@ func (obj *ExprVar) SetType(typ *types.Type) error {
func (obj *ExprVar) Type() (*types.Type, error) {
// TODO: should this look more like Type() in ExprCall or vice-versa?
if obj.scope == nil { // avoid a possible nil panic if we speculate here
if obj.typ == nil {
return nil, errwrap.Wrapf(interfaces.ErrTypeCurrentlyUnknown, obj.String())
}
return obj.typ, nil
}
// Return the type if it is already known statically... It is useful for
// type unification to have some extra info early.
expr, exists := obj.scope.Variables[obj.Name]
@@ -10602,6 +10609,10 @@ func (obj *ExprVar) SetValue(value types.Value) error {
// it can lookup in the previous set scope which expression this points to, and
// then it can call Value on that expression.
func (obj *ExprVar) Value() (types.Value, error) {
if obj.scope == nil { // avoid a possible nil panic if we speculate here
return nil, errwrap.Wrapf(interfaces.ErrValueCurrentlyUnknown, obj.String())
}
expr, exists := obj.scope.Variables[obj.Name]
if !exists {
return nil, fmt.Errorf("var `%s` does not exist in scope", obj.Name)