From ce2f7112a3c08d3d89b14f24b6bcd7360e01b412 Mon Sep 17 00:00:00 2001 From: James Shubin Date: Sat, 25 Nov 2023 20:56:39 -0500 Subject: [PATCH] lang: funcs: funcgen: Don't nest unnecessarily Clean up the code. --- lang/funcs/funcgen/pkg.go | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/lang/funcs/funcgen/pkg.go b/lang/funcs/funcgen/pkg.go index 0edcb15b..92a803b6 100644 --- a/lang/funcs/funcgen/pkg.go +++ b/lang/funcs/funcgen/pkg.go @@ -101,14 +101,17 @@ func (obj *golangPackage) parsefuncs() (functions, error) { func (obj *golangPackage) extractFuncs(doc string, getHelp bool) (functions, error) { var funcs []function for _, line := range strings.Split(doc, "\n") { - if validSignature.MatchString(line) { - f, err := obj.parseFunctionLine(line, getHelp) - if err != nil && err != errExcluded { - return funcs, err - } - if f != nil { - funcs = append(funcs, *f) - } + if !validSignature.MatchString(line) { + // TODO: improve validSignature regexp for this? + fmt.Printf("invalid: %s\n", line) + continue + } + f, err := obj.parseFunctionLine(line, getHelp) + if err != nil && err != errExcluded { + return funcs, err + } + if f != nil { + funcs = append(funcs, *f) } }