lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

engine: util: Skip unexported fields in struct field mapping

Browse Source 
Unexported fields should be ignored when mapping structs from Golang to
mcl, as this avoids issues where certain structs cannot be used in mcl
representation due to their structure that may be incompatible with
conversion. Disallowing private fields allows those to still be included
in the struct but ignored when mapping the types, allowing the mcl
representation of the type to stil be valid

Resolves: https://github.com/purpleidea/mgmt/issues/684
Signed-off-by: Joe Groocock <me@frebib.net>
This commit is contained in:
Joe Groocock
2021-12-01 22:06:06 +00:00
parent 0652273fe1
commit bf7e45439b
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
engine/util/util.go
View File

@@ -276,6 +276,13 @@ func StructKindToFieldNameTypeMap(kind string) (map[string]*types.Type, error) {
// continue // continue
//} //}
// Skip unexported fields. These should never be mapped golang<->mcl.
// TODO: Use StructField.IsExported() in golang 1.17
//if !field.IsExported() {
if field.PkgPath != "" {
continue
}
typ, err := types.TypeOf(field.Type) typ, err := types.TypeOf(field.Type)
// some types (eg complex64) aren't convertible, so skip for now... // some types (eg complex64) aren't convertible, so skip for now...
if err != nil { if err != nil {