lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

prometheus: Remove mgmt_process_start_time_seconds metric

Browse Source 
That metric is useless as by default the prometheus golang client
provides the `process_start_time_seconds` metric.

This reverts commit 25e2af7c89.
This commit is contained in:
Julien Pivotto
2017-02-14 22:56:12 +01:00
parent ecbaa5bfc1
commit be5040e7a8
3 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/prometheus.md
View File

@@ -52,7 +52,6 @@ Here is a list of the metrics we provide:
- `mgmt_checkapply_total`: The number of CheckApply's that mgmt has run - `mgmt_checkapply_total`: The number of CheckApply's that mgmt has run
- `mgmt_failures_total`: The number of resources that have failed - `mgmt_failures_total`: The number of resources that have failed
- `mgmt_failures_current`: The number of resources that have failed - `mgmt_failures_current`: The number of resources that have failed
- `mgmt_process_start_time_seconds`: Start time of the process since unix epoch in seconds
For each metric, you will get some extra labels: For each metric, you will get some extra labels:

13
prometheus/prometheus.go
View File

@@ -36,8 +36,7 @@ const DefaultPrometheusListen = "127.0.0.1:9233"
type Prometheus struct { type Prometheus struct {
Listen string // the listen specification for the net/http server Listen string // the listen specification for the net/http server
checkApplyTotal *prometheus.CounterVec // total of CheckApplies that have been triggered checkApplyTotal *prometheus.CounterVec // total of CheckApplies that have been triggered
processStartTimeSeconds prometheus.Gauge // process start time in seconds since unix epoch
} }
@@ -60,16 +59,6 @@ func (obj *Prometheus) Init() error {
) )
prometheus.MustRegister(obj.checkApplyTotal) prometheus.MustRegister(obj.checkApplyTotal)
obj.processStartTimeSeconds = prometheus.NewGauge(
prometheus.GaugeOpts{
Name: "mgmt_process_start_time_seconds",
Help: "Start time of the process since unix epoch in seconds.",
},
)
prometheus.MustRegister(obj.processStartTimeSeconds)
// directly set the processStartTimeSeconds
obj.processStartTimeSeconds.SetToCurrentTime()
return nil return nil
} }

3
test/shell/prometheus-1.sh
View File

@@ -11,9 +11,6 @@ curl 127.0.0.1:9233/metrics | grep "^etcd_server_has_leader 1"
# Check that go metrics are loaded # Check that go metrics are loaded
curl 127.0.0.1:9233/metrics | grep "^go_goroutines [0-9]\+" curl 127.0.0.1:9233/metrics | grep "^go_goroutines [0-9]\+"
# Check mgmt_process_start_time_seconds
curl 127.0.0.1:9233/metrics | grep "^mgmt_process_start_time_seconds [0-9]\+"
killall -SIGINT mgmt # send ^C to exit mgmt killall -SIGINT mgmt # send ^C to exit mgmt
wait $pid # get exit status wait $pid # get exit status
exit $? exit $?