util: errwrap: Add unwrapping for context removal
It's common in many concurrent engines to have a situation where we collect errors on shutdown. Errors can either because a context closed, or because some engine error happened. The latter, can also cause the former, leading to a list of returned errors. In these scenarios, we want to filter out all the secondary context errors, unless that's all that's there. This provides a helper function to do so.
This commit is contained in:
@@ -32,6 +32,7 @@
|
||||
package errwrap
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"testing"
|
||||
@@ -163,6 +164,148 @@ func TestJoinErr10(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext1(t *testing.T) {
|
||||
if reterr := WithoutContext(nil); reterr != nil {
|
||||
t.Errorf("expected nil result")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext2(t *testing.T) {
|
||||
err := fmt.Errorf("err")
|
||||
if reterr := WithoutContext(err); reterr != err {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext3(t *testing.T) {
|
||||
err := context.Canceled
|
||||
if reterr := WithoutContext(err); reterr != err {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext4(t *testing.T) {
|
||||
err1 := fmt.Errorf("err")
|
||||
err2 := context.Canceled
|
||||
err := Append(err1, err2)
|
||||
if reterr := WithoutContext(err); reterr != err1 {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext5(t *testing.T) {
|
||||
err1 := context.Canceled
|
||||
err2 := fmt.Errorf("err")
|
||||
err := Append(err1, err2)
|
||||
if reterr := WithoutContext(err); reterr != err2 {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext6(t *testing.T) {
|
||||
err1 := context.Canceled
|
||||
err2 := context.Canceled
|
||||
err := Append(err1, err2)
|
||||
if reterr := WithoutContext(err); reterr != err1 {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
if reterr := WithoutContext(err); reterr != err2 {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext7(t *testing.T) {
|
||||
err1 := fmt.Errorf("err1")
|
||||
err2 := fmt.Errorf("err2")
|
||||
err := Append(err1, err2)
|
||||
if reterr := WithoutContext(err); reterr.Error() != err.Error() {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext8(t *testing.T) {
|
||||
err1 := fmt.Errorf("err1")
|
||||
err2 := fmt.Errorf("err2")
|
||||
err3 := fmt.Errorf("err3")
|
||||
err := Join([]error{err1, err2, err3})
|
||||
if reterr := WithoutContext(err); reterr.Error() != err.Error() {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext9(t *testing.T) {
|
||||
err1 := context.Canceled
|
||||
err2 := fmt.Errorf("err2")
|
||||
err3 := fmt.Errorf("err3")
|
||||
err := Join([]error{err1, err2, err3})
|
||||
exp := Join([]error{nil, err2, err3})
|
||||
if reterr := WithoutContext(err); reterr.Error() != exp.Error() {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext10(t *testing.T) {
|
||||
err1 := fmt.Errorf("err1")
|
||||
err2 := context.Canceled
|
||||
err3 := fmt.Errorf("err3")
|
||||
err := Join([]error{err1, err2, err3})
|
||||
exp := Join([]error{err1, nil, err3})
|
||||
if reterr := WithoutContext(err); reterr.Error() != exp.Error() {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext11(t *testing.T) {
|
||||
err1 := fmt.Errorf("err1")
|
||||
err2 := fmt.Errorf("err2")
|
||||
err3 := context.Canceled
|
||||
err := Join([]error{err1, err2, err3})
|
||||
exp := Join([]error{err1, err2, nil})
|
||||
if reterr := WithoutContext(err); reterr.Error() != exp.Error() {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext12(t *testing.T) {
|
||||
err1 := fmt.Errorf("err1")
|
||||
err2 := context.Canceled
|
||||
err3 := context.Canceled
|
||||
err := Join([]error{err1, err2, err3})
|
||||
if reterr := WithoutContext(err); reterr != err1 {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext13(t *testing.T) {
|
||||
err1 := context.Canceled
|
||||
err2 := fmt.Errorf("err2")
|
||||
err3 := context.Canceled
|
||||
err := Join([]error{err1, err2, err3})
|
||||
if reterr := WithoutContext(err); reterr != err2 {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext14(t *testing.T) {
|
||||
err1 := context.Canceled
|
||||
err2 := context.Canceled
|
||||
err3 := fmt.Errorf("err3")
|
||||
err := Join([]error{err1, err2, err3})
|
||||
if reterr := WithoutContext(err); reterr != err3 {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestWithoutContext15(t *testing.T) {
|
||||
err1 := context.Canceled
|
||||
err2 := context.Canceled
|
||||
err3 := context.Canceled
|
||||
err := Join([]error{err1, err2, err3})
|
||||
if reterr := WithoutContext(err); reterr != context.Canceled {
|
||||
t.Errorf("expected err")
|
||||
}
|
||||
}
|
||||
|
||||
func TestString1(t *testing.T) {
|
||||
var err error
|
||||
if String(err) != "" {
|
||||
|
||||
Reference in New Issue
Block a user