From bd708159a1b56c19ac9c5c41c63301e150c90416 Mon Sep 17 00:00:00 2001 From: James Shubin Date: Fri, 16 Feb 2024 07:33:55 -0500 Subject: [PATCH] engine: resources: Close files after use Don't need to wait for gc. --- engine/resources/http.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/engine/resources/http.go b/engine/resources/http.go index 5f874e43..4eed51be 100644 --- a/engine/resources/http.go +++ b/engine/resources/http.go @@ -247,6 +247,7 @@ func (obj *HTTPServerRes) ServeHTTP(w http.ResponseWriter, req *http.Request) { sendHTTPError(w, err) return } + defer handle.Close() // ignore error // Determine the last-modified time if we can. modtime := time.Now() @@ -969,6 +970,12 @@ func (obj *HTTPFileRes) ServeHTTP(w http.ResponseWriter, req *http.Request) { sendHTTPError(w, err) return } + //if readSeekCloser, ok := handle.(io.ReadSeekCloser); ok { // same + // defer readSeekCloser.Close() // ignore error + //} + if closer, ok := handle.(io.Closer); ok { + defer closer.Close() // ignore error + } // Determine the last-modified time if we can. modtime := time.Now()