lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lang: ast: Catch ordering errors

Browse Source
This commit is contained in:
James Shubin
2025-03-09 01:49:37 -05:00
parent 6bae5fc561
commit a50765393d
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lang/ast/structs.go
View File

@@ -5017,7 +5017,6 @@ func (obj *StmtProg) SetScope(scope *interfaces.Scope) error {
// If we don't do this deterministically the type unification errors can // If we don't do this deterministically the type unification errors can
// flip from `type error: int != str` to `type error: str != int` etc... // flip from `type error: int != str` to `type error: str != int` etc...
nodeOrder, err := orderingGraph.DeterministicTopologicalSort() // sorted! nodeOrder, err := orderingGraph.DeterministicTopologicalSort() // sorted!
if err != nil { if err != nil {
// TODO: print the cycle in a prettier way (with names?) // TODO: print the cycle in a prettier way (with names?)
if obj.data.Debug { if obj.data.Debug {
@@ -5026,6 +5025,12 @@ func (obj *StmtProg) SetScope(scope *interfaces.Scope) error {
} }
return errwrap.Wrapf(err, "recursive reference while setting scope") return errwrap.Wrapf(err, "recursive reference while setting scope")
} }
if obj.data.Debug { // XXX: catch ordering errors in the logs
obj.data.Logf("nodeOrder:")
for i, x := range nodeOrder {
obj.data.Logf("nodeOrder[%d]: %+v", i, x)
}
}
// XXX: implement ValidTopoSortOrder! // XXX: implement ValidTopoSortOrder!
//topoSanity := (RequireTopologicalOrdering || TopologicalOrderingWarning) //topoSanity := (RequireTopologicalOrdering || TopologicalOrderingWarning)