lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

etcd: Switch to buffered channel to remove duplicates

Browse Source 
Since we don't return the actual values and instead only tell about
events (which leaves the `Get` of the value as a second operation) then
we don't have to use a channel with backpressure since all the events
are identical.
This commit is contained in:
James Shubin
2017-03-03 19:03:22 -05:00
parent 203d866643
commit a469029698
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
etcd/str.go
View File

@@ -33,7 +33,7 @@ import (
func WatchStr(obj *EmbdEtcd, key string) chan error { func WatchStr(obj *EmbdEtcd, key string) chan error {
// new key structure is /$NS/strings/$key/$hostname = $data // new key structure is /$NS/strings/$key/$hostname = $data
path := fmt.Sprintf("/%s/strings/%s", NS, key) path := fmt.Sprintf("/%s/strings/%s", NS, key)
ch := make(chan error) ch := make(chan error, 1)
// FIXME: fix our API so that we get a close event on shutdown. // FIXME: fix our API so that we get a close event on shutdown.
callback := func(re *RE) error { callback := func(re *RE) error {
// TODO: is this even needed? it used to happen on conn errors // TODO: is this even needed? it used to happen on conn errors
@@ -41,7 +41,9 @@ func WatchStr(obj *EmbdEtcd, key string) chan error {
if re == nil || re.response.Canceled { if re == nil || re.response.Canceled {
return fmt.Errorf("watch is empty") // will cause a CtxError+retry return fmt.Errorf("watch is empty") // will cause a CtxError+retry
} }
ch <- nil // event if len(ch) == 0 { // send event only if one isn't pending
ch <- nil // event
}
return nil return nil
} }
_, _ = obj.AddWatcher(path, callback, true, false, etcd.WithPrefix()) // no need to check errors _, _ = obj.AddWatcher(path, callback, true, false, etcd.WithPrefix()) // no need to check errors