lang: Detect sub tests with the same name

This detects identically named tests and fails the test in such a
scenario to prevent confusion.
This commit is contained in:
James Shubin
2018-07-07 12:20:23 -04:00
parent cf50fb3568
commit a287f028d1
5 changed files with 54 additions and 1 deletions

View File

@@ -26,6 +26,7 @@ import (
"github.com/purpleidea/mgmt/lang/interfaces"
"github.com/purpleidea/mgmt/lang/types"
"github.com/purpleidea/mgmt/lang/unification"
"github.com/purpleidea/mgmt/util"
)
func TestUnification1(t *testing.T) {
@@ -511,7 +512,13 @@ func TestUnification1(t *testing.T) {
})
}
names := []string{}
for index, test := range values { // run all the tests
if util.StrInList(test.name, names) {
t.Errorf("test #%d: duplicate sub test name of: %s", index, test.name)
continue
}
names = append(names, test.name)
t.Run(fmt.Sprintf("test #%d (%s)", index, test.name), func(t *testing.T) {
ast, fail, expect := test.ast, test.fail, test.expect