lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gapi: Allow the GAPI implementer to specify fast and exit

Browse Source 
This allows the implementer of the GAPI to specify three parameters for
every Next message sent on the channel. The Fast parameter tells the
agent if it should do the pause quickly or if it should finish the
sequence. A quick pause means that it will cause a pause immediately
after the currently running resources finish, where as a slow (default)
pause will allow the wave of execution to finish. This is usually
preferred in scenarios where complex graphs are used where we want each
step to complete. The Exit parameter tells the engine to exit, and the
Err parameter tells the engine that an error occurred.
This commit is contained in:
James Shubin
2017-06-02 03:39:42 -04:00
parent 9531465410
commit 9cbaa892d3
12 changed files with 129 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lib/main.go
View File

@@ -380,7 +380,7 @@ func (obj *Main) Run() error {
Debug: obj.Flags.Debug,
}
var gapiChan chan error // stream events are nil errors
var gapiChan chan gapi.Next // stream events contain some instructions!
if obj.GAPI != nil {
data := gapi.Data{
Hostname: hostname,
@@ -405,8 +405,9 @@ func (obj *Main) Run() error {
log.Println("Main: Waiting...")
// The GAPI should always kick off an event on Next() at
// startup when (and if) it indeed has a graph to share!
fastPause := false
select {
case err, ok := <-gapiChan:
case next, ok := <-gapiChan:
if !ok { // channel closed
if obj.Flags.Debug {
log.Printf("Main: GAPI exited")
@@ -415,17 +416,22 @@ func (obj *Main) Run() error {
continue
}
// if we've been asked to exit...
if next.Exit {
obj.Exit(next.Err) // trigger exit
continue // wait for exitchan
}
// the gapi lets us send an error to the channel
// this means there was a failure, but not fatal
if err != nil {
if err := next.Err; err != nil {
log.Printf("Main: Error with graph stream: %v", err)
// TODO: consider adding an option to
// exit on stream errors...
//obj.Exit(err) // trigger exit
continue // wait for exitchan or another event
continue // wait for another event
}
// everything else passes through to cause a compile!
fastPause = next.Fast // should we pause fast?
case <-exitchan:
return
}
@@ -438,8 +444,8 @@ func (obj *Main) Run() error {
// we need the vertices to be paused to work on them, so
// run graph vertex LOCK...
if !first { // TODO: we can flatten this check out I think
converger.Pause() // FIXME: add sync wait?
graph.Pause(false) // sync
converger.Pause() // FIXME: add sync wait?
graph.Pause(fastPause) // sync
//graph.UnGroup() // FIXME: implement me if needed!
}