lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lang: funcs: Ensure that Info sig's are invalid if not built yet

Browse Source 
In case something in the type unification tries to speculatively call
Info before it's ready to produce a valid sig, make sure we only return
a definitive answer (non-nil, and no variant types) once we've
conclusively finished defining the signature.
This commit is contained in:
James Shubin
2021-05-19 10:33:35 -04:00
parent b3d1ed9e65
commit 95cfbd0fff
7 changed files with 68 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lang/funcs/structs/if.go
View File

@@ -46,15 +46,18 @@ func (obj *IfFunc) Validate() error {
// Info returns some static info about itself.
func (obj *IfFunc) Info() *interfaces.Info {
typ := &types.Type{
Kind: types.KindFunc, // function type
Map: map[string]*types.Type{
"c": types.TypeBool, // conditional must be a boolean
"a": obj.Type, // true branch must be this type
"b": obj.Type, // false branch must be this type too
},
Ord: []string{"c", "a", "b"}, // conditional, and two branches
Out: obj.Type, // result type must match
var typ *types.Type
if obj.Type != nil { // don't panic if called speculatively
typ = &types.Type{
Kind: types.KindFunc, // function type
Map: map[string]*types.Type{
"c": types.TypeBool, // conditional must be a boolean
"a": obj.Type, // true branch must be this type
"b": obj.Type, // false branch must be this type too
},
Ord: []string{"c", "a", "b"}, // conditional, and two branches
Out: obj.Type, // result type must match
}
}
return &interfaces.Info{