lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

engine: graph, util: Restore send/recv behaviour

Browse Source 
A regression in 4b0cdf9123 caused the
basic send/recv functionality to break for simple scenarios. This was
due to inadequate testing, and a partial misunderstanding of the
situation.

New testing should hopefully catch more cases, but send/recv and
compile-time checks are still not as complete as is probably possible.
This commit is contained in:
James Shubin
2024-01-31 20:25:58 -05:00
parent fc49888ba2
commit 8ea7d4cf84
7 changed files with 186 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
engine/util/util.go
View File

@@ -192,16 +192,16 @@ func StructFieldCompat(st1 interface{}, key1 string, st2 interface{}, key2 strin
return fmt.Errorf("can't interface the recv")
}
// If we're sending _from_ an interface...
// If we're sending _from_ an interface... (value res `any` field)
if kind1 == reflect.Interface || kind1 == reflect.Ptr {
// TODO: Can we do more checks instead of only returning early?
return nil
}
// If we're sending _to_ an interface...
//if kind2 == reflect.Interface {
// // TODO: Can we do more checks instead of only returning early?
// return nil
//}
// If we're sending _to_ an interface... (value res `any` field)
if kind2 == reflect.Interface || kind2 == reflect.Ptr {
// TODO: Can we do more checks instead of only returning early?
return nil
}
if kind1 != kind2 {
return fmt.Errorf("field kind mismatch between %s and %s", kind1, kind2)