lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

engine: resources: Make sure to set the netmask

Browse Source 
Some clients would DECLINE if this was not set. This was reproduced my
using the stock coredhcp DHCPv4 server and disabling the netmask plugin.
One of the clients that would DECLINE is a Lenovo ThinkCentre m90n doing
a UEFI (PXE) netboot.

This was found in 1327752725 and is
hopefully now completely fixed!
This commit is contained in:
James Shubin
2024-10-25 00:57:50 -04:00
parent 2c967e3897
commit 85e1d6c0e8
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
engine/resources/dhcp.go
View File

@@ -895,7 +895,7 @@ func (obj *DHCPServerRes) handler4() func(net.PacketConn, net.Addr, *dhcpv4.DHCP
case dhcpv4.MessageTypeRequest: case dhcpv4.MessageTypeRequest:
tmp.UpdateOption(dhcpv4.OptMessageType(dhcpv4.MessageTypeAck)) tmp.UpdateOption(dhcpv4.OptMessageType(dhcpv4.MessageTypeAck))
case dhcpv4.MessageTypeDecline: case dhcpv4.MessageTypeDecline:
// XXX: Why did one PXE/UEFI netboot client send this? // If mask is not set, some DHCP clients will DECLINE.
obj.init.Logf("handler4: Unhandled decline message: %+v", req) obj.init.Logf("handler4: Unhandled decline message: %+v", req)
return return
default: default:
@@ -983,6 +983,7 @@ func (obj *DHCPServerRes) handler4() func(net.PacketConn, net.Addr, *dhcpv4.DHCP
if resp != nil { if resp != nil {
if obj.init.Debug { if obj.init.Debug {
// NOTE: This is very useful for debugging!
obj.init.Logf("sending a DHCPv4 packet: %s", resp.Summary()) obj.init.Logf("sending a DHCPv4 packet: %s", resp.Summary())
} }
var peer net.Addr var peer net.Addr
@@ -1255,7 +1256,7 @@ func (obj *DHCPHostRes) handler4(data *HostData) (func(*dhcpv4.DHCPv4, *dhcpv4.D
// XXX: https://tools.ietf.org/html/rfc2132#section-3.3 // XXX: https://tools.ietf.org/html/rfc2132#section-3.3
// If both the subnet mask and the router option are specified // If both the subnet mask and the router option are specified
// in a DHCP reply, the subnet mask option MUST be first. // in a DHCP reply, the subnet mask option MUST be first.
// XXX: Should we do this? Does it matter? Does the lib do it? // If mask is not set, some DHCP clients will DECLINE.
resp.Options.Update(dhcpv4.OptSubnetMask(obj.ipv4Mask)) // net.IPMask resp.Options.Update(dhcpv4.OptSubnetMask(obj.ipv4Mask)) // net.IPMask
// nbp section // nbp section
@@ -1936,8 +1937,8 @@ func (obj *DHCPRangeRes) handler4(data *HostData) (func(*dhcpv4.DHCPv4, *dhcpv4.
// XXX: https://tools.ietf.org/html/rfc2132#section-3.3 // XXX: https://tools.ietf.org/html/rfc2132#section-3.3
// If both the subnet mask and the router option are specified // If both the subnet mask and the router option are specified
// in a DHCP reply, the subnet mask option MUST be first. // in a DHCP reply, the subnet mask option MUST be first.
// XXX: Should we do this? Does it matter? Does the lib do it? // If mask is not set, some DHCP clients will DECLINE.
//resp.Options.Update(dhcpv4.OptSubnetMask(obj.mask)) // net.IPMask resp.Options.Update(dhcpv4.OptSubnetMask(obj.mask)) // net.IPMask
// nbp section // nbp section
if obj.opt66 != nil && req.IsOptionRequested(dhcpv4.OptionTFTPServerName) { if obj.opt66 != nil && req.IsOptionRequested(dhcpv4.OptionTFTPServerName) {