lang: core: os: Add family functions and variables

Make it easier to do os-specific stuff.

lang/core/os/family_func.go

@@ -34,63 +34,141 @@ import (
 	"os"
 
 	"github.com/purpleidea/mgmt/lang/funcs/simple"
+	"github.com/purpleidea/mgmt/lang/funcs/vars"
 	"github.com/purpleidea/mgmt/lang/types"
 )
 
 func init() {
-	// TODO: Create a family method that will return a giant struct.
+	simple.ModuleRegister(ModuleName, "family", &simple.Scaffold{
-	simple.ModuleRegister(ModuleName, "is_debian", &simple.Scaffold{
+		T: types.NewType("func() str"),
-		T: types.NewType("func() bool"),
+		F: Family,
-		F: IsDebian,
 	})
+
+	vars.ModuleRegister(ModuleName, "family_redhat", func() vars.Value {
+		return &types.StrValue{
+			V: familyRedHat,
+		}
+	})
+	vars.ModuleRegister(ModuleName, "family_debian", func() vars.Value {
+		return &types.StrValue{
+			V: familyDebian,
+		}
+	})
+	vars.ModuleRegister(ModuleName, "family_archlinux", func() vars.Value {
+		return &types.StrValue{
+			V: familyArchLinux,
+		}
+	})
+
+	// TODO: Create a family method that will return a giant struct.
 	simple.ModuleRegister(ModuleName, "is_redhat", &simple.Scaffold{
 		T: types.NewType("func() bool"),
 		F: IsRedHat,
 	})
+	simple.ModuleRegister(ModuleName, "is_debian", &simple.Scaffold{
+		T: types.NewType("func() bool"),
+		F: IsDebian,
+	})
 	simple.ModuleRegister(ModuleName, "is_archlinux", &simple.Scaffold{
 		T: types.NewType("func() bool"),
 		F: IsArchLinux,
 	})
 }
 
-// IsDebian detects if the os family is debian.
+const (
+	familyRedHat    = "redhat"
+	familyDebian    = "debian"
+	familyArchLinux = "archlinux"
+)
+
+// Family returns the distro family.
 // TODO: Detect OS changes.
-func IsDebian(ctx context.Context, input []types.Value) (types.Value, error) {
+func Family(ctx context.Context, input []types.Value) (types.Value, error) {
-	exists := true
+	if b, err := isRedHat(ctx); err != nil {
-	// TODO: use ctx around io operations
+		return nil, err
-	_, err := os.Stat("/etc/debian_version")
+	} else if b {
-	if os.IsNotExist(err) {
+		return &types.StrValue{
-		exists = false
+			V: familyRedHat,
+		}, nil
 	}
-	return &types.BoolValue{
+	if b, err := isDebian(ctx); err != nil {
-		V: exists,
+		return nil, err
+	} else if b {
+		return &types.StrValue{
+			V: familyDebian,
+		}, nil
+	}
+	if b, err := isArchLinux(ctx); err != nil {
+		return nil, err
+	} else if b {
+		return &types.StrValue{
+			V: familyArchLinux,
+		}, nil
+	}
+	return &types.StrValue{
+		V: "", // unknown
 	}, nil
 }
 
 // IsRedHat detects if the os family is redhat.
 // TODO: Detect OS changes.
 func IsRedHat(ctx context.Context, input []types.Value) (types.Value, error) {
-	exists := true
+	b, err := isRedHat(ctx)
-	// TODO: use ctx around io operations
-	_, err := os.Stat("/etc/redhat-release")
-	if os.IsNotExist(err) {
-		exists = false
-	}
 	return &types.BoolValue{
-		V: exists,
+		V: b,
-	}, nil
+	}, err
+}
+
+// IsDebian detects if the os family is debian.
+// TODO: Detect OS changes.
+func IsDebian(ctx context.Context, input []types.Value) (types.Value, error) {
+	b, err := isDebian(ctx)
+	return &types.BoolValue{
+		V: b,
+	}, err
 }
 
 // IsArchLinux detects if the os family is archlinux.
 // TODO: Detect OS changes.
 func IsArchLinux(ctx context.Context, input []types.Value) (types.Value, error) {
-	exists := true
+	b, err := isArchLinux(ctx)
+	return &types.BoolValue{
+		V: b,
+	}, err
+}
+
+func isRedHat(ctx context.Context) (bool, error) {
+	// TODO: use ctx around io operations
+	_, err := os.Stat("/etc/redhat-release")
+	if os.IsNotExist(err) {
+		return false, nil
+	}
+	if err != nil {
+		return false, err
+	}
+	return true, nil
+}
+
+func isDebian(ctx context.Context) (bool, error) {
+	// TODO: use ctx around io operations
+	_, err := os.Stat("/etc/debian_version")
+	if os.IsNotExist(err) {
+		return false, nil
+	}
+	if err != nil {
+		return false, err
+	}
+	return true, nil
+}
+
+func isArchLinux(ctx context.Context) (bool, error) {
 	// TODO: use ctx around io operations
 	_, err := os.Stat("/etc/arch-release")
 	if os.IsNotExist(err) {
-		exists = false
+		return false, nil
 	}
-	return &types.BoolValue{
+	if err != nil {
-		V: exists,
+		return false, err
-	}, nil
+	}
+	return true, nil
 }