lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

resources: Use named fields to avoid bothering go vet

Browse Source 
This removes an invalid warning which tries to prevent ambiguous changes
I suppose.
This commit is contained in:
James Shubin
2016-10-03 15:02:41 -04:00
parent b7bd2d2664
commit 71a82b0a34
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
resources/resources.go
View File

@@ -241,7 +241,7 @@ func (obj *BaseRes) SetState(state ResState) {
// I'm not completely comfortable with this fn, but it will have to do for now. // I'm not completely comfortable with this fn, but it will have to do for now.
func (obj *BaseRes) DoSend(processChan chan event.Event, comment string) (bool, error) { func (obj *BaseRes) DoSend(processChan chan event.Event, comment string) (bool, error) {
resp := event.NewResp() resp := event.NewResp()
processChan <- event.Event{event.EventNil, resp, comment, true} // trigger process processChan <- event.Event{Name: event.EventNil, Resp: resp, Msg: comment, Activity: true} // trigger process
e := resp.Wait() e := resp.Wait()
return false, e // XXX: at the moment, we don't use the exit bool. return false, e // XXX: at the moment, we don't use the exit bool.
// XXX: this can cause a deadlock. do we need to recursively send? fix event stuff! // XXX: this can cause a deadlock. do we need to recursively send? fix event stuff!
@@ -269,12 +269,12 @@ func (obj *BaseRes) SendEvent(ev event.EventName, sync bool, activity bool) bool
return false // if we don't return, we'll block on the send return false // if we don't return, we'll block on the send
} }
if !sync { if !sync {
obj.events <- event.Event{ev, nil, "", activity} obj.events <- event.Event{Name: ev, Resp: nil, Msg: "", Activity: activity}
return true return true
} }
resp := event.NewResp() resp := event.NewResp()
obj.events <- event.Event{ev, resp, "", activity} obj.events <- event.Event{Name: ev, Resp: resp, Msg: "", Activity: activity}
resp.ACKWait() // waits until true (nil) value resp.ACKWait() // waits until true (nil) value
return true return true
} }