From 63d7b8e51e136c11a4728c2c95f5044aa0747f52 Mon Sep 17 00:00:00 2001 From: Edward Toroshchyn Date: Sun, 23 Feb 2025 13:51:13 +0100 Subject: [PATCH] engine: resources: exec: Fix wrong err variable being checked in test --- engine/resources/exec_test.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/engine/resources/exec_test.go b/engine/resources/exec_test.go index adbfbeb8..f2201723 100644 --- a/engine/resources/exec_test.go +++ b/engine/resources/exec_test.go @@ -412,7 +412,7 @@ func TestExecTimeoutBehaviour(t *testing.T) { } exitErr, ok := err.(*exec.ExitError) // embeds an os.ProcessState - if err != nil && ok { + if ok { pStateSys := exitErr.Sys() // (*os.ProcessState) Sys wStatus, ok := pStateSys.(syscall.WaitStatus) if !ok { @@ -432,13 +432,8 @@ func TestExecTimeoutBehaviour(t *testing.T) { t.Logf("exit status: %d", wStatus.ExitStatus()) return - - } else if err != nil { - t.Errorf("general cmd error") - return } - - // no error + t.Errorf("general cmd error") } func TestExecAutoEdge1(t *testing.T) {