lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

etcd: Log an error that wasn't getting seen

Browse Source 
We would error when the address could not bind, but it was for
non-standard reasons, and we didn't see the specific reason why.
This commit is contained in:
James Shubin
2020-04-11 02:01:37 -04:00
parent c9d5c50402
commit 5b83febb23
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
etcd/callback.go
View File

@@ -160,6 +160,11 @@ func (obj *EmbdEtcd) nominateCb(ctx context.Context) error {
defer close(obj.errExitN) // multi-signal for errChan close op defer close(obj.errExitN) // multi-signal for errChan close op
// blocks until server exits // blocks until server exits
serverErr = obj.runServer(newCluster, nominated) serverErr = obj.runServer(newCluster, nominated)
if serverErr != nil {
// TODO: why isn't this error seen elsewhere?
// TODO: shouldn't it get propagated somewhere?
obj.Logf("runServer exited with: %+v", serverErr)
}
// in case this exits on its own instead of with destroy // in case this exits on its own instead of with destroy
defer obj.destroyServer() // run to reset some values defer obj.destroyServer() // run to reset some values
if sendError && serverErr != nil { // exited with an error if sendError && serverErr != nil { // exited with an error