lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

resources: virt: Remove unnecessary early exit from CheckApply

Browse Source 
I don't think this early exit is necessary any more, since the main
CheckApply function really just spawns out to the different sub workers
which all individually check the apply variable.

If I'm wrong, we can revert this. It was @roidelapluie that noticed the
check here to begin with.
This commit is contained in:
James Shubin
2017-02-25 21:29:08 -05:00
parent 79923a939b
commit 57d8aa4190
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
resources/virt.go
View File

@@ -836,11 +836,6 @@ func (obj *VirtRes) CheckApply(apply bool) (bool, error) {
// FIXME: should we wait to ensure machine is booted before continuing? // FIXME: should we wait to ensure machine is booted before continuing?
// it may be useful to wait for guest agent to hotplug some ram or cpu! // it may be useful to wait for guest agent to hotplug some ram or cpu!
if !apply {
return false, nil
}
// remaining apply portion
// mem & cpu checks... // mem & cpu checks...
if !obj.absent { if !obj.absent {
if c, err := obj.attrCheckApply(apply, dom); err != nil { if c, err := obj.attrCheckApply(apply, dom); err != nil {