lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lang: Refactor all the highlight helping together

Browse Source 
Keep this cleaner and add a bit more.
This commit is contained in:
James Shubin
2025-06-07 00:23:45 -04:00
parent 2b7e9c3200
commit 55eeb50fb4
12 changed files with 35 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lang/unification/fastsolver/fastsolver.go
View File

@@ -143,6 +143,10 @@ func (obj *FastInvariantSolver) Solve(ctx context.Context, data *unification.Dat
obj.Logf("%s: %s", err.Error(), highlight)
}
return nil, fmt.Errorf("%s: %s", err.Error(), displayer.Byline())
// XXX: when we have fully populated all the position
// information, we could replace the above code with:
//return nil, interfaces.HighlightHelper(x.Node, obj.Logf, err)
}
if obj.Debug {
e1, e2 := unificationUtil.Extract(x.Expect), unificationUtil.Extract(x.Actual)
@@ -165,7 +169,9 @@ func (obj *FastInvariantSolver) Solve(ctx context.Context, data *unification.Dat
// TODO: collect all of these errors and return them together?
if t1.HasUni() { // || t2.HasUni()
return nil, fmt.Errorf("expr: %s is ambiguous: %s", x.Expr, u(t1))
err := fmt.Errorf("expr: %s is ambiguous: %s", x.Expr, u(t1))
return nil, interfaces.HighlightHelper(x.Node, obj.Logf, err)
}
//if err := t1.Cmp(t2); err != nil { // for development/debugging