lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

engine: resources, graph: Change the Close method to Cleanup

Browse Source 
This also changes a few similarly named methods. Clearer what it's doing
in terms of cleanup vs. causing some action.
This commit is contained in:
James Shubin
2023-08-08 00:19:51 -04:00
parent 63f05e12ca
commit 514927c0b3
39 changed files with 125 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
engine/graph/state.go
View File

@@ -263,9 +263,9 @@ func (obj *State) Init() error {
return nil
}
// Close shuts down and performs any cleanup. This is most akin to a "post" or
// Cleanup shuts down and performs any cleanup. This is most akin to a "post" or
// cleanup command as the initiator for closing a vertex happens in graph sync.
func (obj *State) Close() error {
func (obj *State) Cleanup() error {
res, isRes := obj.Vertex.(engine.Res)
if !isRes {
return fmt.Errorf("vertex is not a Res")
@@ -288,13 +288,13 @@ func (obj *State) Close() error {
var reverr error
// clear the reverse request from the disk...
if err := obj.ReversalClose(); err != nil {
if err := obj.ReversalCleanup(); err != nil {
// TODO: test this code path...
// TODO: should this be an error or a warning?
reverr = err
}
reterr := res.Close()
reterr := res.Cleanup()
if obj.Debug {
obj.Logf("Close(%s): Return(%+v)", res, reterr)
}