lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

engine: graph: Refactor the send/recv code to inline it

Browse Source 
This is useful subsequently.
This commit is contained in:
James Shubin
2023-11-12 16:13:04 -05:00
parent cb6b8a9670
commit 4fb356b19b
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
engine/graph/sendrecv.go
View File

@@ -128,13 +128,16 @@ func (obj *Engine) SendRecv(res engine.RecvableRes) (map[string]bool, error) {
} }
// if the values aren't equal, we're changing the receiver // if the values aren't equal, we're changing the receiver
if !reflect.DeepEqual(value1.Interface(), value2.Interface()) { if reflect.DeepEqual(value1.Interface(), value2.Interface()) {
// TODO: can we catch the panics here in case they happen? continue // skip as they're the same, no error needed
value2.Set(value1) // do it for all types that match
updated[k] = true // we updated this key!
v.Changed = true // tag this key as updated!
obj.Logf("SendRecv: %s.%s -> %s.%s", v.Res, v.Key, res, k)
} }
// TODO: can we catch the panics here in case they happen?
value2.Set(value1) // do it for all types that match
updated[k] = true // we updated this key!
v.Changed = true // tag this key as updated!
obj.Logf("SendRecv: %s.%s -> %s.%s", v.Res, v.Key, res, k)
} }
return updated, err return updated, err
} }