lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lang: Improve graph shape with speculative execution

Browse Source 
Most of the time, we don't need to have a dynamic call sub graph, since
the actual function call could be represented statically as it
originally was before lambda functions were implemented. Simplifying the
graph shape has important performance benefits in terms of both keep the
graph smaller (memory, etc) and in avoiding the need to run transactions
at runtime (speed) to reshape the graph.

Co-authored-by: Samuel Gélineau <gelisam@gmail.com>
This commit is contained in:
James Shubin
2025-03-17 02:31:01 -04:00
parent 9c9f2f558a
commit 37bb67dffd
139 changed files with 1871 additions and 262 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
lang/funcs/wrapped/wrapped.go
View File

@@ -39,6 +39,14 @@ import (
var _ interfaces.Func = &Func{} // ensure it meets this expectation
// Info holds some information about this function.
type Info struct {
Pure bool // is the function pure? (can it be memoized?)
Memo bool // should the function be memoized? (false if too much output)
Fast bool // is the function slow? (avoid speculative execution)
Spec bool // can we speculatively execute it? (true for most)
}
// Func is a wrapped scaffolding function struct which fulfills the boiler-plate
// for the function API, but that can run a very simple, static, pure, function.
// It can be wrapped by other structs that support polymorphism in various ways.
@@ -48,6 +56,9 @@ type Func struct {
// Name is a unique string name for the function.
Name string
// Info is some general info about the function.
FuncInfo *Info
// Type is the type of the function. It can include unification
// variables when this struct is wrapped in one that can build this out.
Type *types.Type
@@ -64,7 +75,16 @@ type Func struct {
// String returns a simple name for this function. This is needed so this struct
// can satisfy the pgraph.Vertex interface.
func (obj *Func) String() string {
return fmt.Sprintf("%s @ %p", obj.Name, obj) // be more unique!
//if obj.Fn != nil { // TODO: would this work and be useful?
// return fmt.Sprintf("%s: %s", obj.Name, obj.Fn)
//}
//if obj.Type != nil { // TODO: would this work and be useful?
// return fmt.Sprintf("%s: %s", obj.Name, obj.Type)
//}
if obj.Name == "" {
return "<wrapped>"
}
return obj.Name
}
// ArgGen returns the Nth arg name for this function.
@@ -104,12 +124,21 @@ func (obj *Func) Info() *interfaces.Info {
typ = obj.Fn.Type()
}
return &interfaces.Info{
Pure: true,
Memo: false, // TODO: should this be something we specify here?
info := &interfaces.Info{
Pure: false,
Memo: false,
Fast: false,
Spec: false,
Sig: typ,
Err: obj.Validate(),
}
if fi := obj.FuncInfo; fi != nil {
info.Pure = fi.Pure
info.Memo = fi.Memo
info.Fast = fi.Fast
info.Spec = fi.Spec
}
return info
}
// Init runs some startup code for this function.
@@ -184,5 +213,9 @@ func (obj *Func) Stream(ctx context.Context) error {
// Call this function with the input args and return the value if it is possible
// to do so at this time.
func (obj *Func) Call(ctx context.Context, args []types.Value) (types.Value, error) {
if obj.Fn == nil {
// happens with speculative graph shape code paths
return nil, fmt.Errorf("nil function")
}
return obj.Fn.Call(ctx, args) // (Value, error)
}