engine: graph: Improve comments

Clarify that we're referring to cycles in the graph, since it needs to
be a DAG.
This commit is contained in:
James Shubin
2020-01-12 16:39:32 -05:00
parent f07387225b
commit 3707b39fef
3 changed files with 6 additions and 6 deletions

View File

@@ -90,8 +90,8 @@ func AutoEdge(graph *pgraph.Graph, debug bool, logf func(format string, v ...int
} }
} }
// It would be great to ensure we didn't add any loops here, but instead // It would be great to ensure we didn't add any graph cycles here, but
// of checking now, we'll move the check into the main loop. // instead of checking now, we'll move the check into the main loop.
return nil return nil
} }

View File

@@ -66,8 +66,8 @@ func AutoGroup(ag engine.AutoGrouper, g *pgraph.Graph, debug bool, logf func(for
} }
} }
// It would be great to ensure we didn't add any loops here, but instead // It would be great to ensure we didn't add any graph cycles here, but
// of checking now, we'll move the check into the main loop. // instead of checking now, we'll move the check into the main loop.
return nil return nil
} }

View File

@@ -150,8 +150,8 @@ func (obj *Engine) Reversals() error {
} }
// TODO: Do we want a way for stored reversals to add edges too? // TODO: Do we want a way for stored reversals to add edges too?
// It would be great to ensure we didn't add any loops here, but instead // It would be great to ensure we didn't add any graph cycles here, but
// of checking now, we'll move the check into the main loop. // instead of checking now, we'll move the check into the main loop.
return nil return nil
} }