gapi: Unblock from a waiting send on GAPI close

There was a race condition that would sometimes occur in that if we
stopped reading from the gapiChan (on shutdown) but then a new message
was available before we managed to close the GAPI, then we would wait
forever to finish the close because the channel never sent, and the
WaitGroup wouldn't let us exit.

This fixes this horrible, horrible race.

examples/lib/libmgmt1.go

@@ -107,7 +107,11 @@ func (obj *MyGAPI) Next() chan error {
 			select {
 			case <-ticker.C:
 				log.Printf("libmgmt: Generating new graph...")
-				ch <- nil // trigger a run
+				select {
+				case ch <- nil: // trigger a run
+				case <-obj.closeChan:
+					return
+				}
 			case <-obj.closeChan:
 				return
 			}

examples/lib/libmgmt2.go

@@ -100,7 +100,11 @@ func (obj *MyGAPI) Next() chan error {
 			select {
 			case <-ticker.C:
 				log.Printf("libmgmt: Generating new graph...")
-				ch <- nil // trigger a run
+				select {
+				case ch <- nil: // trigger a run
+				case <-obj.closeChan:
+					return
+				}
 			case <-obj.closeChan:
 				return
 			}

examples/lib/libmgmt3.go

@@ -154,7 +154,11 @@ func (obj *MyGAPI) Next() chan error {
 			select {
 			case <-ticker.C:
 				log.Printf("libmgmt: Generating new graph...")
-				ch <- nil // trigger a run
+				select {
+				case ch <- nil: // trigger a run
+				case <-obj.closeChan:
+					return
+				}
 			case <-obj.closeChan:
 				return
 			}

puppet/gapi.go

@@ -100,7 +100,12 @@ func (obj *GAPI) Next() chan error {
 				}
 				log.Printf("Puppet: Generating new graph...")
 				pChan = puppetChan() // TODO: okay to update interval in case it changed?
-				ch <- nil            // trigger a run
+				select {
+				case ch <- nil: // trigger a run (send a msg)
+				// unblock if we exit while waiting to send!
+				case <-obj.closeChan:
+					return
+				}
 			case <-obj.closeChan:
 				return
 			}

yamlgraph/gapi.go

@@ -97,10 +97,15 @@ func (obj *GAPI) Next() chan error {
 					return
 				}
 				log.Printf("yamlgraph: Generating new graph...")
-				ch <- err // trigger a run
+				select {
+				case ch <- err: // trigger a run (send a msg)
 					if err != nil {
 						return
 					}
+				// unblock if we exit while waiting to send!
+				case <-obj.closeChan:
+					return
+				}
 			case <-obj.closeChan:
 				return
 			}