lang: Split lang package out into many subpackages
This is a giant refactor to split the giant lang package into many subpackages. The most difficult piece was figuring out how to extract the extra ast structs into their own package, because they needed to call two functions which also needed to import the ast. The solution was to separate out those functions into their own packages, and to pass them into the ast at the root when they're needed, and to let the relevant ast portions call a handle. This isn't terribly ugly because we already had a giant data struct woven through the ast. The bad part is rebasing any WIP work on top of this.
This commit is contained in:
James Shubin
361
lang/interpolate/interpolate.go
Normal file
361
lang/interpolate/interpolate.go
Normal file
@@ -0,0 +1,361 @@
|
||||
// Mgmt
|
||||
// Copyright (C) 2013-2021+ James Shubin and the project contributors
|
||||
// Written by James Shubin <james@shubin.ca> and the project contributors
|
||||
//
|
||||
// This program is free software: you can redistribute it and/or modify
|
||||
// it under the terms of the GNU General Public License as published by
|
||||
// the Free Software Foundation, either version 3 of the License, or
|
||||
// (at your option) any later version.
|
||||
//
|
||||
// This program is distributed in the hope that it will be useful,
|
||||
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
// GNU General Public License for more details.
|
||||
//
|
||||
// You should have received a copy of the GNU General Public License
|
||||
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
package interpolate
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
|
||||
"github.com/purpleidea/mgmt/lang/ast"
|
||||
"github.com/purpleidea/mgmt/lang/funcs"
|
||||
"github.com/purpleidea/mgmt/lang/interfaces"
|
||||
"github.com/purpleidea/mgmt/util/errwrap"
|
||||
|
||||
"github.com/hashicorp/hil"
|
||||
hilast "github.com/hashicorp/hil/ast"
|
||||
)
|
||||
|
||||
const (
|
||||
// UseHilInterpolation specifies that we use the legacy Hil interpolate.
|
||||
// This can't properly escape a $ in the standard way. It's here in case
|
||||
// someone wants to play with it and examine how the AST stuff worked...
|
||||
UseHilInterpolation = false
|
||||
)
|
||||
|
||||
// InterpolateStr interpolates a string and returns the representative AST.
|
||||
func InterpolateStr(str string, pos *interfaces.Pos, data *interfaces.Data) (interfaces.Expr, error) {
|
||||
if data.Debug {
|
||||
data.Logf("interpolating: %s", str)
|
||||
}
|
||||
|
||||
if UseHilInterpolation {
|
||||
return InterpolateHil(str, pos, data)
|
||||
}
|
||||
return InterpolateRagel(str, pos, data)
|
||||
}
|
||||
|
||||
// InterpolateRagel interpolates a string and returns the representative AST. It
|
||||
// uses the ragel parser to perform the string interpolation.
|
||||
func InterpolateRagel(str string, pos *interfaces.Pos, data *interfaces.Data) (interfaces.Expr, error) {
|
||||
sequence, err := Parse(str)
|
||||
if err != nil {
|
||||
return nil, errwrap.Wrapf(err, "parser failed")
|
||||
}
|
||||
|
||||
exprs := []interfaces.Expr{}
|
||||
for _, term := range sequence {
|
||||
|
||||
switch t := term.(type) {
|
||||
case Literal:
|
||||
expr := &ast.ExprStr{
|
||||
V: t.Value,
|
||||
}
|
||||
exprs = append(exprs, expr)
|
||||
|
||||
case Variable:
|
||||
expr := &ast.ExprVar{
|
||||
Name: t.Name,
|
||||
}
|
||||
exprs = append(exprs, expr)
|
||||
default:
|
||||
return nil, fmt.Errorf("unknown term (%T): %+v", t, t)
|
||||
}
|
||||
}
|
||||
|
||||
// If we didn't find anything of value, we got an empty string...
|
||||
if len(sequence) == 0 && str == "" { // be doubly sure...
|
||||
expr := &ast.ExprStr{
|
||||
V: "",
|
||||
}
|
||||
exprs = append(exprs, expr)
|
||||
}
|
||||
|
||||
// The parser produces non-optimal results where two strings are next to
|
||||
// each other, when they could be statically combined together.
|
||||
simplified, err := simplifyExprList(exprs)
|
||||
if err != nil {
|
||||
return nil, errwrap.Wrapf(err, "expr list simplify failed")
|
||||
}
|
||||
|
||||
result, err := concatExprListIntoCall(simplified)
|
||||
if err != nil {
|
||||
return nil, errwrap.Wrapf(err, "concat expr list failed")
|
||||
}
|
||||
|
||||
return result, errwrap.Wrapf(result.Init(data), "init failed")
|
||||
}
|
||||
|
||||
// InterpolateHil interpolates a string and returns the representative AST. This
|
||||
// particular implementation uses the hashicorp hil library and syntax to do so.
|
||||
func InterpolateHil(str string, pos *interfaces.Pos, data *interfaces.Data) (interfaces.Expr, error) {
|
||||
var line, column int = -1, -1
|
||||
var filename string
|
||||
if pos != nil {
|
||||
line = pos.Line
|
||||
column = pos.Column
|
||||
filename = pos.Filename
|
||||
}
|
||||
hilPos := hilast.Pos{
|
||||
Line: line,
|
||||
Column: column,
|
||||
Filename: filename,
|
||||
}
|
||||
// should not error on plain strings
|
||||
tree, err := hil.ParseWithPosition(str, hilPos)
|
||||
if err != nil {
|
||||
return nil, errwrap.Wrapf(err, "can't parse string interpolation: `%s`", str)
|
||||
}
|
||||
if data.Debug {
|
||||
data.Logf("tree: %+v", tree)
|
||||
}
|
||||
|
||||
transformData := &interfaces.Data{
|
||||
// TODO: add missing fields here if/when needed
|
||||
Fs: data.Fs,
|
||||
FsURI: data.FsURI,
|
||||
Base: data.Base,
|
||||
Files: data.Files,
|
||||
Imports: data.Imports,
|
||||
Metadata: data.Metadata,
|
||||
Modules: data.Modules,
|
||||
|
||||
LexParser: data.LexParser,
|
||||
Downloader: data.Downloader,
|
||||
StrInterpolater: data.StrInterpolater,
|
||||
//World: data.World, // TODO: do we need this?
|
||||
|
||||
Prefix: data.Prefix,
|
||||
Debug: data.Debug,
|
||||
Logf: func(format string, v ...interface{}) {
|
||||
data.Logf("transform: "+format, v...)
|
||||
},
|
||||
}
|
||||
result, err := hilTransform(tree, transformData)
|
||||
if err != nil {
|
||||
return nil, errwrap.Wrapf(err, "error running AST map: `%s`", str)
|
||||
}
|
||||
if data.Debug {
|
||||
data.Logf("transform: %+v", result)
|
||||
}
|
||||
|
||||
// make sure to run the Init on the new expression
|
||||
return result, errwrap.Wrapf(result.Init(data), "init failed")
|
||||
}
|
||||
|
||||
// hilTransform returns the AST equivalent of the hil AST.
|
||||
func hilTransform(root hilast.Node, data *interfaces.Data) (interfaces.Expr, error) {
|
||||
switch node := root.(type) {
|
||||
case *hilast.Output: // common root node
|
||||
if data.Debug {
|
||||
data.Logf("got output type: %+v", node)
|
||||
}
|
||||
|
||||
if len(node.Exprs) == 0 {
|
||||
return nil, fmt.Errorf("no expressions found")
|
||||
}
|
||||
if len(node.Exprs) == 1 {
|
||||
return hilTransform(node.Exprs[0], data)
|
||||
}
|
||||
|
||||
// assumes len > 1
|
||||
args := []interfaces.Expr{}
|
||||
for _, n := range node.Exprs {
|
||||
expr, err := hilTransform(n, data)
|
||||
if err != nil {
|
||||
return nil, errwrap.Wrapf(err, "root failed")
|
||||
}
|
||||
args = append(args, expr)
|
||||
}
|
||||
|
||||
// XXX: i think we should be adding these args together, instead
|
||||
// of grouping for example...
|
||||
result, err := concatExprListIntoCall(args)
|
||||
if err != nil {
|
||||
return nil, errwrap.Wrapf(err, "function grouping failed")
|
||||
}
|
||||
return result, nil
|
||||
|
||||
case *hilast.Call:
|
||||
if data.Debug {
|
||||
data.Logf("got function type: %+v", node)
|
||||
}
|
||||
args := []interfaces.Expr{}
|
||||
for _, n := range node.Args {
|
||||
arg, err := hilTransform(n, data)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("call failed: %+v", err)
|
||||
}
|
||||
args = append(args, arg)
|
||||
}
|
||||
|
||||
return &ast.ExprCall{
|
||||
Name: node.Func, // name
|
||||
Args: args,
|
||||
}, nil
|
||||
|
||||
case *hilast.LiteralNode: // string, int, etc...
|
||||
if data.Debug {
|
||||
data.Logf("got literal type: %+v", node)
|
||||
}
|
||||
|
||||
switch node.Typex {
|
||||
case hilast.TypeBool:
|
||||
return &ast.ExprBool{
|
||||
V: node.Value.(bool),
|
||||
}, nil
|
||||
|
||||
case hilast.TypeString:
|
||||
return &ast.ExprStr{
|
||||
V: node.Value.(string),
|
||||
}, nil
|
||||
|
||||
case hilast.TypeInt:
|
||||
return &ast.ExprInt{
|
||||
// node.Value is an int stored as an interface
|
||||
V: int64(node.Value.(int)),
|
||||
}, nil
|
||||
|
||||
case hilast.TypeFloat:
|
||||
return &ast.ExprFloat{
|
||||
V: node.Value.(float64),
|
||||
}, nil
|
||||
|
||||
// TODO: should we handle these too?
|
||||
//case hilast.TypeList:
|
||||
//case hilast.TypeMap:
|
||||
|
||||
default:
|
||||
return nil, fmt.Errorf("unmatched type: %T", node)
|
||||
}
|
||||
|
||||
case *hilast.VariableAccess: // variable lookup
|
||||
if data.Debug {
|
||||
data.Logf("got variable access type: %+v", node)
|
||||
}
|
||||
return &ast.ExprVar{
|
||||
Name: node.Name,
|
||||
}, nil
|
||||
|
||||
//case *hilast.Index:
|
||||
// if va, ok := node.Target.(*hilast.VariableAccess); ok {
|
||||
// v, err := NewInterpolatedVariable(va.Name)
|
||||
// if err != nil {
|
||||
// resultErr = err
|
||||
// return n
|
||||
// }
|
||||
// result = append(result, v)
|
||||
// }
|
||||
// if va, ok := node.Key.(*hilast.VariableAccess); ok {
|
||||
// v, err := NewInterpolatedVariable(va.Name)
|
||||
// if err != nil {
|
||||
// resultErr = err
|
||||
// return n
|
||||
// }
|
||||
// result = append(result, v)
|
||||
// }
|
||||
|
||||
default:
|
||||
return nil, fmt.Errorf("unmatched type: %+v", node)
|
||||
}
|
||||
}
|
||||
|
||||
// concatExprListIntoCall takes a list of expressions, and combines them into an
|
||||
// expression which ultimately concatenates them all together with a + operator.
|
||||
// TODO: this assumes they're all strings, do we need to watch out for int's?
|
||||
func concatExprListIntoCall(exprs []interfaces.Expr) (interfaces.Expr, error) {
|
||||
if len(exprs) == 0 {
|
||||
return nil, fmt.Errorf("empty list")
|
||||
}
|
||||
|
||||
operator := &ast.ExprStr{
|
||||
V: "+", // for PLUS this is a `+` character
|
||||
}
|
||||
|
||||
if len(exprs) == 1 {
|
||||
return exprs[0], nil // just return self
|
||||
}
|
||||
//if len(exprs) == 1 {
|
||||
// arg := exprs[0]
|
||||
// emptyStr := &ast.ExprStr{
|
||||
// V: "", // empty str
|
||||
// }
|
||||
// return &ast.ExprCall{
|
||||
// Name: funcs.OperatorFuncName, // concatenate the two strings with + operator
|
||||
// Args: []interfaces.Expr{
|
||||
// operator, // operator first
|
||||
// arg, // string arg
|
||||
// emptyStr,
|
||||
// },
|
||||
// }, nil
|
||||
//}
|
||||
|
||||
head, tail := exprs[0], exprs[1:]
|
||||
|
||||
grouped, err := concatExprListIntoCall(tail)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
return &ast.ExprCall{
|
||||
// NOTE: if we don't set the data field we need Init() called on it!
|
||||
Name: funcs.OperatorFuncName, // concatenate the two strings with + operator
|
||||
Args: []interfaces.Expr{
|
||||
operator, // operator first
|
||||
head, // string arg
|
||||
grouped, // nested function call which returns a string
|
||||
},
|
||||
}, nil
|
||||
}
|
||||
|
||||
// simplifyExprList takes a list of *ExprStr and *ExprVar and groups the
|
||||
// sequential *ExprStr's together. If you pass it a list of Expr's that contains
|
||||
// a different type of Expr, then this will error.
|
||||
func simplifyExprList(exprs []interfaces.Expr) ([]interfaces.Expr, error) {
|
||||
last := false
|
||||
result := []interfaces.Expr{}
|
||||
|
||||
for _, x := range exprs {
|
||||
switch v := x.(type) {
|
||||
case *ast.ExprStr:
|
||||
if !last {
|
||||
last = true
|
||||
result = append(result, x)
|
||||
continue
|
||||
}
|
||||
|
||||
// combine!
|
||||
expr := result[len(result)-1] // there has to be at least one
|
||||
str, ok := expr.(*ast.ExprStr)
|
||||
if !ok {
|
||||
// programming error
|
||||
return nil, fmt.Errorf("unexpected type (%T)", expr)
|
||||
}
|
||||
str.V += v.V // combine!
|
||||
//last = true // redundant, it's already true
|
||||
// ... and don't append, we've combined!
|
||||
|
||||
case *ast.ExprVar:
|
||||
last = false // the next one can't combine with me
|
||||
result = append(result, x)
|
||||
|
||||
default:
|
||||
return nil, fmt.Errorf("unsupported type (%T)", x)
|
||||
}
|
||||
}
|
||||
|
||||
return result, nil
|
||||
}
|
||||
850
lang/interpolate/interpolate_test.go
Normal file
850
lang/interpolate/interpolate_test.go
Normal file
@@ -0,0 +1,850 @@
|
||||
// Mgmt
|
||||
// Copyright (C) 2013-2021+ James Shubin and the project contributors
|
||||
// Written by James Shubin <james@shubin.ca> and the project contributors
|
||||
//
|
||||
// This program is free software: you can redistribute it and/or modify
|
||||
// it under the terms of the GNU General Public License as published by
|
||||
// the Free Software Foundation, either version 3 of the License, or
|
||||
// (at your option) any later version.
|
||||
//
|
||||
// This program is distributed in the hope that it will be useful,
|
||||
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
// GNU General Public License for more details.
|
||||
//
|
||||
// You should have received a copy of the GNU General Public License
|
||||
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
// +build !root
|
||||
|
||||
package interpolate
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"reflect"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/purpleidea/mgmt/lang/ast"
|
||||
"github.com/purpleidea/mgmt/lang/funcs"
|
||||
"github.com/purpleidea/mgmt/lang/interfaces"
|
||||
"github.com/purpleidea/mgmt/lang/parser"
|
||||
"github.com/purpleidea/mgmt/util"
|
||||
|
||||
"github.com/davecgh/go-spew/spew"
|
||||
"github.com/kylelemons/godebug/pretty"
|
||||
"github.com/sanity-io/litter"
|
||||
)
|
||||
|
||||
func TestInterpolate0(t *testing.T) {
|
||||
type test struct { // an individual test
|
||||
name string
|
||||
code string
|
||||
fail bool
|
||||
ast interfaces.Stmt
|
||||
}
|
||||
testCases := []test{}
|
||||
// NOTE: to run an individual test, first run: `go test -v` to list the
|
||||
// names, and then run `go test -run <pattern>` with the name(s) to run.
|
||||
|
||||
{
|
||||
xast := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{},
|
||||
}
|
||||
testCases = append(testCases, test{ // 0
|
||||
"nil",
|
||||
``,
|
||||
false,
|
||||
xast,
|
||||
})
|
||||
}
|
||||
{
|
||||
xast := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{
|
||||
&ast.StmtRes{
|
||||
Kind: "test",
|
||||
Name: &ast.ExprStr{
|
||||
V: "t1",
|
||||
},
|
||||
Contents: []ast.StmtResContents{
|
||||
&ast.StmtResField{
|
||||
Field: "stringptr",
|
||||
Value: &ast.ExprStr{
|
||||
V: "foo",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
testCases = append(testCases, test{
|
||||
name: "basic string",
|
||||
code: `
|
||||
test "t1" {
|
||||
stringptr => "foo",
|
||||
}
|
||||
`,
|
||||
fail: false,
|
||||
ast: xast,
|
||||
})
|
||||
}
|
||||
{
|
||||
fieldName := &ast.ExprCall{
|
||||
Name: funcs.OperatorFuncName,
|
||||
Args: []interfaces.Expr{
|
||||
&ast.ExprStr{
|
||||
V: "+",
|
||||
},
|
||||
&ast.ExprStr{
|
||||
V: "foo-",
|
||||
},
|
||||
&ast.ExprVar{
|
||||
Name: "x",
|
||||
},
|
||||
},
|
||||
}
|
||||
xast := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{
|
||||
&ast.StmtRes{
|
||||
Kind: "test",
|
||||
Name: &ast.ExprStr{
|
||||
V: "t1",
|
||||
},
|
||||
Contents: []ast.StmtResContents{
|
||||
&ast.StmtResField{
|
||||
Field: "stringptr",
|
||||
Value: fieldName,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
testCases = append(testCases, test{
|
||||
name: "basic expansion",
|
||||
code: `
|
||||
#$x = "hello" # not actually needed to test interpolation
|
||||
test "t1" {
|
||||
stringptr => "foo-${x}",
|
||||
}
|
||||
`,
|
||||
fail: false,
|
||||
ast: xast,
|
||||
})
|
||||
}
|
||||
{
|
||||
xast := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{
|
||||
&ast.StmtRes{
|
||||
Kind: "test",
|
||||
Name: &ast.ExprStr{
|
||||
V: "t1",
|
||||
},
|
||||
Contents: []ast.StmtResContents{
|
||||
&ast.StmtResField{
|
||||
Field: "stringptr",
|
||||
Value: &ast.ExprStr{
|
||||
V: "${hello}",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
testCases = append(testCases, test{
|
||||
name: "variable escaping 1",
|
||||
code: `
|
||||
test "t1" {
|
||||
stringptr => "\${hello}",
|
||||
}
|
||||
`,
|
||||
fail: false,
|
||||
ast: xast,
|
||||
})
|
||||
}
|
||||
{
|
||||
xast := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{
|
||||
&ast.StmtRes{
|
||||
Kind: "test",
|
||||
Name: &ast.ExprStr{
|
||||
V: "t1",
|
||||
},
|
||||
Contents: []ast.StmtResContents{
|
||||
&ast.StmtResField{
|
||||
Field: "stringptr",
|
||||
Value: &ast.ExprStr{
|
||||
V: `\` + `$` + `{hello}`,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
testCases = append(testCases, test{
|
||||
name: "variable escaping 2",
|
||||
code: `
|
||||
test "t1" {
|
||||
stringptr => "` + `\\` + `\$` + "{hello}" + `",
|
||||
}
|
||||
`,
|
||||
fail: false,
|
||||
ast: xast,
|
||||
})
|
||||
}
|
||||
|
||||
names := []string{}
|
||||
for index, tc := range testCases { // run all the tests
|
||||
if tc.name == "" {
|
||||
t.Errorf("test #%d: not named", index)
|
||||
continue
|
||||
}
|
||||
if util.StrInList(tc.name, names) {
|
||||
t.Errorf("test #%d: duplicate sub test name of: %s", index, tc.name)
|
||||
continue
|
||||
}
|
||||
names = append(names, tc.name)
|
||||
t.Run(fmt.Sprintf("test #%d (%s)", index, tc.name), func(t *testing.T) {
|
||||
code, fail, exp := tc.code, tc.fail, tc.ast
|
||||
|
||||
str := strings.NewReader(code)
|
||||
ast, err := parser.LexParse(str)
|
||||
if err != nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: lex/parse failed with: %+v", index, err)
|
||||
return
|
||||
}
|
||||
t.Logf("test #%d: AST: %+v", index, ast)
|
||||
|
||||
data := &interfaces.Data{
|
||||
// TODO: add missing fields here if/when needed
|
||||
StrInterpolater: InterpolateStr,
|
||||
|
||||
Debug: testing.Verbose(), // set via the -test.v flag to `go test`
|
||||
Logf: func(format string, v ...interface{}) {
|
||||
t.Logf("ast: "+format, v...)
|
||||
},
|
||||
}
|
||||
// some of this might happen *after* interpolate in SetScope or Unify...
|
||||
if err := ast.Init(data); err != nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: could not init and validate AST: %+v", index, err)
|
||||
return
|
||||
}
|
||||
|
||||
iast, err := ast.Interpolate()
|
||||
if !fail && err != nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: interpolate failed with: %+v", index, err)
|
||||
return
|
||||
}
|
||||
if fail && err == nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: interpolate expected error, not nil", index)
|
||||
return
|
||||
}
|
||||
|
||||
// init exp so that the match will look identical...
|
||||
if !fail {
|
||||
if err := exp.Init(data); err != nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: match init failed with: %+v", index, err)
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
if reflect.DeepEqual(iast, exp) {
|
||||
return
|
||||
}
|
||||
// double check because DeepEqual is different since the logf exists
|
||||
lo := &litter.Options{
|
||||
//Compact: false,
|
||||
StripPackageNames: true,
|
||||
HidePrivateFields: true,
|
||||
HideZeroValues: true,
|
||||
//FieldExclusions: regexp.MustCompile(`^(data)$`),
|
||||
//FieldFilter func(reflect.StructField, reflect.Value) bool
|
||||
//HomePackage string
|
||||
//Separator string
|
||||
}
|
||||
if lo.Sdump(iast) == lo.Sdump(exp) { // simple diff
|
||||
return
|
||||
}
|
||||
|
||||
diff := pretty.Compare(iast, exp)
|
||||
if diff == "" { // bonus
|
||||
return
|
||||
}
|
||||
t.Errorf("test #%d: AST did not match expected", index)
|
||||
// TODO: consider making our own recursive print function
|
||||
t.Logf("test #%d: actual: \n%s", index, lo.Sdump(iast))
|
||||
t.Logf("test #%d: expected: \n%s", index, lo.Sdump(exp))
|
||||
t.Logf("test #%d: diff:\n%s", index, diff)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestInterpolateBasicStmt(t *testing.T) {
|
||||
type test struct { // an individual test
|
||||
name string
|
||||
ast interfaces.Stmt
|
||||
fail bool
|
||||
exp interfaces.Stmt
|
||||
}
|
||||
testCases := []test{}
|
||||
|
||||
// this causes a panic, so it can't be used
|
||||
//{
|
||||
// testCases = append(testCases, test{
|
||||
// "nil",
|
||||
// nil,
|
||||
// false,
|
||||
// nil,
|
||||
// })
|
||||
//}
|
||||
{
|
||||
xast := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{
|
||||
&ast.StmtRes{
|
||||
Kind: "test",
|
||||
Name: &ast.ExprStr{
|
||||
V: "t1",
|
||||
},
|
||||
Contents: []ast.StmtResContents{
|
||||
&ast.StmtResField{
|
||||
Field: "stringptr",
|
||||
Value: &ast.ExprStr{
|
||||
V: "foo",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
exp := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{
|
||||
&ast.StmtRes{
|
||||
Kind: "test",
|
||||
Name: &ast.ExprStr{
|
||||
V: "t1",
|
||||
},
|
||||
Contents: []ast.StmtResContents{
|
||||
&ast.StmtResField{
|
||||
Field: "stringptr",
|
||||
Value: &ast.ExprStr{
|
||||
V: "foo",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
testCases = append(testCases, test{
|
||||
name: "basic resource",
|
||||
ast: xast,
|
||||
fail: false,
|
||||
exp: exp,
|
||||
})
|
||||
}
|
||||
{
|
||||
xast := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{
|
||||
&ast.StmtRes{
|
||||
Kind: "test",
|
||||
Name: &ast.ExprStr{
|
||||
V: "t${blah}",
|
||||
},
|
||||
Contents: []ast.StmtResContents{
|
||||
&ast.StmtResField{
|
||||
Field: "stringptr",
|
||||
Value: &ast.ExprStr{
|
||||
V: "foo",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
resName := &ast.ExprCall{
|
||||
Name: funcs.OperatorFuncName,
|
||||
Args: []interfaces.Expr{
|
||||
&ast.ExprStr{
|
||||
V: "+",
|
||||
},
|
||||
&ast.ExprStr{
|
||||
V: "t",
|
||||
},
|
||||
&ast.ExprVar{
|
||||
Name: "blah",
|
||||
},
|
||||
},
|
||||
}
|
||||
exp := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{
|
||||
&ast.StmtRes{
|
||||
Kind: "test",
|
||||
Name: resName,
|
||||
Contents: []ast.StmtResContents{
|
||||
&ast.StmtResField{
|
||||
Field: "stringptr",
|
||||
Value: &ast.ExprStr{
|
||||
V: "foo",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
testCases = append(testCases, test{
|
||||
name: "expanded resource",
|
||||
ast: xast,
|
||||
fail: false,
|
||||
exp: exp,
|
||||
})
|
||||
}
|
||||
{
|
||||
xast := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{
|
||||
&ast.StmtRes{
|
||||
Kind: "test",
|
||||
Name: &ast.ExprStr{
|
||||
V: "t${42}", // incorrect type
|
||||
},
|
||||
Contents: []ast.StmtResContents{
|
||||
&ast.StmtResField{
|
||||
Field: "stringptr",
|
||||
Value: &ast.ExprStr{
|
||||
V: "foo",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
resName := &ast.ExprCall{
|
||||
Name: funcs.OperatorFuncName,
|
||||
// incorrect sig for this function, and now invalid interpolation
|
||||
Args: []interfaces.Expr{
|
||||
&ast.ExprStr{
|
||||
V: "+",
|
||||
},
|
||||
&ast.ExprStr{
|
||||
V: "t",
|
||||
},
|
||||
&ast.ExprInt{
|
||||
V: 42,
|
||||
},
|
||||
},
|
||||
}
|
||||
exp := &ast.StmtProg{
|
||||
Body: []interfaces.Stmt{
|
||||
&ast.StmtRes{
|
||||
Kind: "test",
|
||||
Name: resName,
|
||||
Contents: []ast.StmtResContents{
|
||||
&ast.StmtResField{
|
||||
Field: "stringptr",
|
||||
Value: &ast.ExprStr{
|
||||
V: "foo",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
_ = exp // historical
|
||||
testCases = append(testCases, test{
|
||||
name: "expanded invalid resource name",
|
||||
ast: xast,
|
||||
fail: true,
|
||||
//exp: exp,
|
||||
})
|
||||
}
|
||||
|
||||
names := []string{}
|
||||
for index, tc := range testCases { // run all the tests
|
||||
if util.StrInList(tc.name, names) {
|
||||
t.Errorf("test #%d: duplicate sub test name of: %s", index, tc.name)
|
||||
continue
|
||||
}
|
||||
names = append(names, tc.name)
|
||||
t.Run(fmt.Sprintf("test #%d (%s)", index, tc.name), func(t *testing.T) {
|
||||
ast, fail, exp := tc.ast, tc.fail, tc.exp
|
||||
|
||||
data := &interfaces.Data{
|
||||
// TODO: add missing fields here if/when needed
|
||||
StrInterpolater: InterpolateStr,
|
||||
|
||||
Debug: testing.Verbose(), // set via the -test.v flag to `go test`
|
||||
Logf: func(format string, v ...interface{}) {
|
||||
t.Logf("ast: "+format, v...)
|
||||
},
|
||||
}
|
||||
// some of this might happen *after* interpolate in SetScope or Unify...
|
||||
if err := ast.Init(data); err != nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: could not init and validate AST: %+v", index, err)
|
||||
return
|
||||
}
|
||||
|
||||
iast, err := ast.Interpolate()
|
||||
if !fail && err != nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: interpolate failed with: %+v", index, err)
|
||||
return
|
||||
}
|
||||
if fail && err == nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: interpolate expected error, not nil", index)
|
||||
return
|
||||
}
|
||||
|
||||
// init exp so that the match will look identical...
|
||||
if !fail {
|
||||
if err := exp.Init(data); err != nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: match init failed with: %+v", index, err)
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
if reflect.DeepEqual(iast, exp) {
|
||||
return
|
||||
}
|
||||
// double check because DeepEqual is different since the logf exists
|
||||
diff := pretty.Compare(iast, exp)
|
||||
if diff == "" { // bonus
|
||||
return
|
||||
}
|
||||
t.Errorf("test #%d: AST did not match expected", index)
|
||||
// TODO: consider making our own recursive print function
|
||||
t.Logf("test #%d: actual: \n%s", index, spew.Sdump(iast))
|
||||
t.Logf("test #%d: expected: \n%s", index, spew.Sdump(exp))
|
||||
t.Logf("test #%d: diff:\n%s", index, diff)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestInterpolateBasicExpr(t *testing.T) {
|
||||
type test struct { // an individual test
|
||||
name string
|
||||
ast interfaces.Expr
|
||||
fail bool
|
||||
exp interfaces.Expr
|
||||
}
|
||||
testCases := []test{}
|
||||
|
||||
// this causes a panic, so it can't be used
|
||||
//{
|
||||
// testCases = append(testCases, test{
|
||||
// "nil",
|
||||
// nil,
|
||||
// false,
|
||||
// nil,
|
||||
// })
|
||||
//}
|
||||
{
|
||||
xast := &ast.ExprStr{
|
||||
V: "hello",
|
||||
}
|
||||
exp := &ast.ExprStr{
|
||||
V: "hello",
|
||||
}
|
||||
testCases = append(testCases, test{
|
||||
name: "basic string",
|
||||
ast: xast,
|
||||
fail: false,
|
||||
exp: exp,
|
||||
})
|
||||
}
|
||||
{
|
||||
xast := &ast.ExprStr{
|
||||
V: "hello ${person_name}",
|
||||
}
|
||||
exp := &ast.ExprCall{
|
||||
Name: funcs.OperatorFuncName,
|
||||
Args: []interfaces.Expr{
|
||||
&ast.ExprStr{
|
||||
V: "+",
|
||||
},
|
||||
&ast.ExprStr{
|
||||
V: "hello ",
|
||||
},
|
||||
&ast.ExprVar{
|
||||
Name: "person_name",
|
||||
},
|
||||
},
|
||||
}
|
||||
testCases = append(testCases, test{
|
||||
name: "basic expansion",
|
||||
ast: xast,
|
||||
fail: false,
|
||||
exp: exp,
|
||||
})
|
||||
}
|
||||
{
|
||||
xast := &ast.ExprStr{
|
||||
V: "hello ${x ${y} z}",
|
||||
}
|
||||
testCases = append(testCases, test{
|
||||
name: "invalid expansion",
|
||||
ast: xast,
|
||||
fail: true,
|
||||
})
|
||||
}
|
||||
// TODO: patterns like what are shown below are supported by the `hil`
|
||||
// library, but are not yet supported by our translation layer, nor do
|
||||
// they necessarily work or make much sense at this point in time...
|
||||
//{
|
||||
// xast := &ast.ExprStr{
|
||||
// V: `hello ${func("hello ${var.foo}")}`,
|
||||
// }
|
||||
// exp := nil // TODO: add this
|
||||
// testCases = append(testCases, test{
|
||||
// name: "double expansion",
|
||||
// ast: xast,
|
||||
// fail: false,
|
||||
// exp: exp,
|
||||
// })
|
||||
//}
|
||||
{
|
||||
xast := &ast.ExprStr{
|
||||
V: "sweetie${3.14159}", // invalid
|
||||
}
|
||||
exp := &ast.ExprCall{
|
||||
Name: funcs.OperatorFuncName,
|
||||
Args: []interfaces.Expr{
|
||||
&ast.ExprStr{
|
||||
V: "+",
|
||||
},
|
||||
&ast.ExprStr{
|
||||
V: "sweetie",
|
||||
},
|
||||
&ast.ExprFloat{
|
||||
V: 3.14159,
|
||||
},
|
||||
},
|
||||
}
|
||||
_ = exp // historical
|
||||
testCases = append(testCases, test{
|
||||
name: "float expansion",
|
||||
ast: xast,
|
||||
fail: true,
|
||||
})
|
||||
}
|
||||
{
|
||||
xast := &ast.ExprStr{
|
||||
V: "i am: ${sys.hostname()}",
|
||||
}
|
||||
exp := &ast.ExprCall{
|
||||
Name: funcs.OperatorFuncName,
|
||||
Args: []interfaces.Expr{
|
||||
&ast.ExprStr{
|
||||
V: "+",
|
||||
},
|
||||
&ast.ExprStr{
|
||||
V: "i am: ",
|
||||
},
|
||||
&ast.ExprCall{
|
||||
Name: "sys.hostname",
|
||||
Args: []interfaces.Expr{},
|
||||
},
|
||||
},
|
||||
}
|
||||
_ = exp // historical
|
||||
testCases = append(testCases, test{
|
||||
name: "function expansion",
|
||||
ast: xast,
|
||||
fail: true,
|
||||
})
|
||||
}
|
||||
{
|
||||
xast := &ast.ExprStr{
|
||||
V: "i am: ${blah(21, 12.3)}",
|
||||
}
|
||||
exp := &ast.ExprCall{
|
||||
Name: funcs.OperatorFuncName,
|
||||
Args: []interfaces.Expr{
|
||||
&ast.ExprStr{
|
||||
V: "+",
|
||||
},
|
||||
&ast.ExprStr{
|
||||
V: "i am: ",
|
||||
},
|
||||
&ast.ExprCall{
|
||||
Name: "blah",
|
||||
Args: []interfaces.Expr{
|
||||
&ast.ExprInt{
|
||||
V: 21,
|
||||
},
|
||||
&ast.ExprFloat{
|
||||
V: 12.3,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
_ = exp // historical
|
||||
testCases = append(testCases, test{
|
||||
name: "function expansion arg",
|
||||
ast: xast,
|
||||
fail: true,
|
||||
})
|
||||
}
|
||||
// FIXME: i am broken, i don't deal well with negatives for some reason
|
||||
//{
|
||||
// xast := &ast.ExprStr{
|
||||
// V: "i am: ${blah(21, -12.3)}",
|
||||
// }
|
||||
// exp := &ast.ExprCall{
|
||||
// Name: funcs.OperatorFuncName,
|
||||
// Args: []interfaces.Expr{
|
||||
// &ast.ExprStr{
|
||||
// V: "+",
|
||||
// },
|
||||
// &ast.ExprStr{
|
||||
// V: "i am: ",
|
||||
// },
|
||||
// &ast.ExprCall{
|
||||
// Name: "blah",
|
||||
// Args: []interfaces.Expr{
|
||||
// &ast.ExprInt{
|
||||
// V: 21,
|
||||
// },
|
||||
// &ast.ExprFloat{
|
||||
// V: -12.3,
|
||||
// },
|
||||
// },
|
||||
// },
|
||||
// },
|
||||
// }
|
||||
// testCases = append(testCases, test{
|
||||
// name: "function expansion arg negative",
|
||||
// ast: xast,
|
||||
// fail: false,
|
||||
// exp: exp,
|
||||
// })
|
||||
//}
|
||||
// FIXME: i am broken :(
|
||||
//{
|
||||
// xast := &ast.ExprStr{
|
||||
// V: "sweetie${-3.14159}", // FIXME: only the negative breaks this
|
||||
// }
|
||||
// exp := &ast.ExprCall{
|
||||
// Name: funcs.OperatorFuncName,
|
||||
// Args: []interfaces.Expr{
|
||||
// &ast.ExprStr{
|
||||
// V: "+",
|
||||
// },
|
||||
// &ast.ExprStr{
|
||||
// V: "sweetie",
|
||||
// },
|
||||
// &ast.ExprFloat{
|
||||
// V: -3.14159,
|
||||
// },
|
||||
// },
|
||||
// }
|
||||
// testCases = append(testCases, test{
|
||||
// name: "negative float expansion",
|
||||
// ast: xast,
|
||||
// fail: false,
|
||||
// exp: exp,
|
||||
// })
|
||||
//}
|
||||
// FIXME: i am also broken, but less important
|
||||
//{
|
||||
// xast := &ast.ExprStr{
|
||||
// V: `i am: ${blah(42, "${foo}")}`,
|
||||
// }
|
||||
// exp := &ast.ExprCall{
|
||||
// Name: funcs.OperatorFuncName,
|
||||
// Args: []interfaces.Expr{
|
||||
// &ast.ExprStr{
|
||||
// V: "+",
|
||||
// },
|
||||
// &ast.ExprStr{
|
||||
// V: "i am: ",
|
||||
// },
|
||||
// &ast.ExprCall{
|
||||
// Name: "blah",
|
||||
// Args: []interfaces.Expr{
|
||||
// &ast.ExprInt{
|
||||
// V: 42,
|
||||
// },
|
||||
// &ast.ExprVar{
|
||||
// Name: "foo",
|
||||
// },
|
||||
// },
|
||||
// },
|
||||
// },
|
||||
// }
|
||||
// testCases = append(testCases, test{
|
||||
// name: "function expansion arg with var",
|
||||
// ast: xast,
|
||||
// fail: false,
|
||||
// exp: exp,
|
||||
// })
|
||||
//}
|
||||
|
||||
names := []string{}
|
||||
for index, tc := range testCases { // run all the tests
|
||||
if util.StrInList(tc.name, names) {
|
||||
t.Errorf("test #%d: duplicate sub test name of: %s", index, tc.name)
|
||||
continue
|
||||
}
|
||||
names = append(names, tc.name)
|
||||
t.Run(fmt.Sprintf("test #%d (%s)", index, tc.name), func(t *testing.T) {
|
||||
ast, fail, exp := tc.ast, tc.fail, tc.exp
|
||||
|
||||
data := &interfaces.Data{
|
||||
// TODO: add missing fields here if/when needed
|
||||
StrInterpolater: InterpolateStr,
|
||||
|
||||
Debug: testing.Verbose(), // set via the -test.v flag to `go test`
|
||||
Logf: func(format string, v ...interface{}) {
|
||||
t.Logf("ast: "+format, v...)
|
||||
},
|
||||
}
|
||||
// some of this might happen *after* interpolate in SetScope or Unify...
|
||||
if err := ast.Init(data); err != nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: could not init and validate AST: %+v", index, err)
|
||||
return
|
||||
}
|
||||
|
||||
iast, err := ast.Interpolate()
|
||||
if !fail && err != nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: interpolate failed with: %+v", index, err)
|
||||
return
|
||||
}
|
||||
if fail && err == nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: interpolate expected error, not nil", index)
|
||||
return
|
||||
}
|
||||
|
||||
// init exp so that the match will look identical...
|
||||
if !fail {
|
||||
if err := exp.Init(data); err != nil {
|
||||
t.Errorf("test #%d: FAIL", index)
|
||||
t.Errorf("test #%d: match init failed with: %+v", index, err)
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
if reflect.DeepEqual(iast, exp) {
|
||||
return
|
||||
}
|
||||
// double check because DeepEqual is different since the logf exists
|
||||
diff := pretty.Compare(iast, exp)
|
||||
if diff == "" { // bonus
|
||||
return
|
||||
}
|
||||
t.Errorf("test #%d: AST did not match expected", index)
|
||||
// TODO: consider making our own recursive print function
|
||||
t.Logf("test #%d: actual: \n%s", index, spew.Sdump(iast))
|
||||
t.Logf("test #%d: expected: \n%s", index, spew.Sdump(exp))
|
||||
t.Logf("test #%d: diff:\n%s", index, diff)
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user