test: Improve golang tests with root and disabling cache

This allows golang tests to be marked as root or !root using build tags.
The matching tests are then run as expected using our test runner.

This also disables test caching which is unfriendly to repeated test
running and is an absurd golang default to add.

Lastly this hooks up the testing verbose flag to tests that accept a
debug variable.

These tests aren't enabled on travis yet because of how it installs
golang.

engine/autoedge_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package engine
 
 import (

engine/graph/autogroup/autogroup_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package autogroup
 
 import (

engine/graph/semaphore_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package graph
 
 import (

engine/metaparams_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package engine
 
 import (

engine/resources/exec_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package resources
 
 import (

engine/resources/file_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package resources
 
 import (

engine/resources/mount_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package resources
 
 import (

engine/resources/msg_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package resources
 
 import (

engine/resources/noop_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package resources
 
 import (

engine/resources/pkg_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package resources
 
 import (

engine/resources/test_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package resources
 
 import (

engine/util/util_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package util
 
 import (

etcd/etcd_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package etcd
 
 import (

etcd/fs/fs_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package fs_test // named this way to make it easier for examples
 
 import (

integration/basic_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package integration
 
 import (

integration/util_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package integration
 
 import (

lang/funcs/facts/func_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package facts
 
 import (

lang/funcs/funcs_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package funcs
 
 // most of the testing of this package is inside of the adjacent `facts` package

lang/interpolate_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package lang
 
 import (

lang/interpret_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package lang
 
 import (

lang/lang_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package lang
 
 import (

lang/lexparse_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package lang
 
 import (

lang/types/type_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package types
 
 import (

lang/types/value_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package types
 
 import (

lang/unification_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package lang
 
 import (

lib/main_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package lib
 
 import (

pgraph/graphsync_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package pgraph
 
 import (

pgraph/pgraph_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package pgraph
 
 import (

pgraph/subgraph_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package pgraph
 
 import (

pgraph/util_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package pgraph
 
 import (

prometheus/prometheus_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package prometheus
 
 import (

test.sh

@@ -63,11 +63,22 @@ if env | grep -q -e '^TRAVIS=true$' -e '^JENKINS_URL=' -e '^BUILD_TAG=jenkins';
 	run-testsuite ./test/test-gotest.sh --race
 	run-testsuite ./test/test-integration.sh
 	run-testsuite ./test/test-integration.sh --race
+
+	# XXX: fix and enable these on travis (sudo: go: command not found)
+	#run-testsuite ./test/test-gotest.sh --root
+	#run-testsuite ./test/test-gotest.sh --root --race
+	#run-testsuite ./test/test-integration.sh --root
+	#run-testsuite ./test/test-integration.sh --root --race
 else
 	REASON="CI server only test" skip-testsuite ./test/test-shell.sh
 	REASON="CI server only test" skip-testsuite ./test/test-gotest.sh --race
 	REASON="CI server only test" skip-testsuite ./test/test-integration.sh
 	REASON="CI server only test" skip-testsuite ./test/test-integration.sh --race
+
+	REASON="CI server only test" skip-testsuite ./test/test-gotest.sh --root
+	REASON="CI server only test" skip-testsuite ./test/test-gotest.sh --root --race
+	REASON="CI server only test" skip-testsuite ./test/test-integration.sh --root
+	REASON="CI server only test" skip-testsuite ./test/test-integration.sh --root --race
 fi
 
 run-testsuite ./test/test-gometalinter.sh

test/test-gotest.sh

@@ -7,26 +7,38 @@ ROOT=$(dirname "${BASH_SOURCE}")/..
 cd "${ROOT}"
 . test/util.sh
 
+# if we want to run this test as root, use build tag -root to ask each test...
+XSUDO=''
+XTAGS=''
+if [[ "$@" = *"--root"* ]]; then
+	if ! timeout 1s sudo -A true; then
+		echo "sudo disabled: can't run as root"
+		exit 1
+	fi
+	XSUDO='sudo -E'
+	XTAGS='-tags root'
+fi
+
 failures=''
 function run-test()
 {
-	$@ || failures=$( [ -n "$failures" ] && echo "$failures\\n$@" || echo "$@" )
+	$XSUDO $@ || failures=$( [ -n "$failures" ] && echo "$failures\\n$@" || echo "$@" )
 }
 
 base=$(go list .)
 if [[ "$@" = *"--integration"* ]]; then
 	if [[ "$@" = *"--race"* ]]; then
-		run-test go test -race "${base}/integration" -v
+		GOCACHE=off run-test go test -race "${base}/integration" -v ${XTAGS}
 	else
-		run-test go test "${base}/integration" -v
+		GOCACHE=off run-test go test "${base}/integration" -v ${XTAGS}
 	fi
 else
 	for pkg in `go list -e ./... | grep -v "^${base}/vendor/" | grep -v "^${base}/examples/" | grep -v "^${base}/test/" | grep -v "^${base}/old" | grep -v "^${base}/old/" | grep -v "^${base}/tmp" | grep -v "^${base}/tmp/" | grep -v "^${base}/integration"`; do
 		echo -e "\ttesting: $pkg"
 		if [[ "$@" = *"--race"* ]]; then
-			run-test go test -race "$pkg"
+			GOCACHE=off run-test go test -race "$pkg" ${XTAGS}
 		else
-			run-test go test "$pkg"
+			GOCACHE=off run-test go test "$pkg" ${XTAGS}
 		fi
 	done
 fi

util/code_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package util
 
 import (

util/home_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package util
 
 import (

util/root_test.go

@@ -0,0 +1,37 @@
+// Mgmt
+// Copyright (C) 2013-2018+ James Shubin and the project contributors
+// Written by James Shubin <james@shubin.ca> and the project contributors
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+// +build root
+
+package util
+
+import (
+	"os/user"
+	"testing"
+)
+
+func TestIsRoot(t *testing.T) {
+	u, err := user.Current()
+	if err != nil {
+		t.Errorf("error running user.Current(): %+v", err)
+		return
+	}
+	if u.Uid != "0" {
+		t.Errorf("expected uid 0, got: %s", u.Uid)
+		return
+	}
+}

util/util_test.go

@@ -15,6 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+// +build !root
+
 package util
 
 import (