lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

resources: autoedges: Process in a deterministic order

Browse Source 
The order you loop through map's isn't necessarily stable, so make sure
you sort everything before you go through it.
This commit is contained in:
James Shubin
2017-06-02 22:29:42 -04:00
parent 4d9d0d4548
commit 0a64b08669
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
resources/autoedge.go
View File

@@ -94,8 +94,9 @@ func AutoEdges(g *pgraph.Graph) error {
// initially get all of the autoedges to seek out all possible errors // initially get all of the autoedges to seek out all possible errors
var err error var err error
autoEdgeObjVertexMap := make(map[pgraph.Vertex]AutoEdge) autoEdgeObjVertexMap := make(map[pgraph.Vertex]AutoEdge)
sorted := g.VerticesSorted()
for _, v := range g.VerticesSorted() { // for each vertexes autoedges for _, v := range sorted { // for each vertexes autoedges
if !VtoR(v).Meta().AutoEdge { // is the metaparam true? if !VtoR(v).Meta().AutoEdge { // is the metaparam true?
continue continue
} }
@@ -115,8 +116,12 @@ func AutoEdges(g *pgraph.Graph) error {
} }
// now that we're guaranteed error free, we can modify the graph safely // now that we're guaranteed error free, we can modify the graph safely
// TODO: loop through this in a sorted order for stable log output... for _, v := range sorted { // stable sort order for determinism in logs
for v, autoEdgeObj := range autoEdgeObjVertexMap { autoEdgeObj, exists := autoEdgeObjVertexMap[v]
if !exists {
continue
}
for { // while the autoEdgeObj has more uids to add... for { // while the autoEdgeObj has more uids to add...
uids := autoEdgeObj.Next() // get some! uids := autoEdgeObj.Next() // get some!
if uids == nil { if uids == nil {