lourenco/mgmt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lang: gapi: Duplicates are possible if we have a diamond dag

Browse Source 
Allow this, just remove them...
This commit is contained in:
James Shubin
2024-11-06 19:39:58 -05:00
parent a2ce9e890d
commit 098ab20ec9
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lang/gapi/gapi.go
View File

@@ -343,12 +343,8 @@ func (obj *GAPI) Cli(info *gapi.Info) (*gapi.Deploy, error) {
} }
} }
// TODO: do we still need this, now that we have the Imports DAG? // There are duplicates if in our dag we use the same import twice.
noDuplicates := util.StrRemoveDuplicatesInList(files) files = util.StrRemoveDuplicatesInList(files)
if len(noDuplicates) != len(files) {
// programming error here or in this logical test
return nil, fmt.Errorf("duplicates in file list found")
}
// Add any missing dirs, so that we don't need to use `MkdirAll`... // Add any missing dirs, so that we don't need to use `MkdirAll`...
// FIXME: It's possible that the dirs get generated upstream, but it's // FIXME: It's possible that the dirs get generated upstream, but it's