From 07bd8afc4ab3e649498ca6bccb317a7e04138007 Mon Sep 17 00:00:00 2001 From: James Shubin Date: Fri, 1 Sep 2023 19:02:11 -0400 Subject: [PATCH] engine: graph, metaparams: Default rewatch to false The frequency of graph changes makes it unlikely that you want this enabled on most resources by default. --- engine/metaparams.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/engine/metaparams.go b/engine/metaparams.go index d25e8256..cd5ccf19 100644 --- a/engine/metaparams.go +++ b/engine/metaparams.go @@ -37,7 +37,7 @@ var DefaultMetaParams = &MetaParams{ Limit: rate.Inf, // defaults to no limit Burst: 0, // no burst needed on an infinite rate //Sema: []string{}, - Rewatch: true, + Rewatch: false, Realize: false, // true would be more awesome, but unexpected for users } @@ -90,7 +90,9 @@ type MetaParams struct { // and add it back as a new vertex, thus causing it to run again. This // is different from the Retry metaparam which applies during the normal // execution. It is only when this is exhausted that we're in permanent - // worker failure, and only then can we rely on this metaparam. + // worker failure, and only then can we rely on this metaparam. This is + // false by default, as the frequency of graph changes makes it unlikely + // that you wanted this enabled on most resources. Rewatch bool `yaml:"rewatch"` // Realize ensures that the resource is guaranteed to converge at least