From 01c2131436dc77bb9ad922c62440efab2ff7ec60 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Evrard Date: Fri, 4 Dec 2020 11:34:56 +0100 Subject: [PATCH] misc: Make-deps should assume go vet present While the code comment says to check if go vet command is present, it actually tests if go vet command returns properly. This is a problem if go vet is _not_ returning 0 due to a failure while go vet is present: it will try to install the legacy go vet. This fixes it by removing this block of code completely, as we assume a golang version which contains it anyway. --- misc/make-deps.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/misc/make-deps.sh b/misc/make-deps.sh index d961114d..03cc7c3e 100755 --- a/misc/make-deps.sh +++ b/misc/make-deps.sh @@ -125,11 +125,6 @@ go get -v -t -d ./... # get all the go dependencies echo "done running 'go get -v -t -d ./...'" [ -e "$GOBIN/mgmt" ] && rm -f "$GOBIN/mgmt" # the `go get` version has no -X -# vet is built-in in go 1.6 - we check for go vet command -go vet 1> /dev/null 2>&1 -if [[ $? != 0 ]]; then - go get golang.org/x/tools/cmd/vet # add in `go vet` for travis -fi go get github.com/blynn/nex # for lexing go get golang.org/x/tools/cmd/goyacc # formerly `go tool yacc` go get golang.org/x/tools/cmd/stringer # for automatic stringer-ing